From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D840541E21; Thu, 9 Mar 2023 21:44:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCCE040ED7; Thu, 9 Mar 2023 21:44:31 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id CEFC240695 for ; Thu, 9 Mar 2023 21:44:30 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7DF405C0140; Thu, 9 Mar 2023 15:44:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 09 Mar 2023 15:44:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1678394669; x=1678481069; bh=DaWV3rYG/oD10Q3B7yUYqeahL6ogaqC+Gfo gY93HUWY=; b=Bp3QOJikBb1kqBFOBbLaIswvAOYgAZrAz3hdJqb5t5gOwamoziN SIx71OJQPei4PQotlUKb9hhXGWt1RItO65CxouJOCzRhnLDWxfNTabf6Gx/zT4cU veq4tvQkOMz6ULL1DPl7Kr3l9i1+Ffiorn1CDRrAPG+dz2UN/O5eD8R0Xy9PyUEe olXQ6XqWYdSM/MSAV+Jl0JvsaXT/tLO1/syIrlg/B/mYDEsBMO2w+ufzdl+ucPy/ DWmtVV4YmC+822fwHkjDRHizu/Y+41sQGKdri5rbljUBGghIQn3/AcEdy1hS4dFv j/Y18uPy4PAbM95S3LW68RVXX2pRvvWiFhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1678394669; x=1678481069; bh=DaWV3rYG/oD10Q3B7yUYqeahL6ogaqC+Gfo gY93HUWY=; b=QLRwEY+iEPur49xp4s5nddH/jaoJ74jC+ub9uFfAZPTT27joM/e 60DumnhGpJ+U2brX/2LJKp6CrM1mVr6VZmYe8V15i4SXGRIDYXP9gulC5JyFSsB3 cMttzJemPvTyBF44Y30iEMJcgWGz+7FYriNZOpabear+xXj6D+Zo9ycxNn06/zJB 7H5wyYDTLQHk9xfxuPA5HgRKbG/2AW/pOlyuZJ6I7wcRHTYpfM9j6i8AZxhqdDFt 1WyR16OmY9hvJ4gIfLlfvrzcpkndUgV5kkfdlE9O3f7lEjmY3RKMWmmgFxsCD/iZ yo4Ed3sGi9cD4/lrYAybGX+ZDuhh4HHQCzw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdduiedgudefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Mar 2023 15:44:28 -0500 (EST) From: Thomas Monjalon To: Srikanth Yalavarthi Cc: dev@dpdk.org, sshankarnara@marvell.com, jerinj@marvell.com, aprabhu@marvell.com, ptakkar@marvell.com, pshukla@marvell.com Subject: Re: [PATCH v6 1/4] mldev: add headers for internal ML functions Date: Thu, 09 Mar 2023 21:44:26 +0100 Message-ID: <13217238.dW097sEU6C@thomas> In-Reply-To: <20230207160008.30182-2-syalavarthi@marvell.com> References: <20221208193532.16718-1-syalavarthi@marvell.com> <20230207160008.30182-1-syalavarthi@marvell.com> <20230207160008.30182-2-syalavarthi@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/02/2023 17:00, Srikanth Yalavarthi: > Added header files for internal ML utility routines to convert > IO type and format to string, IO type to size and routines to > convert data types. > > Signed-off-by: Srikanth Yalavarthi > --- > Depends-on: series-26858 ("Implementation of mldev test application") I'm not sure it depends really on the test application. > doc/guides/rel_notes/release_23_03.rst | 5 + > lib/mldev/meson.build | 2 + > lib/mldev/mldev_utils.c | 5 + > lib/mldev/mldev_utils.h | 345 +++++++++++++++++++++++++ Instead of just adding the header file, it would have more sense to add the scalar implementation at the same time, and split IO type and conversion in different patches. > --- a/doc/guides/rel_notes/release_23_03.rst > +++ b/doc/guides/rel_notes/release_23_03.rst > +* **Added common driver functions for machine learning device library.** > + > + * Added functions to translate IO type and format to string. > + * Added functions to quantize and dequantize inference IO data. I don't think it does not deserve to be in the release notes.