* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
2021-04-13 7:15 ` David Marchand
@ 2021-04-13 7:31 ` Thomas Monjalon
2021-04-13 8:45 ` [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check Thomas Monjalon
` (2 subsequent siblings)
3 siblings, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2021-04-13 7:31 UTC (permalink / raw)
To: David Marchand
Cc: Timothy McDaniel, Jerin Jacob Kollanukkaran, Ray Kinsella,
Aaron Conole, dpdklab, abhinandan.gujjar, harry.van.haaren, dev,
Shijith Thotton, Akhil Goyal, Pavan Nikhilesh Bhagavatula,
mattias.ronnblom, ci, ferruh.yigit
13/04/2021 09:15, David Marchand:
> On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 12/04/2021 15:20, Jerin Jacob Kollanukkaran:
> > > http://dpdk.org/git/next/dpdk-next-eventdev
> >
> > Pulled, thanks.
> >
> > Note few changes in titles like uppercases for acronyms,
> > or "add support" simplified as "support",
> > and release notes moved in the right place.
>
> The ABI check now reports an error on event/dlb.
> The reason is that the event/dlb driver has been removed, and so the
> check complains about a missing dump.
> This will have to be fixed quickly or reverted.
>
>
> This has been missed by multiple people, so trying to understand why.
>
> The ABI check should have caught this when run by maintainers (/me
> looks at Thomas and Jerin).
>
> The CI should have caught it too.
> But, v1 did not apply.
> For v2, I can see a doc generation issue reported by Intel CI that I
> can't reproduce, so it could be just noise.
> I can't find reports for Travis or GHA and I could not find in the
> robot logs why the series_15708 branch was not created.
>
> Looking at UNH reports:
> http://mails.dpdk.org/archives/test-report/2021-March/182956.html
> But looking at the log:
> [2713/2716] Compiling C object
> 'drivers/a715181@@rte_event_octeontx2@sta/meson-generated_.._rte_event_octeontx2.pmd.c.o'.
> [2714/2716] Linking static target drivers/librte_event_octeontx2.a.
> [2715/2716] Generating rte_event_octeontx2.sym_chk with a meson_exe.py
> custom command.
> [2716/2716] Linking target drivers/librte_event_octeontx2.so.21.1.
> Error: cannot find librte_event_dlb.dump in
> /home-local/jenkins-local/jenkins-agent/workspace/Ubuntu18.04-Compile-DPDK-ABI/dpdk/build-gcc-shared/install
>
> Is this something that has been fixed since then?
>
> I don't have the main branch/recent series status from UNH, but at
> least GHA and Travis are now complaining about ABI.
Sorry about that, this is because I stupidly thought I could fix it
locally without thinking about the CI.
I am going to send a patch for devtools/libabigail.abignore.
^ permalink raw reply [flat|nested] 18+ messages in thread* [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check
2021-04-13 7:15 ` David Marchand
2021-04-13 7:31 ` Thomas Monjalon
@ 2021-04-13 8:45 ` Thomas Monjalon
2021-04-13 9:15 ` David Marchand
2021-04-13 16:09 ` Kinsella, Ray
2021-04-13 8:54 ` [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Jerin Jacob
2021-04-13 12:58 ` Aaron Conole
3 siblings, 2 replies; 18+ messages in thread
From: Thomas Monjalon @ 2021-04-13 8:45 UTC (permalink / raw)
To: dev; +Cc: jerinj, David Marchand, Ray Kinsella, Neil Horman, Timothy McDaniel
The eventdev driver DLB was removed in DPDK 21.05,
breaking the ABI check.
The exception was agreed so we just need to skip this check.
Note: complete removal of a driver cannot be ignored
in devtools/libabigail.abignore, so the script must be patched.
Fixes: 698fa829415d ("event/dlb: remove driver")
Reported-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
This should have been done as part of removing the driver.
The CI is currently broken, so it should be merged today.
---
devtools/check-abi.sh | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh
index 9835e346da..ca523eb94c 100755
--- a/devtools/check-abi.sh
+++ b/devtools/check-abi.sh
@@ -44,6 +44,10 @@ for dump in $(find $refdir -name "*.dump"); do
echo "Skipped glue library $name."
continue
fi
+ if grep -qE "\<soname='librte_event_dlb\.so" $dump; then
+ echo "Skipped removed driver $name."
+ continue
+ fi
dump2=$(find $newdir -name $name)
if [ -z "$dump2" ] || [ ! -e "$dump2" ]; then
echo "Error: cannot find $name in $newdir" >&2
--
2.31.1
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check
2021-04-13 8:45 ` [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check Thomas Monjalon
@ 2021-04-13 9:15 ` David Marchand
2021-04-13 9:32 ` Thomas Monjalon
2021-04-13 16:09 ` Kinsella, Ray
1 sibling, 1 reply; 18+ messages in thread
From: David Marchand @ 2021-04-13 9:15 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, Jerin Jacob Kollanukkaran, Ray Kinsella, Neil Horman,
Timothy McDaniel
On Tue, Apr 13, 2021 at 10:45 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The eventdev driver DLB was removed in DPDK 21.05,
> breaking the ABI check.
> The exception was agreed so we just need to skip this check.
>
> Note: complete removal of a driver cannot be ignored
> in devtools/libabigail.abignore, so the script must be patched.
Indeed, abidiff wants to compare two shared libraries/dumps.
In this situation, we don't have a second library/dump.
>
> Fixes: 698fa829415d ("event/dlb: remove driver")
>
> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check
2021-04-13 9:15 ` David Marchand
@ 2021-04-13 9:32 ` Thomas Monjalon
0 siblings, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2021-04-13 9:32 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, Timothy McDaniel
Cc: dev, Ray Kinsella, David Marchand
13/04/2021 11:15, David Marchand:
> On Tue, Apr 13, 2021 at 10:45 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > The eventdev driver DLB was removed in DPDK 21.05,
> > breaking the ABI check.
> > The exception was agreed so we just need to skip this check.
> >
> > Note: complete removal of a driver cannot be ignored
> > in devtools/libabigail.abignore, so the script must be patched.
>
> Indeed, abidiff wants to compare two shared libraries/dumps.
> In this situation, we don't have a second library/dump.
>
> > Fixes: 698fa829415d ("event/dlb: remove driver")
> >
> > Reported-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check
2021-04-13 8:45 ` [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check Thomas Monjalon
2021-04-13 9:15 ` David Marchand
@ 2021-04-13 16:09 ` Kinsella, Ray
2021-04-13 16:44 ` Thomas Monjalon
1 sibling, 1 reply; 18+ messages in thread
From: Kinsella, Ray @ 2021-04-13 16:09 UTC (permalink / raw)
To: Thomas Monjalon, dev
Cc: jerinj, David Marchand, Neil Horman, Timothy McDaniel
On 13/04/2021 09:45, Thomas Monjalon wrote:
> The eventdev driver DLB was removed in DPDK 21.05,
> breaking the ABI check.
> The exception was agreed so we just need to skip this check.
>
> Note: complete removal of a driver cannot be ignored
> in devtools/libabigail.abignore, so the script must be patched.
>
> Fixes: 698fa829415d ("event/dlb: remove driver")
>
> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> This should have been done as part of removing the driver.
> The CI is currently broken, so it should be merged today.
> ---
> devtools/check-abi.sh | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh
> index 9835e346da..ca523eb94c 100755
> --- a/devtools/check-abi.sh
> +++ b/devtools/check-abi.sh
> @@ -44,6 +44,10 @@ for dump in $(find $refdir -name "*.dump"); do
> echo "Skipped glue library $name."
> continue
> fi
> + if grep -qE "\<soname='librte_event_dlb\.so" $dump; then
> + echo "Skipped removed driver $name."
> + continue
> + fi
So this is brute force fix - we can anticipate this problem happening again.
Perhaps a 2nd file called devtools/libabigail.soignore, if agreed I will submit a patch?
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check
2021-04-13 16:09 ` Kinsella, Ray
@ 2021-04-13 16:44 ` Thomas Monjalon
2021-04-13 16:45 ` Kinsella, Ray
0 siblings, 1 reply; 18+ messages in thread
From: Thomas Monjalon @ 2021-04-13 16:44 UTC (permalink / raw)
To: Kinsella, Ray; +Cc: dev, jerinj, David Marchand, Neil Horman, Timothy McDaniel
13/04/2021 18:09, Kinsella, Ray:
> On 13/04/2021 09:45, Thomas Monjalon wrote:
> > The eventdev driver DLB was removed in DPDK 21.05,
> > breaking the ABI check.
> > The exception was agreed so we just need to skip this check.
> >
> > Note: complete removal of a driver cannot be ignored
> > in devtools/libabigail.abignore, so the script must be patched.
> >
> > Fixes: 698fa829415d ("event/dlb: remove driver")
> >
> > Reported-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > This should have been done as part of removing the driver.
> > The CI is currently broken, so it should be merged today.
> > ---
> > devtools/check-abi.sh | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh
> > index 9835e346da..ca523eb94c 100755
> > --- a/devtools/check-abi.sh
> > +++ b/devtools/check-abi.sh
> > @@ -44,6 +44,10 @@ for dump in $(find $refdir -name "*.dump"); do
> > echo "Skipped glue library $name."
> > continue
> > fi
> > + if grep -qE "\<soname='librte_event_dlb\.so" $dump; then
> > + echo "Skipped removed driver $name."
> > + continue
> > + fi
>
> So this is brute force fix - we can anticipate this problem happening again.
> Perhaps a 2nd file called devtools/libabigail.soignore, if agreed I will submit a patch?
Yes indeed we could have a file for this.
Maybe we could have a dedicated section [suppress_lib]
in the existing file if libabigail is OK with unknown sections?
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check
2021-04-13 16:44 ` Thomas Monjalon
@ 2021-04-13 16:45 ` Kinsella, Ray
0 siblings, 0 replies; 18+ messages in thread
From: Kinsella, Ray @ 2021-04-13 16:45 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, jerinj, David Marchand, Neil Horman, Timothy McDaniel
On 13/04/2021 17:44, Thomas Monjalon wrote:
> 13/04/2021 18:09, Kinsella, Ray:
>> On 13/04/2021 09:45, Thomas Monjalon wrote:
>>> The eventdev driver DLB was removed in DPDK 21.05,
>>> breaking the ABI check.
>>> The exception was agreed so we just need to skip this check.
>>>
>>> Note: complete removal of a driver cannot be ignored
>>> in devtools/libabigail.abignore, so the script must be patched.
>>>
>>> Fixes: 698fa829415d ("event/dlb: remove driver")
>>>
>>> Reported-by: David Marchand <david.marchand@redhat.com>
>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>> ---
>>> This should have been done as part of removing the driver.
>>> The CI is currently broken, so it should be merged today.
>>> ---
>>> devtools/check-abi.sh | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh
>>> index 9835e346da..ca523eb94c 100755
>>> --- a/devtools/check-abi.sh
>>> +++ b/devtools/check-abi.sh
>>> @@ -44,6 +44,10 @@ for dump in $(find $refdir -name "*.dump"); do
>>> echo "Skipped glue library $name."
>>> continue
>>> fi
>>> + if grep -qE "\<soname='librte_event_dlb\.so" $dump; then
>>> + echo "Skipped removed driver $name."
>>> + continue
>>> + fi
>>
>> So this is brute force fix - we can anticipate this problem happening again.
>> Perhaps a 2nd file called devtools/libabigail.soignore, if agreed I will submit a patch?
>
> Yes indeed we could have a file for this.
> Maybe we could have a dedicated section [suppress_lib]
> in the existing file if libabigail is OK with unknown sections?
>
That would be tidier - I will take a look.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
2021-04-13 7:15 ` David Marchand
2021-04-13 7:31 ` Thomas Monjalon
2021-04-13 8:45 ` [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check Thomas Monjalon
@ 2021-04-13 8:54 ` Jerin Jacob
2021-04-13 9:01 ` Thomas Monjalon
2021-04-13 9:07 ` David Marchand
2021-04-13 12:58 ` Aaron Conole
3 siblings, 2 replies; 18+ messages in thread
From: Jerin Jacob @ 2021-04-13 8:54 UTC (permalink / raw)
To: David Marchand
Cc: Thomas Monjalon, Timothy McDaniel, Jerin Jacob Kollanukkaran,
Ray Kinsella, Aaron Conole, dpdklab, abhinandan.gujjar,
harry.van.haaren, dev, Shijith Thotton, Akhil Goyal,
Pavan Nikhilesh Bhagavatula, mattias.ronnblom, ci
On Tue, Apr 13, 2021 at 12:46 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 12/04/2021 15:20, Jerin Jacob Kollanukkaran:
> > > http://dpdk.org/git/next/dpdk-next-eventdev
> >
> > Pulled, thanks.
> >
> > Note few changes in titles like uppercases for acronyms,
> > or "add support" simplified as "support",
> > and release notes moved in the right place.
>
> The ABI check now reports an error on event/dlb.
> The reason is that the event/dlb driver has been removed, and so the
> check complains about a missing dump.
> This will have to be fixed quickly or reverted.
>
>
> This has been missed by multiple people, so trying to understand why.
I was running the following script[1] to detect ABI issues.
Since the "./devtools/test-meson-builds.sh" did not return non zero value or
the error print was "Error: cannot find librte_event_dlb.dump", It is
missed from my side.
@David Marchand @Thomas Monjalon Could you share the snippet you are
using for detecting the ABI issue.
------------------------
# ABI check
DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash
./devtools/test-meson-builds.sh 1> /tmp/build.log 2> /tmp/build.log
if [ $? -ne 0 ]; then
echo "ABI check failed"
exit
fi
grep "Error: ABI issue reported" /tmp/build.log
if [ $? -eq 0 ]; then
echo "ABI issue"
exit
fi
-------------------------------------------------------
>
> The ABI check should have caught this when run by maintainers (/me
> looks at Thomas and Jerin).
Sorry for that :-(
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
2021-04-13 8:54 ` [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Jerin Jacob
@ 2021-04-13 9:01 ` Thomas Monjalon
2021-04-13 9:07 ` David Marchand
1 sibling, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2021-04-13 9:01 UTC (permalink / raw)
To: Jerin Jacob
Cc: David Marchand, Timothy McDaniel, Jerin Jacob Kollanukkaran,
Ray Kinsella, Aaron Conole, dpdklab, abhinandan.gujjar,
harry.van.haaren, dev, Shijith Thotton, Akhil Goyal,
Pavan Nikhilesh Bhagavatula, mattias.ronnblom, ci
13/04/2021 10:54, Jerin Jacob:
> On Tue, Apr 13, 2021 at 12:46 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > 12/04/2021 15:20, Jerin Jacob Kollanukkaran:
> > > > http://dpdk.org/git/next/dpdk-next-eventdev
> > >
> > > Pulled, thanks.
> > >
> > > Note few changes in titles like uppercases for acronyms,
> > > or "add support" simplified as "support",
> > > and release notes moved in the right place.
> >
> > The ABI check now reports an error on event/dlb.
> > The reason is that the event/dlb driver has been removed, and so the
> > check complains about a missing dump.
> > This will have to be fixed quickly or reverted.
> >
> >
> > This has been missed by multiple people, so trying to understand why.
>
>
> I was running the following script[1] to detect ABI issues.
> Since the "./devtools/test-meson-builds.sh" did not return non zero value or
> the error print was "Error: cannot find librte_event_dlb.dump", It is
> missed from my side.
>
> @David Marchand @Thomas Monjalon Could you share the snippet you are
> using for detecting the ABI issue.
I do like you: simply run test-meson-builds.sh
And yes I saw the error, and I don't know why I thought it was OK!
We are humans :)
> ------------------------
> # ABI check
> DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash
> ./devtools/test-meson-builds.sh 1> /tmp/build.log 2> /tmp/build.log
> if [ $? -ne 0 ]; then
> echo "ABI check failed"
> exit
> fi
>
> grep "Error: ABI issue reported" /tmp/build.log
> if [ $? -eq 0 ]; then
> echo "ABI issue"
> exit
> fi
>
> -------------------------------------------------------
> >
> > The ABI check should have caught this when run by maintainers (/me
> > looks at Thomas and Jerin).
>
> Sorry for that :-(
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
2021-04-13 8:54 ` [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Jerin Jacob
2021-04-13 9:01 ` Thomas Monjalon
@ 2021-04-13 9:07 ` David Marchand
2021-04-13 9:12 ` Thomas Monjalon
2021-04-13 9:14 ` David Marchand
1 sibling, 2 replies; 18+ messages in thread
From: David Marchand @ 2021-04-13 9:07 UTC (permalink / raw)
To: Jerin Jacob
Cc: Thomas Monjalon, Timothy McDaniel, Jerin Jacob Kollanukkaran,
Ray Kinsella, Aaron Conole, dpdklab, abhinandan.gujjar,
harry.van.haaren, dev, Shijith Thotton, Akhil Goyal,
Pavan Nikhilesh Bhagavatula, mattias.ronnblom, ci
On Tue, Apr 13, 2021 at 10:55 AM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> I was running the following script[1] to detect ABI issues.
> Since the "./devtools/test-meson-builds.sh" did not return non zero value or
> the error print was "Error: cannot find librte_event_dlb.dump", It is
> missed from my side.
>
> @David Marchand @Thomas Monjalon Could you share the snippet you are
> using for detecting the ABI issue.
>
>
> ------------------------
> # ABI check
> DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash
Ah ok, this is because event/dlb did not exist in 20.11.
Running against 21.02, you should get the error.
--
David Marchand
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
2021-04-13 9:07 ` David Marchand
@ 2021-04-13 9:12 ` Thomas Monjalon
2021-04-13 9:14 ` David Marchand
1 sibling, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2021-04-13 9:12 UTC (permalink / raw)
To: Jerin Jacob, David Marchand
Cc: Timothy McDaniel, Jerin Jacob Kollanukkaran, Ray Kinsella,
Aaron Conole, dpdklab, abhinandan.gujjar, harry.van.haaren, dev,
Shijith Thotton, Akhil Goyal, Pavan Nikhilesh Bhagavatula,
mattias.ronnblom, ci
13/04/2021 11:07, David Marchand:
> On Tue, Apr 13, 2021 at 10:55 AM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> > I was running the following script[1] to detect ABI issues.
> > Since the "./devtools/test-meson-builds.sh" did not return non zero value or
> > the error print was "Error: cannot find librte_event_dlb.dump", It is
> > missed from my side.
> >
> > @David Marchand @Thomas Monjalon Could you share the snippet you are
> > using for detecting the ABI issue.
> >
> >
> > ------------------------
> > # ABI check
> > DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash
>
> Ah ok, this is because event/dlb did not exist in 20.11.
No it was added in 20.11.
> Running against 21.02, you should get the error.
Yes we should always run the ABI check against the latest release.
It means you must upgrade DPDK_ABI_REF_VERSION after each release.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
2021-04-13 9:07 ` David Marchand
2021-04-13 9:12 ` Thomas Monjalon
@ 2021-04-13 9:14 ` David Marchand
1 sibling, 0 replies; 18+ messages in thread
From: David Marchand @ 2021-04-13 9:14 UTC (permalink / raw)
To: Jerin Jacob
Cc: Thomas Monjalon, Timothy McDaniel, Jerin Jacob Kollanukkaran,
Ray Kinsella, Aaron Conole, dpdklab, abhinandan.gujjar,
harry.van.haaren, dev, Shijith Thotton, Akhil Goyal,
Pavan Nikhilesh Bhagavatula, mattias.ronnblom, ci
On Tue, Apr 13, 2021 at 11:07 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Tue, Apr 13, 2021 at 10:55 AM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> > I was running the following script[1] to detect ABI issues.
> > Since the "./devtools/test-meson-builds.sh" did not return non zero value or
> > the error print was "Error: cannot find librte_event_dlb.dump", It is
> > missed from my side.
> >
> > @David Marchand @Thomas Monjalon Could you share the snippet you are
> > using for detecting the ABI issue.
> >
> >
> > ------------------------
> > # ABI check
> > DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash
>
> Ah ok, this is because event/dlb did not exist in 20.11.
> Running against 21.02, you should get the error.
Clicked send too quickly...
No, it did exist.
$ DPDK_ABI_REF_VERSION=v20.11 ./devtools/test-meson-builds.sh
ninja: Entering directory `/home/dmarchan/builds/build-gcc-static'
ninja: no work to do.
ninja: Entering directory `/home/dmarchan/builds/build-gcc-shared'
ninja: no work to do.
Error: cannot find librte_event_dlb.dump in
/home/dmarchan/builds/build-gcc-shared/install
Hum... the next reason I see would be that your reference does not
have event/dlb which is surprising with default configuration.
$ ls $DPDK_ABI_REF_DIR/*/*/dump/*dlb.dump
/home/dmarchan/abi/v20.11/build-clang-shared/dump/librte_event_dlb.dump
/home/dmarchan/abi/v21.02/build-clang-shared/dump/librte_event_dlb.dump
/home/dmarchan/abi/v20.11/build-gcc-shared/dump/librte_event_dlb.dump
/home/dmarchan/abi/v21.02/build-gcc-shared/dump/librte_event_dlb.dump
--
David Marchand
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
2021-04-13 7:15 ` David Marchand
` (2 preceding siblings ...)
2021-04-13 8:54 ` [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Jerin Jacob
@ 2021-04-13 12:58 ` Aaron Conole
3 siblings, 0 replies; 18+ messages in thread
From: Aaron Conole @ 2021-04-13 12:58 UTC (permalink / raw)
To: David Marchand
Cc: Thomas Monjalon, Timothy McDaniel, Jerin Jacob Kollanukkaran,
Ray Kinsella, dpdklab, abhinandan.gujjar, harry.van.haaren, dev,
Shijith Thotton, Akhil Goyal, Pavan Nikhilesh Bhagavatula,
mattias.ronnblom, ci
David Marchand <david.marchand@redhat.com> writes:
> On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>>
>> 12/04/2021 15:20, Jerin Jacob Kollanukkaran:
>> > http://dpdk.org/git/next/dpdk-next-eventdev
>>
>> Pulled, thanks.
>>
>> Note few changes in titles like uppercases for acronyms,
>> or "add support" simplified as "support",
>> and release notes moved in the right place.
>
> The ABI check now reports an error on event/dlb.
> The reason is that the event/dlb driver has been removed, and so the
> check complains about a missing dump.
> This will have to be fixed quickly or reverted.
>
>
> This has been missed by multiple people, so trying to understand why.
>
> The ABI check should have caught this when run by maintainers (/me
> looks at Thomas and Jerin).
>
> The CI should have caught it too.
> But, v1 did not apply.
> For v2, I can see a doc generation issue reported by Intel CI that I
> can't reproduce, so it could be just noise.
> I can't find reports for Travis or GHA and I could not find in the
> robot logs why the series_15708 branch was not created.
I need to go back in the logs - there were a few cases during a
change-over that the robot wasn't running right.
> Looking at UNH reports:
> http://mails.dpdk.org/archives/test-report/2021-March/182956.html
> But looking at the log:
> [2713/2716] Compiling C object
> 'drivers/a715181@@rte_event_octeontx2@sta/meson-generated_.._rte_event_octeontx2.pmd.c.o'.
> [2714/2716] Linking static target drivers/librte_event_octeontx2.a.
> [2715/2716] Generating rte_event_octeontx2.sym_chk with a meson_exe.py
> custom command.
> [2716/2716] Linking target drivers/librte_event_octeontx2.so.21.1.
> Error: cannot find librte_event_dlb.dump in
> /home-local/jenkins-local/jenkins-agent/workspace/Ubuntu18.04-Compile-DPDK-ABI/dpdk/build-gcc-shared/install
>
> Is this something that has been fixed since then?
>
> I don't have the main branch/recent series status from UNH, but at
> least GHA and Travis are now complaining about ABI.
^ permalink raw reply [flat|nested] 18+ messages in thread