From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5714A0093; Mon, 15 Jun 2020 11:42:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 268524C90; Mon, 15 Jun 2020 11:42:10 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id D1395100C for ; Mon, 15 Jun 2020 11:42:07 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 36E4B580189; Mon, 15 Jun 2020 05:42:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 15 Jun 2020 05:42:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= uiAtWMaRvH67mz6q2TpRwK3vc3onRCPOqt56BR/TEIo=; b=GigBlYnSBvta7dLW gON4oa4t99KOdHUzLXYdbmEQWWALBD4/jbEAvJJDx5JtkIbtj2bPjeP78NINdHL9 YGsNr99w0Pkg1Ohj2Ubzj76BRQ+f4GiKYkkVoCQq2T3cCJxSpCwKB6g0ZItxg2K1 C+lRObbchxMQM+CmHDD5MbtJ5aANncpuXtlFWvdSNy+PQqABNdXoNZdWPwiXO7rU 3RQTpsT3vTOntqjn0+nay6aX/bTjNAB3Tptyi7cOJ8BTij0TQZkRZsvwovZcZn3e VOdRy0rdK0VTw52CpyOC4RHdOrxE8bCo+JX+oeOuWsSHkp2SopfB27SqJrpasuKw VAGjPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=uiAtWMaRvH67mz6q2TpRwK3vc3onRCPOqt56BR/TE Io=; b=G+0uqkU7o8PatyEJHtmxLrixTlnetVGqml4CiUCsM/gHSN50YKDbyQUxz tfvFha1ybmLaZfKD3YmKoAv+SrqZnVuQSmrbsC7Wf/yCBphVpHlVBv+Azb2s9S4D iihV0aipeKvsjroFpipbPnMeSuaJ4BxxXVf2tNulnt9ow6TfTn3VFrF3/arQfeJu 1RshvnBj0pWnNpeI5wXySAE0mfal58N3uuQQziVXVGBaQEJGaXJk6B5IOdH86H+a 7KnfEbK9uX2HZmQ8bylO/F6M7mjIK5e/H1+PxOVRodXQw/lE5FPHfolwjgm8rRUx Gy/nzgIxme/zJ9Hd4EruRyZSNF4JA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeikedgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D93DB3060FE7; Mon, 15 Jun 2020 05:42:05 -0400 (EDT) From: Thomas Monjalon To: Tasnim Bashar Cc: dev@dpdk.org, harini.ramakrishnan@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, ocardona@microsoft.com, navasile@linux.microsoft.com, dmitry.kozliuk@gmail.com, talshn@mellanox.com, fady@mellanox.com, ophirmu@mellanox.com Date: Mon, 15 Jun 2020 11:42:04 +0200 Message-ID: <13269652.10yzYP2DCA@thomas> In-Reply-To: <20200602020052.4540-1-tbashar@mellanox.com> References: <20200522001112.48932-1-tbashar@mellanox.com> <20200602020052.4540-1-tbashar@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/06/2020 04:00, Tasnim Bashar: > #define pthread_setaffinity_np(thread, size, cpuset) \ > - eal_set_thread_affinity_mask(thread, (unsigned long *) cpuset) > + eal_set_thread_affinity_mask(thread, cpuset) > #define pthread_getaffinity_np(thread, size, cpuset) \ > - eal_get_thread_affinity_mask(thread, (unsigned long *) cpuset) > + eal_get_thread_affinity_mask(thread, cpuset) > #define pthread_create(threadid, threadattr, threadfunc, args) \ > eal_create_thread(threadid, threadfunc, args) > > static inline int > -eal_set_thread_affinity_mask(pthread_t threadid, unsigned long *cpuset) > +eal_set_thread_affinity_mask(pthread_t threadid, rte_cpuset_t *cpuset) [...] > static inline int > -eal_get_thread_affinity_mask(pthread_t threadid, unsigned long *cpuset) > +eal_get_thread_affinity_mask(pthread_t threadid, rte_cpuset_t *cpuset) I don't understand the need for the #define. Why not naming the functions with the final pthread standard name?