From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2E54A0579; Mon, 19 Apr 2021 23:59:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4436141471; Mon, 19 Apr 2021 23:59:08 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id CF5EA41448 for ; Mon, 19 Apr 2021 23:59:06 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id EAB5A5C02C4; Mon, 19 Apr 2021 17:59:05 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 19 Apr 2021 17:59:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= KE8PDurHhZ6eXOUIP0tMLH/e0FZLa4kWZMtYppOungc=; b=V0RW26wD5pjEx19M y9AdtP9W6Ik1IPvI2vknDzWeAiWZaNC1Fzb2Y0bCSMJt8TLMZiB6OK2LAW5IhWnR dQw3fkCDFbilTXCmOYCrjQkgNvBXsNjOdiZCsYSYTdNoB52lhwWilVn7iGVTl/e6 sdsR9UlmKTWnyTXIwTYysh4L4bM8jtAiiU4cZ0jjWeCAknoGKwpxIafp13dnaxFX 2yfTM+T3/PoROSnw1qSoxeP/DMnmF/UvGBZBr5bIMH4nzKluTXZ5S2BEXRr2cG2H rGpifLoJcis+6MZoMtOzAPq8/q6yMAqFktr7dWjJqoJpNqf1KAbmtbNT9gRoxpzw c40qaw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=KE8PDurHhZ6eXOUIP0tMLH/e0FZLa4kWZMtYppOun gc=; b=thULlAUiW/BmI8zlS7zqjbmKVHJKzv7678TuETHIQgcRqpFt1wXknkWDc J7yKZw0hzZnjGsczL6Jbcls9+fR2pirvzVN7EEsKEXf1p7//fXRJyPZvF1a3wmQ5 i25UBzpZ81XNanURMDnpStkuPQtf2m274oGz7A4uZjFuA741kCnu2PQhRlliy+4Y GBaRyoUHcB7ayumWj4C+65S8nNyUnAXudC1OWIavdyfs4VvalbYqothf5es7JGHm ACzWTYNJl5gZYiVKHzdBlSMpSlT6ZHiCurQXxgu/xGDnQowCjXHdj65LpEvuYwwT SbR8KKxCVtDiwZyw82FpnZvBLSoVA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddthedgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3551B1080067; Mon, 19 Apr 2021 17:59:04 -0400 (EDT) From: Thomas Monjalon To: Li Zhang , Ferruh Yigit Cc: orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com, dev@dpdk.org, rasland@nvidia.com, asafp@nvidia.com, jiaweiw@nvidia.com Date: Mon, 19 Apr 2021 23:59:01 +0200 Message-ID: <13272139.9o7rTQ05r0@thomas> In-Reply-To: <2c4adae7-e0b5-7125-5bb6-6e8ec6840fef@intel.com> References: <20210331073632.1443011-1-lizh@nvidia.com> <20210415151135.2098674-1-lizh@nvidia.com> <2c4adae7-e0b5-7125-5bb6-6e8ec6840fef@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 00/14] Add ASO meter support in MLX5 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/04/2021 23:42, Ferruh Yigit: > On 4/15/2021 4:11 PM, Li Zhang wrote: > > To support more meters and better performance, > > MLX HW provide ASO flow meter. > > It can expose millions of ASO flow meter context's in HW. > > This ASO object can allocate the large bulk meter objects. > > This patch set implement the ASO flow meter for mlx5 driver. > > MLX5 PMD driver will be responsible for ASO flow meter manage to HW. > > > > What is ASO? > Search yields "Advanced Steering Operation" but that seems Mellanox jargon, > would you mind adding some mlx documentation to describe it? If there are some > design considerations around it, it may be good to document that too. > Also please provide the long version of the abbreviation in the commit log, at > least at first usage of it. > > And what do you think mentioning from this new support in the release notes? Yes, new PMD feature should be announced in the release notes, it seems to be a miss. > > doc/guides/nics/mlx5.rst | 6 + > > drivers/common/mlx5/mlx5_devx_cmds.c | 68 ++ > > drivers/common/mlx5/mlx5_devx_cmds.h | 26 +- > > drivers/common/mlx5/mlx5_prm.h | 81 +- > > drivers/common/mlx5/version.map | 1 + > > drivers/net/mlx5/linux/mlx5_os.c | 20 +- > > drivers/net/mlx5/meson.build | 2 +- > > drivers/net/mlx5/mlx5.c | 98 +- > > drivers/net/mlx5/mlx5.h | 258 +++++- > > drivers/net/mlx5/mlx5_flow.c | 334 +++++-- > > drivers/net/mlx5/mlx5_flow.h | 212 ++--- > > .../mlx5/{mlx5_flow_age.c => mlx5_flow_aso.c} | 289 +++++- > > drivers/net/mlx5/mlx5_flow_dv.c | 792 +++++++++++----- > > drivers/net/mlx5/mlx5_flow_meter.c | 873 ++++++++++++------ > > drivers/net/mlx5/mlx5_utils.h | 90 ++ > > 15 files changed, 2320 insertions(+), 830 deletions(-)