From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 9184F2B89 for ; Fri, 8 Apr 2016 22:33:52 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id n3so35910337wmn.0 for ; Fri, 08 Apr 2016 13:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=E+qgXNjdLNqQiUkD387PIiumhvHeUp3BnySZpJ7oDno=; b=p6GkxjABht59thM357niOY7ygmyNw3onk7t20GRcwCiRcujoP8mkrwZG3tZzfk4bb3 45/wFFPpf/WRc07t6k8nNhzC3DzGUvoxc/9aOG4VUOtpgKca7nxolwM7jyrWNrk4O9cJ 0rMN3VMCfX1WySgnIlhTL/+RQ6xRR0V607Yykh/4TXdb28lP5GMtccLrwmQFg68IF8Om vvlZeLk9h/LLDEUDdng+wTSvvUU04Wrwm3GfUmvKSI/+JhVqABZiRB9gnhiS8zynhdoP TbrjeQnxRpX1U/syrdLCCuz6kP9nlc2fpcTjDKNc6pNXpwt8tknyucIw42iAw4o0km+4 RtlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=E+qgXNjdLNqQiUkD387PIiumhvHeUp3BnySZpJ7oDno=; b=DfIkItbkmdmsdoS5EkaWE7yWhRn7gixjTINLkAFaVq3oe8KkB5SVB6D54lA9JciDJl 2J6wkrSM5+WdNuga4Q/+iqgjF8Fz2pJU0m4ZHuBsPQ9xH0WGthlU7GuZCAgkb5dSTgKL A95FaGjsaeHtIRpDx8LVpZxYbc8mniDrKraOhUIs5tNrdRZ9U2kaAWpg2Zu2jno+/Yvp ymvnoQ8qYD6g2/ac/nSs3WwLaYnM7MRKQG90L+k/dozzfGaKM4HhDRccLJyv+xFvAPpi QbQApUtnGbnl4w08T/NqCCFBd01YoGXHGcEzLMHPXVnCr6/Y2Oq3XdKR+KtihEPRIj52 DJ3A== X-Gm-Message-State: AD7BkJIDKuvoR4JiDmJn04ZsdKgFU9vBBZs3AP/qvqj2initZ8XZQA8wC/d8JnLZgG4td/1E X-Received: by 10.28.93.85 with SMTP id r82mr6064305wmb.77.1460147632362; Fri, 08 Apr 2016 13:33:52 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id qb8sm15038494wjc.24.2016.04.08.13.33.51 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 08 Apr 2016 13:33:51 -0700 (PDT) From: Thomas Monjalon To: Wenzhuo Lu Cc: dev@dpdk.org Date: Fri, 08 Apr 2016 22:33:50 +0200 Message-ID: <132741628.p6QkLo90Ee@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1460103024-20369-1-git-send-email-wenzhuo.lu@intel.com> References: <1460103024-20369-1-git-send-email-wenzhuo.lu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix wrong packet type for VxLAN & NVGRE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2016 20:33:52 -0000 2016-04-08 16:10, Wenzhuo Lu: > VxLAN & NVGRE are supported by x550. As we know HW can parse > the packet and tell SW the type info. For VxLAN & NVGRE packets > there's some change. HW will not tell SW the info of the outer > header but the inner header instead. But we always take the > info as it's for the outer header. So the packet type info is > not right when x550 receives VxLAN & NVGRE packets. > > As x550 only supports IPv4 VxLAN & NVGRE packets, we can tell > the outer header of VxLAN is IPv4 + UDP, and the outer header > of NVGRE is IPv4 only. What we don't know is if there's > optional field in the outer IPv4 header. > > This patch implement the support of packet type for VxLAN & > NVGRE. And it fixes the wrong packet type issue either. > > BTW: > It doesn't fix any existing commit as although it resolve an > issue it's more like a new feature but not a fix. > > Reported-by: Konstantin Ananyev > Signed-off-by: Wenzhuo Lu Applied, thanks