From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21D5C424A3; Fri, 27 Jan 2023 16:01:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 028B340150; Fri, 27 Jan 2023 16:01:20 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id AAE2940146 for ; Fri, 27 Jan 2023 16:01:18 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 0F7B05C00FC; Fri, 27 Jan 2023 10:01:18 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 27 Jan 2023 10:01:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674831678; x= 1674918078; bh=D5owmHQkT5Lpbq8N7Q+5DmHzyc3pVPOtOXzvopn1k8c=; b=e jQ1qipmN8Gewo3sKhe0GW8M2wonFZ4carkF7Jo7xsMpfMs5TWuYfo90uM5f0bFka 7aagMEfqnZtVAFGtH0FIW/S4u/Z2WhY0rZSekBi1+pzMDP/X2YbFxLT59bKjKeDl PH7z1h56ghDM+GH4S7NsZiySctOaL454Zfo3cOxAhmx6hIAFM25njCrK3PkRr2FN q15EiEyMp4P3UOzKF/ARJLDEoaPNE51Tsp3pGTR70svB+Lo2Nh5rnBbjP+sv8iFf bpFTQsxa8aYnb7ZAzPhiG8PE+VYTD/jxzzm0vYJTT9S2CDMir7znc15/DZWaA3BA vst2b+E83cOhmeCBfSsqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674831678; x= 1674918078; bh=D5owmHQkT5Lpbq8N7Q+5DmHzyc3pVPOtOXzvopn1k8c=; b=s Ei6ahtG+LN6Qdys42lue9a2U28orXb89vWtUegDzwbdJVGO2sFJcNix5AgxrcDaB eYZ2lqZuzOUq+3Tdi6LIaBqjMOoZU1oNLWSuHJLJWddhKuf9n4YtGQUsiwMhDNob bkVn1srp/w+OIfYD2kOr7fze0mBb032pG67LWROsLTsmsHikfBvNSItWXn8NY4XH gRVF2zVBB6trxDE5UZioSRQMHXCEWau7AeFJI1WLb28lLj9GRNU3faFnfqjZHhia K4KM8VTJpH/G1tXMtPyszq/7abX73m/nucFENfXNuCMsSfI9EI9HG7OnLfoYX46X GMapcAw2LXok8dLsmn/kg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddviedgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 27 Jan 2023 10:01:15 -0500 (EST) From: Thomas Monjalon To: Nithin Kumar Dabilpuram Cc: Aman Singh , Yuying Zhang , Ivan Malov , Andrew Rybchenko , "dev@dpdk.org" , Hanumanth Reddy Pothula , Ferruh Yigit , "viacheslavo@nvidia.com" , Jerin Jacob Kollanukkaran , "david.marchand@redhat.com" Subject: Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation Date: Fri, 27 Jan 2023 16:01:13 +0100 Message-ID: <13375798.lhuNh5TYOU@thomas> In-Reply-To: References: <20221220200250.2413443-1-hpothula@marvell.com> <4531200.rE2NhlSrgm@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/01/2023 11:42, Nithin Kumar Dabilpuram: > From: Thomas Monjalon > > 27/01/2023 06:02, Nithin Kumar Dabilpuram: > > > From: Thomas Monjalon > > > > Ferruh is proposing to have a command "port config ..." > > > > to configure the flags to negotiate. > > > > Are you OK with this approach? > > > > > > Yes, we are fine to have such command to enable and disable the feature > > > with default being it disabled if supported by PMD. > > > Is default being disabled fine if the feature is supported by a PMD ? > > > > I think the default should be enabled for ease of use. > > Since testpmd is used extensively for benchmarking purposes, we thought it should have minimum features > enabled by default. The default testpmd doesn't have any Rx/Tx offloads enabled(except for FAST FREE), default > fwd mode being "iofwd" and the Rx metadata is only referenced when dumping packets. > > > > Do we have similar features disables by default? > > I mean do we know features in testpmd which require a "double enablement" > > like one configuration command + one rte_flow rule? > > Spec itself is that way i.e "RTE_FLOW_RULE + RX_METADATA_NEGOTIATE(once)" > > Isn't it enough if > > #1 We have enough print when rte_flow is being create without negotiation done and ask user to enable rx metadata using > "port config ..." > #2 Provide testpmd app arg to enable Rx metadata(for example " --rx-metadata") like other features to avoid calling another > command before rte flow create. I'm not sure what is best. I will let others discuss this part.