From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id B3D622C62 for ; Tue, 15 Mar 2016 00:14:30 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id l68so122084201wml.0 for ; Mon, 14 Mar 2016 16:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=GfkJXt4AiD75chVX3sVKnKD1UrLXK5mTKrmB3dy9vr4=; b=zrmHY6a71xcBYq5iPIKYeJtUmbre7kWMRmagbTr20Bso3Sy5/3hYE1k/jYg8pNho6O J2hLNayk8vvoVm8xsxz265BWQiPbSdBkHGznRsR88nAVztsvuph0KCxYPirV7KN7KquJ +EAuvbej5y01gWhIthMRczlO5q5TLh1nm9SHg3gZIP6G2Y2Ar4D5WQS3knjTBKCjOKTm o5hl36LUVi9u6xCaCsaFyUqDD4LkpPcUQUzPz2Ngx5mEPsaN7yrH6r2yKoDkQlub/JU3 P/KmU64JlBEt59p6/falyN00JkCUcTn37Hw6fUI6jHL94I5U4UpsbXWCG+raRAiPGigP 2Cxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=GfkJXt4AiD75chVX3sVKnKD1UrLXK5mTKrmB3dy9vr4=; b=C40BQCr/lc43XQqbaTemi8rfICciGPdZt5jU6xSZhFGiHL5taBilUVt5N0Qg74Walx T7rcxu/zZoHmAtifujvr5Me7rZ2l0nkMptiqpbbR/3MkBD5/g+/5Fb/VPHAvMB7Mo9KI 8Ykiq6WnMy6But7vpox2Vjt5BPqDeRmmDvvmX+Pn1rEdiB/XEmijKnNrXGhMqapMyeci lfOjhuhWlUjgK5YckelMP2cXqeCsqz3dbCJEtbRnfg86OmC4lMXSUKRVVBNkNLU/HcS5 ny5f8h4fU8UWXLaC8q6sBuqw/Oy/YQ94bg2qwwfFeCrLp2N4ihVReFdh+n899ipRUtbp wDag== X-Gm-Message-State: AD7BkJLyCukdaa0ogH40SDPmp7YHYF6W/qfRGtkPyjJeT+bNPfOiifP+zX8t9Fn3Ly8fvYcE X-Received: by 10.28.226.212 with SMTP id z203mr20888373wmg.73.1457997270554; Mon, 14 Mar 2016 16:14:30 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id da6sm24323663wjb.24.2016.03.14.16.14.29 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 14 Mar 2016 16:14:29 -0700 (PDT) From: Thomas Monjalon To: "Xie, Huawei" , yuanhan.liu@linux.intel.com Cc: dev@dpdk.org, "ann.zhuangyanying@huawei.com" Date: Tue, 15 Mar 2016 00:13:06 +0100 Message-ID: <13376800.Cqouxc5gkz@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1451918787-85887-1-git-send-email-huawei.xie@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vhost: remove lockless enqueue to the virtio ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2016 23:14:30 -0000 2016-01-05 07:16, Xie, Huawei: > On 1/5/2016 2:42 PM, Xie, Huawei wrote: > > This patch removes the internal lockless enqueue implmentation. > > DPDK doesn't support receiving/transmitting packets from/to the same > > queue. Vhost PMD wraps vhost device as normal DPDK port. DPDK > > applications normally have their own lock implmentation when enqueue > > packets to the same queue of a port. > > > > The atomic cmpset is a costly operation. This patch should help > > performance a bit. > > > > Signed-off-by: Huawei Xie > This patch modifies the API's behavior, which is also a trivial ABI > change. In my opinion, application shouldn't rely on previous behavior. > Anyway, i am checking how to declare the ABI change. I guess this patch is now obsolete?