From: Thomas Monjalon <thomas@monjalon.net>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] app/test: silence clang 12 warning
Date: Wed, 21 Apr 2021 00:40:34 +0200 [thread overview]
Message-ID: <13382538.lWEEDP24Pr@thomas> (raw)
In-Reply-To: <20210420132150.167817-2-ktraynor@redhat.com>
20/04/2021 15:21, Kevin Traynor:
> clang 12 gives a warning about string concatenation in arrays.
> In this case, as it is a long string test the strings are concatenated.
> Add parentheses to indicate this.
>
> $ clang --version
> clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)
>
> [2556/2719]
> Compiling C object app/test/dpdk-test.p/test_cmdline_num.c.o
> ../app/test/test_cmdline_num.c:204:5: warning:
> suspicious concatenation of string literals in an array initialization;
> did you mean to separate the elements with a comma?
> [-Wstring-concatenation]
> "1111000011110000111100001111000011110000111100001111000011110000",
> ^
> ../app/test/test_cmdline_num.c:203:3: note:
> place parentheses around the string literal to silence warning
> "0b1111000011110000111100001111000011110000111100001111000011110000"
> ^
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
Series applied, thanks.
prev parent reply other threads:[~2021-04-20 22:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 13:09 [dpdk-dev] [PATCH 1/2] app/test: fix " Kevin Traynor
2021-04-20 13:09 ` [dpdk-dev] [PATCH 2/2] app/test: silence " Kevin Traynor
2021-04-20 13:21 ` [dpdk-dev] [PATCH v2 1/2] app/test: fix " Kevin Traynor
2021-04-20 13:21 ` [dpdk-dev] [PATCH v2 2/2] app/test: silence " Kevin Traynor
2021-04-20 22:40 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13382538.lWEEDP24Pr@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).