DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: ophirmu@mellanox.com, ferruh.yigit@intel.com,
	arybchenko@solarflare.com, ian.stokes@intel.com
Subject: Re: [dpdk-dev] [PATCH 1/2] eal: remove experimental tag for probe/remove
Date: Mon, 5 Nov 2018 12:19:23 +0000	[thread overview]
Message-ID: <13462be0-7835-144a-143f-1e0d30343503@redhat.com> (raw)
In-Reply-To: <20181101144633.13429-2-thomas@monjalon.net>

On 11/01/2018 02:46 PM, Thomas Monjalon wrote:
> The functions rte_dev_probe() and rte_dev_remove() are new
> in DPDK 18.11 so they got the experimental tag by policy.
> However they are too much basic functions for being skipped
> by strict applications which do not use experimental functions.
> 
> The alternative is to use rte_eal_hotplug_add() and
> rte_eal_hotplug_remove(), but their API requires the application
> to parse the devargs string in order to provide bus name,
> device name and driver arguments.
> 
> The new function rte_dev_probe() is really simpler to use and
> more flexible by accepting any devargs string.
> Let's encourage applications to use it.
> 
> The old functions rte_eal_hotplug_* may be deprecated later.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

one minor comment below, but it's no big deal..

Acked-by: Kevin Traynor <ktraynor@redhat.com>
Tested-by: Kevin Traynor <ktraynor@redhat.com>

> ---
>  lib/librte_eal/common/eal_common_dev.c  |  4 ++--
>  lib/librte_eal/common/include/rte_dev.h | 10 ++--------
>  lib/librte_eal/rte_eal_version.map      |  4 ++--
>  3 files changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c
> index 62e9ed477..5759ec2d8 100644
> --- a/lib/librte_eal/common/eal_common_dev.c
> +++ b/lib/librte_eal/common/eal_common_dev.c
> @@ -186,7 +186,7 @@ local_dev_probe(const char *devargs, struct rte_device **new_dev)
>  	return ret;
>  }
>  
> -int __rte_experimental
> +int
>  rte_dev_probe(const char *devargs)
>  {
>  	struct eal_dev_mp_req req;
> @@ -322,7 +322,7 @@ local_dev_remove(struct rte_device *dev)
>  	return 0;
>  }
>  
> -int __rte_experimental
> +int
>  rte_dev_remove(struct rte_device *dev)
>  {
>  	struct eal_dev_mp_req req;
> diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
> index cd6c187cc..a9724dc91 100644
> --- a/lib/librte_eal/common/include/rte_dev.h
> +++ b/lib/librte_eal/common/include/rte_dev.h
> @@ -196,9 +196,6 @@ int rte_eal_hotplug_add(const char *busname, const char *devname,
>  			const char *drvargs);
>  
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice
> - *
>   * Add matching devices.
>   *
>   * In multi-process, it will request other processes to add the same device.
> @@ -209,7 +206,7 @@ int rte_eal_hotplug_add(const char *busname, const char *devname,
>   * @return
>   *   0 on success, negative on error.
>   */
> -int __rte_experimental rte_dev_probe(const char *devargs);
> +int rte_dev_probe(const char *devargs);
>  
>  /**
>   * Hotplug remove a given device from a specific bus.
> @@ -227,9 +224,6 @@ int __rte_experimental rte_dev_probe(const char *devargs);
>  int rte_eal_hotplug_remove(const char *busname, const char *devname);
>  
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice
> - *
>   * Remove one device.
>   *
>   * In multi-process, it will request other processes to remove the same device.
> @@ -240,7 +234,7 @@ int rte_eal_hotplug_remove(const char *busname, const char *devname);
>   * @return
>   *   0 on success, negative on error.
>   */
> -int __rte_experimental rte_dev_remove(struct rte_device *dev);
> +int rte_dev_remove(struct rte_device *dev);
>  
>  /**
>   * Device comparison function.
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index 04f624246..be4976e3d 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -262,6 +262,8 @@ DPDK_18.11 {
>  	rte_eal_get_runtime_dir;
>  	rte_eal_hotplug_add;
>  	rte_eal_hotplug_remove;
> +	rte_dev_probe;
> +	rte_dev_remove;

maybe you want to keep these in alphabetical order

>  	rte_strscpy;
>  
>  } DPDK_18.08;
> @@ -285,8 +287,6 @@ EXPERIMENTAL {
>  	rte_dev_is_probed;
>  	rte_dev_iterator_init;
>  	rte_dev_iterator_next;
> -	rte_dev_probe;
> -	rte_dev_remove;
>  	rte_devargs_add;
>  	rte_devargs_dump;
>  	rte_devargs_insert;
> 

  reply	other threads:[~2018-11-05 12:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 14:46 [dpdk-dev] [PATCH 0/2] remove experimental tag for hotplug API Thomas Monjalon
2018-11-01 14:46 ` [dpdk-dev] [PATCH 1/2] eal: remove experimental tag for probe/remove Thomas Monjalon
2018-11-05 12:19   ` Kevin Traynor [this message]
2018-11-05 13:13     ` Thomas Monjalon
2018-11-05 23:08       ` Thomas Monjalon
2018-11-01 14:46 ` [dpdk-dev] [PATCH 2/2] ethdev: remove experimental tag for iterator API Thomas Monjalon
2018-11-05 12:22   ` Kevin Traynor
2018-11-05 11:34 ` [dpdk-dev] [PATCH 0/2] remove experimental tag for hotplug API Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13462be0-7835-144a-143f-1e0d30343503@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=ian.stokes@intel.com \
    --cc=ophirmu@mellanox.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).