From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63DD941BAE; Thu, 2 Feb 2023 12:50:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3FB58406A2; Thu, 2 Feb 2023 12:50:43 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 5F2A240689 for ; Thu, 2 Feb 2023 12:50:41 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 001875C0113; Thu, 2 Feb 2023 06:50:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 02 Feb 2023 06:50:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675338640; x= 1675425040; bh=Jz1JmWP+o12pW4ZEvBlZeAyL6Wqz8LbTBOa5DSqBgQY=; b=q h3RXs9weshBixl53Ypi0449YVL0Y4EEZHdpI8l+AQm8iiSnMaQKrceRii6EgvbKy 8kRv1zP1y2qh9hHMnnCAdKKbVsPOyutSHQRjDP4VI6VivROiAYkq4U+RDrT9ihLK 2hXpw8HwQWYhaSmftJ1tSctnZkSGLTYsxu3aCVhgBxxziAosztS3O2OVeYFt0YFe RFor4MIX/K7rHBPpHJNE9jadJXGsrfUq5JrX/6QBDKbUhDkfV9zh4E9R2uSKs7Dd kfQcPxn8JSL1Mmhw/yXp6Oyr0/F7JgkqjD0qQeY+2EhYERU5prxLEdTCr5Gb2JeM 2bpUAYYubhmJoWsO2pf1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675338640; x= 1675425040; bh=Jz1JmWP+o12pW4ZEvBlZeAyL6Wqz8LbTBOa5DSqBgQY=; b=h IuQmAHJXrXjDGXM2+8Zf/xvT+afKLS+SfLFLaHecICAW6ut2+1NtN/QUe7ysU5nf HgmytDbCRfq45paYhZgHr3d/inJzAkydeWZte2Negny06Bhxomh6bU1HcnnKFWg8 bld5Ji7VR0pXVFo4oxN7aC2WC+g5f0n2+RR3cSvGA6DMtFumu3gDZDXK1rFv19WA DYqQBkEG3OvDHy13vBB5C7c6N690h5sj3TsxH5431ERrlgW1bkZ94AniNr699pmG 0d/faNLtKnqGZLQOv0toXbuRsWbZBpI6sZEMjE1GYNtMWXpTjWbdo3QpgOcwUFk5 E5M4/FpxHFCIZ24ohy1Lw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefkedgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Feb 2023 06:50:39 -0500 (EST) From: Thomas Monjalon To: "lihuisong (C)" Cc: dev@dpdk.org, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, liudongdong3@huawei.com, huangdaode@huawei.com, fengchengwen@huawei.com Subject: Re: [PATCH V7] ethdev: fix one address occupies two entries in MAC addrs Date: Thu, 02 Feb 2023 12:50:38 +0100 Message-ID: <13477169.uLZWGnKmhe@thomas> In-Reply-To: <86a52aa2-4d1a-9243-4ca9-5ca49ed69652@huawei.com> References: <20221020093102.20679-1-lihuisong@huawei.com> <3915735.ZaRXLXkqSa@thomas> <86a52aa2-4d1a-9243-4ca9-5ca49ed69652@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/02/2023 02:11, lihuisong (C): > =E5=9C=A8 2023/2/2 0:37, Thomas Monjalon =E5=86=99=E9=81=93: > > 01/02/2023 14:15, Huisong Li: > >> This section is a comment. Do not overwrite or remove it. > >> Also, make sure to start the actual text at the margin. > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > > Please check the comment: "make sure to start the actual text at the ma= rgin." >=20 > It means to start the actual text at the beginning of the line, right? It means no extra space at the beginning of the line. > >> - /** Device Ethernet link address. @see rte_eth_dev_release_port() */ > >> + /** > >> + * Device Ethernet link addresses. > >> + * All entries are unique. The first entry (index zero) is the > >> + * default address. > >> + */ > > You remember I asked to split lines after the dot? > Sorry for my misunderstanding. Need to occupy one line for each sentence= =20 > here? A sentence may be longer than one line, but it is better split lines logically (after dots, commas, etc). > Do we generally use this style to make comments? or are we just trying=20 > to highlight it here? That's a recommendation when writing text (comments and rst doc). Having lines split logically may help reading, and will make simpler patches when updating in future, because in general we change a single sentence.