From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id C59CE1C15B for ; Wed, 4 Apr 2018 13:37:39 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4CC0B210D0; Wed, 4 Apr 2018 07:37:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 04 Apr 2018 07:37:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=EkI+2McJy7qXXBf/bdYrrpgIDF 5zblHkHLtjPqMh+Ws=; b=q6fvrY190RA8bSX7MbD9Y/+43sWpLuEpxDRoXGUMuW XX9aDCBW6guHhc1AUENoJhJ0+5j1XCgd/sZn5DuB5lC9148JCx9aeZfEW0gOyczC tUaC5gN5WUKadqafN2O2L4zoY4/GVdB+Qoips8sPDUGSlt+R5azkuL523aYB3ROB k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=EkI+2M cJy7qXXBf/bdYrrpgIDF5zblHkHLtjPqMh+Ws=; b=gMFnAmQXnJyC38Z1MASAve DsuplquSQo2qhaEC5qapQKogblMkCQgg5RQm7vULYgtFgkSKfA5nQfTRN35dlLgt CgEllayFgCbVFSrMPJMOLQHluFxMgVXcLx9ek8WznmQNSGbueXC3r/1cMfY7Q2nb QOvJuivl9aW987LuVdvDxuRg+Gjlm1xvHq/E3bj803z9EFgOCSJwa/IEDYEvUjuj YLlLNo71bxDsl6KGCK7pIeh56NxYLbqMzRnGu9hX/OS+pU3lTbqqNBuIT2b+E79K IrFxuSmy3Y1wmYeMrwnvi83VNAlKOlnfzTWBy4/GsnT6QCJlk+9OD1VhRPpDvdSg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CF372E444A; Wed, 4 Apr 2018 07:37:38 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org Date: Wed, 04 Apr 2018 13:37:37 +0200 Message-ID: <13489506.7h5fhggtRA@xps> In-Reply-To: <20180223211752.28651-1-stephen@networkplumber.org> References: <20180223205648.18690-1-stephen@networkplumber.org> <20180223211752.28651-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 0/3] logging enhancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 11:37:40 -0000 23/02/2018 22:17, Stephen Hemminger: > The current dynamic logging has some awkward user interface choices. > It uses integers for log levels which requires user to know the > mapping between numeric and symbolic values. > > A bigger problem was the choice of regular expressions and option > format for dynamic logging. Dynamic log names are seperated with > a period and the wildcard character for regular expressions is > a period. It is just a happy accident the expressions like: > "pmd.net.virtio.*" > work as expected. This patch set adds a more usable solution > with filename style matching. > > Also, the choice of comma as seperator for log-level option was > not consistent with other options. For other options, comma is > used to seperate list of equal values as in: > -l 1,2,3 > Since new match required a backwards compatiable option the > colon is now used to seperate name and value. > > So: > --log-level='pmd.net.virtio.*,7' > still works as expected. But the prefered syntax is: > --log-level='pmd.net.virtio.*:info' +1 This syntax looks better. > If this is accepted, I think we should mark the old regex style > matching as deprecated and remove it in 18.11?? Good question. Do we want to deprecate the regex style? > Also, the dynamic log level pattern stuff is not adaquately > documented right now. There are only a couple of vague references > in the current documentation (which this updates). I think you should document the symbolic log levels in the guide and in the --help.