From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA2C5A0547; Wed, 21 Apr 2021 16:50:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8F8341AC8; Wed, 21 Apr 2021 16:50:49 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 4B947410F9; Wed, 21 Apr 2021 16:50:48 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 07A0021DE; Wed, 21 Apr 2021 10:50:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 21 Apr 2021 10:50:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= aQt1cDiiYFMaKVtLS55U66iW5TY3Knk/WXIdDreo/Ik=; b=PH1G/ZQVw5le+oON vHzZlpC4qTSTwvkSHl9oGRAOrdgJZqaFvY462X0DPM1R0WJXrAu8N6GEsad17IWz +sCKL9DL4IQfj/BPR+fcZiLRcCoPr6tq4zNLJTpJ+TvaDf3WYWA5VJiA8Gh0FYSz +gu4oWgYzdULRjUV4+5TjKq+i+JA8FyQG1Acrn0rtSFuEzX8yx7dIOLJk4yQb66G /H6rPwlcd3CGnxCjnFGZBg2UWn/YpAyUO6DpbFc6OXiyCLKXNFE8g8Q1vKAqFZU0 bhFBtHbTgFIOcxtwtrDCTU2xJuPRBNrbn7AXU88lIBY60TyTKHtHSpM1rL4X+A1b 49WMmQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=aQt1cDiiYFMaKVtLS55U66iW5TY3Knk/WXIdDreo/ Ik=; b=TSFCurHKZ0HQE5dQMQC5kCzFyNuQl2FxAFlGAzRxlttsvCQNf1lR93yT5 lheXeXWvDENhoafUrxp2xWkbwskNOi9gxHTAeHiCW7o/32Yb/Qnn20/eNp1A5hXO aSH0zKRQ/X12nI+iJaeDK8PbLT7500bd0blzdZzl89RlcsHKKxxE1se6f0pHDcbQ zN5lhqA59NEmK45sEoACrxt2xdKxt+zSbCeBj3Gk0P/B/MZlju9G2GW1871ZVy6C gLRIGEbHuZeMiFoEP9LkE7yv/no2V2eSBQpf7bIlJsQpb8ShNxoenu83O6Rc3WqU BZF0wn3I0N7ffXFKQ49pDkVn8HNrQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtkedgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 65D74108005F; Wed, 21 Apr 2021 10:50:45 -0400 (EDT) From: Thomas Monjalon To: "583493798@qq.com" <583493798@qq.com> Cc: "dev@dpdk.org" , "Burakov, Anatoly" , "Ananyev, Konstantin" , aconole@redhat.com, stable@dpdk.org Date: Wed, 21 Apr 2021 16:50:44 +0200 Message-ID: <134920770.HdkG1kHLkd@thomas> In-Reply-To: References: <20200501161603.33907-1-583493798@qq.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ip_frag: fix fragmenting ipv4 packet with header option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > From: Pu Xu <583493798@qq.com> > > > > When fragmenting ipv4 packet, the data offset should be calculated through > > the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). > > > > Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper library") + Cc: stable@dpdk.org > > Signed-off-by: Pu Xu <583493798@qq.com> > > Acked-by: Konstantin Ananyev As asked by Aaron, an unit test would be good, but in this case (after discussion) it won't block the fix to be merged. Applied, thanks