From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FCA748B4D; Wed, 19 Nov 2025 12:02:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAB2C4065B; Wed, 19 Nov 2025 12:02:15 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id 8A94640613 for ; Wed, 19 Nov 2025 12:02:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763550133; x=1795086133; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=39M1/n/KN41wLZSIXRYjlxUFoqjpbUCv97/sBD+e/k8=; b=Po8pBz2ILaZ1DFcWePNZ/UeyYjXoBQBbIfIMO34zUyb7auxJ2fnvQPL7 opGUtQc3lcSquZlxiDq/7XbIeTIRwzC/OH+PMK6dednqcWwLEB1+gB8Vw M+wtuqtAtyVn++5RcbeOoJAjInOthRUP/sRwoKm1+62jUF4gFZSZmfjTP rdYzlYU4MtIEwJsIfDEzm3y0eNqY4aJ1brLxcMzI/TwEMw+EYoFgV8mlR Uq/1rbH3DPiqG6dP+KC+szcRjZlOB6E+wb0bks/HndWZEOjDyABHIBxx9 nV3Oh8Myf+RJXVQNaWTGLFnspoYwNSBiq2KVRCgumVWAkKUl037iLNUyF A==; X-CSE-ConnectionGUID: XcCL/lKvTlqF12bsSs8Jhw== X-CSE-MsgGUID: jchKMx16QeSn38Z616u3yA== X-IronPort-AV: E=McAfee;i="6800,10657,11617"; a="76942087" X-IronPort-AV: E=Sophos;i="6.19,315,1754982000"; d="scan'208";a="76942087" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2025 03:02:12 -0800 X-CSE-ConnectionGUID: jOzOtlSNS++6Odlu4jnbFQ== X-CSE-MsgGUID: bLUCfH06SpGlv4K8VsF99Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,315,1754982000"; d="scan'208";a="214409187" Received: from silpixa00401119.ir.intel.com ([10.20.224.206]) by fmviesa002.fm.intel.com with ESMTP; 19 Nov 2025 03:02:11 -0800 From: Anatoly Burakov To: dev@dpdk.org, Dimon Zhao , Kyo Liu , Leon Yu , Sam Chen Subject: [PATCH v4 04/17] net/nbl: do not use VFIO group bind API Date: Wed, 19 Nov 2025 11:01:47 +0000 Message-ID: <1358d50af918b536270b9e536e6fd7394d00d92c.1763549736.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The NBL driver currently uses group bind API, but it is using it only to get group fd and nothing else. In context of NBL driver, this is the only usage of VFIO API's in the driver, and it is not necessary to use it for what NBL driver is trying to accomplish. Use a direct `open()` call instead, and store the group fd in common structure. Signed-off-by: Anatoly Burakov --- drivers/net/nbl/nbl_common/nbl_userdev.c | 18 +++++++++++------- drivers/net/nbl/nbl_include/nbl_include.h | 1 + 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/net/nbl/nbl_common/nbl_userdev.c b/drivers/net/nbl/nbl_common/nbl_userdev.c index 566f3a11ee..d641ecd9a8 100644 --- a/drivers/net/nbl/nbl_common/nbl_userdev.c +++ b/drivers/net/nbl/nbl_common/nbl_userdev.c @@ -387,6 +387,13 @@ nbl_userdev_mem_event_callback(enum rte_mem_event type, const void *addr, size_t } } +static int nbl_open_group_fd(int iommu_group_num) +{ + char path[PATH_MAX]; + snprintf(path, sizeof(path), RTE_VFIO_GROUP_FMT, iommu_group_num); + return open(path, O_RDWR); +} + static int nbl_mdev_map_device(struct nbl_adapter *adapter) { const struct rte_pci_device *pci_dev = adapter->pci_dev; @@ -424,11 +431,12 @@ static int nbl_mdev_map_device(struct nbl_adapter *adapter) } NBL_LOG(DEBUG, "nbl vfio container %d", container); - vfio_group_fd = rte_vfio_container_group_bind(container, common->iommu_group_num); + vfio_group_fd = nbl_open_group_fd(common->iommu_group_num); if (vfio_group_fd < 0) { NBL_LOG(ERR, "nbl vfio group bind failed, %d", vfio_group_fd); goto free_container; } + common->groupfd = vfio_group_fd; /* check if the group is viable */ ret = ioctl(vfio_group_fd, VFIO_GROUP_GET_STATUS, &group_status); @@ -535,7 +543,6 @@ static int nbl_mdev_map_device(struct nbl_adapter *adapter) } free_group: close(vfio_group_fd); - rte_vfio_clear_group(vfio_group_fd); free_container: if (container_create) rte_vfio_container_destroy(container); @@ -549,17 +556,14 @@ static int nbl_mdev_unmap_device(struct nbl_adapter *adapter) close(common->devfd); rte_mcfg_mem_read_lock(); - vfio_group_fd = rte_vfio_container_group_bind(nbl_default_container, - common->iommu_group_num); + vfio_group_fd = common->groupfd; NBL_LOG(DEBUG, "close vfio_group_fd %d", vfio_group_fd); ret = ioctl(vfio_group_fd, VFIO_GROUP_UNSET_CONTAINER, &nbl_default_container); if (ret) NBL_LOG(ERR, "unset container, error %i (%s) %d", errno, strerror(errno), ret); nbl_group_count--; - ret = rte_vfio_container_group_unbind(nbl_default_container, common->iommu_group_num); - if (ret) - NBL_LOG(ERR, "vfio container group unbind failed %d", ret); + close(vfio_group_fd); if (!nbl_group_count) { rte_mem_event_callback_unregister(NBL_USERDEV_EVENT_CLB_NAME, NULL); nbl_userdev_dma_free(); diff --git a/drivers/net/nbl/nbl_include/nbl_include.h b/drivers/net/nbl/nbl_include/nbl_include.h index eeae6a3301..ba99b9f8e7 100644 --- a/drivers/net/nbl/nbl_include/nbl_include.h +++ b/drivers/net/nbl/nbl_include/nbl_include.h @@ -132,6 +132,7 @@ struct nbl_common_info { u16 vsi_id; u16 instance_id; int devfd; + int groupfd; int eventfd; int ifindex; int iommu_group_num; -- 2.47.3