From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Aman Singh <aman.deep.singh@intel.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 2/2] net: macro to extract MAC address bytes
Date: Thu, 12 Aug 2021 16:59:46 +0100 [thread overview]
Message-ID: <1359eb91-c1e9-fb13-5a40-936344cb1b81@intel.com> (raw)
In-Reply-To: <20210810073541.60975-3-aman.deep.singh@intel.com>
On 8/10/2021 8:35 AM, Aman Singh wrote:
> Added macros to simplyfy print of MAC address.
s/simplyfy/simplify
> The other method of first formatting mac address
> into a string and string printed, is avoided.
>
There are some cases that 'rte_ether_format_addr()' API is used to convert MAC
address into string and later that string is printed. If you mean above usage,
that usage is still exist after this patch. As far as I can see this patch is
just to add helper macro to get octets of the MAC address. Can you please clarify?
> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
> ---
> The change in the document will be done in seperate patch.
> To ensure document has direct reference of the code.
+1, you can add the link of mentioned patch here.
And patch title comment in previous patch applies here too, can you please
update it?
Except above issues,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
prev parent reply other threads:[~2021-08-12 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 7:35 [dpdk-dev] [PATCH v3 0/2] Use macro to print MAC address Aman Singh
2021-08-10 7:35 ` [dpdk-dev] [PATCH v3 1/2] net: macro for MAC address print Aman Singh
2021-08-12 15:59 ` Ferruh Yigit
2021-08-10 7:35 ` [dpdk-dev] [PATCH v3 2/2] net: macro to extract MAC address bytes Aman Singh
2021-08-12 15:59 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359eb91-c1e9-fb13-5a40-936344cb1b81@intel.com \
--to=ferruh.yigit@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).