DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] eal/freebsd: ignore in-memory option
@ 2021-09-13 14:34 Bruce Richardson
  2021-10-13 15:11 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Bruce Richardson @ 2021-09-13 14:34 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson, anatoly.burakov

The in-memory option is not supported on FreeBSD so print a warning and
ignore the flag when it is specified for BSD apps. The lack of support
is due to the different way in which memory is managed on FreeBSD using
the contigmem driver rather than via a hugetlbfs filesystem.

Fixes: 14de8734c401 ("eal: add --in-memory option")
Cc: anatoly.burakov@intel.com

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/eal/freebsd/eal.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index 6cee5ae369..fb734012a4 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -718,6 +718,10 @@ rte_eal_init(int argc, char **argv)
 
 	/* FreeBSD always uses legacy memory model */
 	internal_conf->legacy_mem = true;
+	if (internal_conf->in_memory) {
+		RTE_LOG(WARNING, EAL, "Warning: ignoring unsupported flag, '%s'\n", OPT_IN_MEMORY);
+		internal_conf->in_memory = false;
+	}
 
 	if (eal_plugins_init() < 0) {
 		rte_eal_init_alert("Cannot init plugins");
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] eal/freebsd: ignore in-memory option
  2021-09-13 14:34 [dpdk-dev] [PATCH] eal/freebsd: ignore in-memory option Bruce Richardson
@ 2021-10-13 15:11 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2021-10-13 15:11 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev, anatoly.burakov

13/09/2021 16:34, Bruce Richardson:
> The in-memory option is not supported on FreeBSD so print a warning and
> ignore the flag when it is specified for BSD apps. The lack of support
> is due to the different way in which memory is managed on FreeBSD using
> the contigmem driver rather than via a hugetlbfs filesystem.
> 
> Fixes: 14de8734c401 ("eal: add --in-memory option")
> Cc: anatoly.burakov@intel.com
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied with Cc:stable, thanks.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-13 15:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 14:34 [dpdk-dev] [PATCH] eal/freebsd: ignore in-memory option Bruce Richardson
2021-10-13 15:11 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).