DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] test/eventdev: fix compilation with crypto disabled
@ 2017-04-06 14:13 Olivier Matz
  2017-04-06 15:09 ` Jerin Jacob
  0 siblings, 1 reply; 3+ messages in thread
From: Olivier Matz @ 2017-04-06 14:13 UTC (permalink / raw)
  To: dev; +Cc: jerin.jacob

There is a compilation error in the following case:

  make config T=x86_64-native-linuxapp-gcc
  sed -i 's,CONFIG_RTE_LIBRTE_CRYPTODEV=y,CONFIG_RTE_LIBRTE_CRYPTODEV=n,' \
    build/.config
  sed -i 's,CONFIG_RTE_APP_CRYPTO_PERF=y,CONFIG_RTE_APP_CRYPTO_PERF=n,' \
    build/.config
  make -j4
  make -j4 test-build

  test_eventdev.c:39:27: fatal error:
  rte_cryptodev.h: No such file or directory
  #include <rte_cryptodev.h>
                           ^

Removing the include induces a new error, (missing declaration of
rte_eal_vdev_init()), which is fixed by including rte_dev.h.

Fixes: f8f9d233ea0e ("test/eventdev: add unit tests")

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 test/test/test_eventdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c
index b568470a2..5bd46346d 100644
--- a/test/test/test_eventdev.c
+++ b/test/test/test_eventdev.c
@@ -36,7 +36,7 @@
 #include <rte_malloc.h>
 #include <rte_memcpy.h>
 #include <rte_eventdev.h>
-#include <rte_cryptodev.h>
+#include <rte_dev.h>
 
 #include "test.h"
 
-- 
2.11.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] test/eventdev: fix compilation with crypto disabled
  2017-04-06 14:13 [dpdk-dev] [PATCH] test/eventdev: fix compilation with crypto disabled Olivier Matz
@ 2017-04-06 15:09 ` Jerin Jacob
  2017-04-06 15:35   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Jerin Jacob @ 2017-04-06 15:09 UTC (permalink / raw)
  To: Olivier Matz; +Cc: dev

-----Original Message-----
> Date: Thu, 6 Apr 2017 16:13:37 +0200
> From: Olivier Matz <olivier.matz@6wind.com>
> To: dev@dpdk.org
> CC: jerin.jacob@caviumnetworks.com
> Subject: [PATCH] test/eventdev: fix compilation with crypto disabled
> X-Mailer: git-send-email 2.11.0
> 
> There is a compilation error in the following case:
> 
>   make config T=x86_64-native-linuxapp-gcc
>   sed -i 's,CONFIG_RTE_LIBRTE_CRYPTODEV=y,CONFIG_RTE_LIBRTE_CRYPTODEV=n,' \
>     build/.config
>   sed -i 's,CONFIG_RTE_APP_CRYPTO_PERF=y,CONFIG_RTE_APP_CRYPTO_PERF=n,' \
>     build/.config
>   make -j4
>   make -j4 test-build
> 
>   test_eventdev.c:39:27: fatal error:
>   rte_cryptodev.h: No such file or directory
>   #include <rte_cryptodev.h>
>                            ^
> 
> Removing the include induces a new error, (missing declaration of
> rte_eal_vdev_init()), which is fixed by including rte_dev.h.
> 
> Fixes: f8f9d233ea0e ("test/eventdev: add unit tests")
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  test/test/test_eventdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c
> index b568470a2..5bd46346d 100644
> --- a/test/test/test_eventdev.c
> +++ b/test/test/test_eventdev.c
> @@ -36,7 +36,7 @@
>  #include <rte_malloc.h>
>  #include <rte_memcpy.h>
>  #include <rte_eventdev.h>
> -#include <rte_cryptodev.h>
> +#include <rte_dev.h>
>  
>  #include "test.h"
>  
> -- 
> 2.11.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] test/eventdev: fix compilation with crypto disabled
  2017-04-06 15:09 ` Jerin Jacob
@ 2017-04-06 15:35   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-04-06 15:35 UTC (permalink / raw)
  To: Olivier Matz; +Cc: dev, Jerin Jacob

> > There is a compilation error in the following case:
> > 
> >   make config T=x86_64-native-linuxapp-gcc
> >   sed -i 's,CONFIG_RTE_LIBRTE_CRYPTODEV=y,CONFIG_RTE_LIBRTE_CRYPTODEV=n,' \
> >     build/.config
> >   sed -i 's,CONFIG_RTE_APP_CRYPTO_PERF=y,CONFIG_RTE_APP_CRYPTO_PERF=n,' \
> >     build/.config
> >   make -j4
> >   make -j4 test-build
> > 
> >   test_eventdev.c:39:27: fatal error:
> >   rte_cryptodev.h: No such file or directory
> >   #include <rte_cryptodev.h>
> >                            ^
> > 
> > Removing the include induces a new error, (missing declaration of
> > rte_eal_vdev_init()), which is fixed by including rte_dev.h.
> > 
> > Fixes: f8f9d233ea0e ("test/eventdev: add unit tests")
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-04-06 15:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-06 14:13 [dpdk-dev] [PATCH] test/eventdev: fix compilation with crypto disabled Olivier Matz
2017-04-06 15:09 ` Jerin Jacob
2017-04-06 15:35   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).