Re: [PATCH v2] service: extend service function call statistics

["Mattias Rönnblom" <hofors@lysator.liu.se>]

On 2024-09-10 03:19, fengchengwen wrote:
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
> 

Thanks.

Harry, could we have a maintainer opinion on this patch?

> On 2024/9/10 3:11, Mattias Rönnblom wrote:
>> Add two new per-service counters.
>>
>> RTE_SERVICE_ATTR_IDLE_CALL_COUNT tracks the number of service function
>> invocations where no work was performed.
>>
>> RTE_SERVICE_ATTR_ERROR_CALL_COUNT tracks the number invocations
>> resulting in an error.
>>
>> The semantics of RTE_SERVICE_ATTR_CALL_COUNT remains the same (i.e.,
>> counting all invocations, regardless of return value).
>>
>> The new statistics may be useful for both debugging and profiling
>> (e.g., calculate the average per-call processing latency for non-idle
>> service calls).
>>
>> Service core tests are extended to cover the new counters, and
>> coverage for RTE_SERVICE_ATTR_CALL_COUNT is improved.
>>
>> The documentation for the CYCLES attributes are updated to reflect
>> their actual semantics.
>>
>> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
>>