From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18D3145952; Tue, 10 Sep 2024 09:19:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBC8F4021F; Tue, 10 Sep 2024 09:19:13 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id BDFD840151 for ; Tue, 10 Sep 2024 09:19:12 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id A460A1A86D for ; Tue, 10 Sep 2024 09:19:11 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 988C21A8FE; Tue, 10 Sep 2024 09:19:11 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.2 Received: from [192.168.1.86] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 0F49D1A95B; Tue, 10 Sep 2024 09:19:08 +0200 (CEST) Message-ID: <137aa1c3-0b7d-48ae-a895-775ae43d5a6e@lysator.liu.se> Date: Tue, 10 Sep 2024 09:19:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] service: extend service function call statistics To: fengchengwen , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , dev@dpdk.org Cc: harry.van.haaren@intel.com, Stefan Sundkvist References: <20240809202539.590510-1-mattias.ronnblom@ericsson.com> <20240909191103.697554-1-mattias.ronnblom@ericsson.com> <4a108663-9785-e13c-0d46-f8037f25963f@huawei.com> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: <4a108663-9785-e13c-0d46-f8037f25963f@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-09-10 03:19, fengchengwen wrote: > Acked-by: Chengwen Feng > Thanks. Harry, could we have a maintainer opinion on this patch? > On 2024/9/10 3:11, Mattias Rönnblom wrote: >> Add two new per-service counters. >> >> RTE_SERVICE_ATTR_IDLE_CALL_COUNT tracks the number of service function >> invocations where no work was performed. >> >> RTE_SERVICE_ATTR_ERROR_CALL_COUNT tracks the number invocations >> resulting in an error. >> >> The semantics of RTE_SERVICE_ATTR_CALL_COUNT remains the same (i.e., >> counting all invocations, regardless of return value). >> >> The new statistics may be useful for both debugging and profiling >> (e.g., calculate the average per-call processing latency for non-idle >> service calls). >> >> Service core tests are extended to cover the new counters, and >> coverage for RTE_SERVICE_ATTR_CALL_COUNT is improved. >> >> The documentation for the CYCLES attributes are updated to reflect >> their actual semantics. >> >> Signed-off-by: Mattias Rönnblom >>