DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Clarification for - SoC specific driver based common sub component placing
Date: Fri, 18 Nov 2016 14:43:20 +0100	[thread overview]
Message-ID: <13846356.5jcoesaunv@xps13> (raw)
In-Reply-To: <7765421.y4BZ5iUgMg@xps13>

2016-11-18 14:38, Thomas Monjalon:
> 2016-11-18 12:44, Hemant Agrawal:
> > We like to introduce NXP's DPAA (Data Path Acceleration Architecture Gen2) Poll mode drivers into the DPDK.
> > 
> > We need some clarification w.r.t the right placing of some dependent components, which can be common across drivers. E.g. We have hardware queue and buffer manager driver. This will be used by both network driver and crypto driver. But it is specific to NXP platform only.
> > 
> > What is the right place for such common hardware specific components in DPDK? 
> > 	1. Add a new generic Soc library structure. e.g. librte_soc/nxp/. For each soc configuration only the required components will be compiled-in. 
> > 	2. Create a drivers/soc/nxp/dpaa2 structure to keep common driver libs. And link the network and crypto drivers to it.
> > 	3. Add it to main network driver and make the crypto driver dependent on it.
> 
> Your question is more generic than SoC context.
> You just want to share some code between drivers, right?
> What about building a library located in drivers/common/nxp/ ?

I'm a bit reluctant to have company name in file hierarchy,
as it not something stable. And especially for NXP/Qualcomm...

In this case would it be better to name the directory
drivers/common/dpaa2/ ?

  reply	other threads:[~2016-11-18 13:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18 12:44 Hemant Agrawal
2016-11-18 13:38 ` Thomas Monjalon
2016-11-18 13:43   ` Thomas Monjalon [this message]
2016-11-18 14:31     ` Hemant Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13846356.5jcoesaunv@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).