From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 505202C10 for ; Fri, 18 Nov 2016 14:43:23 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id a197so39212846wmd.0 for ; Fri, 18 Nov 2016 05:43:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=v+9lyPXXp40K9ajCFZQC2fU3zP+E7WoTW1IIEUve/bU=; b=zGeGw4Y//XJ40RjTH0zNgGxWtTi6lkIVkzdaYxtXO8giNMqJjIf8J4r3g/SNrKqVPP wMqObfT2vSxVmhTjR03D4Op4ezigPhSrBGq1FPbCOpyLrPDaJyUbzG67rczHnmVlAOwo aIGgaBzAP6tcG94exSDJ6E8o7FvOXvkf5CG4yY95BJ/BAiIfMZ6B64kmIGbDmxPpvWk4 CezyydhKIB6TPetlyQGdyrW3bQJ4/AQr+H3ay22UYdT3kFzVqxKp3yhudddm+7xA5U+D PXthSoI/ApW0GOqdo4JJ5V1X7VgZSFV1pHYBH7KPjeJ4K7TstR80UaZ7QlYQU9UWHT2w /68w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=v+9lyPXXp40K9ajCFZQC2fU3zP+E7WoTW1IIEUve/bU=; b=a/2yqYRFGZlpkChZFVZElVIiemeAeXPdplqoAtiWWwBk6O9iLKQEIWcQqFz65AQoW1 wEBjeJEHgb0KnidTr7GT2bR81N6e8ETlspGJaG6QRfSjjm6h7wt+4GoUdt0RT3jMRfPx KdtSpxiJfi4KfmGusPRrQ5WTmAa8X2bPTPReYh5GUjnACmhbIjzSbKetUao6AXKMU2SP NtISp1A19h4aan6tCHBQuwLkfoMtWYRoNvwACyF0yeMAh/k8o08hrIZtBr9zQa72K8ia L+NKeBewfvYWrkFsm9k2QBDCjaYA4vmFiuj6kZHfsql2Zzt8ukQRnDI8hlYA9239y5mH KIGg== X-Gm-Message-State: ABUngve5ZVZUrFhWfrw8FCCK+ff3YRVssxDOaq0+OrnSYrAwRMZ0n2YnPvH3sMrxWvsyklnk X-Received: by 10.28.184.23 with SMTP id i23mr24877999wmf.66.1479476601773; Fri, 18 Nov 2016 05:43:21 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id g73sm3463834wme.16.2016.11.18.05.43.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Nov 2016 05:43:21 -0800 (PST) From: Thomas Monjalon To: Hemant Agrawal Cc: dev@dpdk.org Date: Fri, 18 Nov 2016 14:43:20 +0100 Message-ID: <13846356.5jcoesaunv@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <7765421.y4BZ5iUgMg@xps13> References: <7765421.y4BZ5iUgMg@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] Clarification for - SoC specific driver based common sub component placing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 13:43:23 -0000 2016-11-18 14:38, Thomas Monjalon: > 2016-11-18 12:44, Hemant Agrawal: > > We like to introduce NXP's DPAA (Data Path Acceleration Architecture Gen2) Poll mode drivers into the DPDK. > > > > We need some clarification w.r.t the right placing of some dependent components, which can be common across drivers. E.g. We have hardware queue and buffer manager driver. This will be used by both network driver and crypto driver. But it is specific to NXP platform only. > > > > What is the right place for such common hardware specific components in DPDK? > > 1. Add a new generic Soc library structure. e.g. librte_soc/nxp/. For each soc configuration only the required components will be compiled-in. > > 2. Create a drivers/soc/nxp/dpaa2 structure to keep common driver libs. And link the network and crypto drivers to it. > > 3. Add it to main network driver and make the crypto driver dependent on it. > > Your question is more generic than SoC context. > You just want to share some code between drivers, right? > What about building a library located in drivers/common/nxp/ ? I'm a bit reluctant to have company name in file hierarchy, as it not something stable. And especially for NXP/Qualcomm... In this case would it be better to name the directory drivers/common/dpaa2/ ?