From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7687A04A5; Wed, 17 Jun 2020 11:40:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC2541E2B; Wed, 17 Jun 2020 11:40:25 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 98723FFA for ; Wed, 17 Jun 2020 11:40:23 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id E048B5C0113; Wed, 17 Jun 2020 05:40:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 17 Jun 2020 05:40:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= AQv/6alZ4TaOGuczTOBMCSrskGP4uHzR8YyCFpoKVAQ=; b=uodF32QlktUkX8GX 0oGw0IqfY8bd8ygFwzqlzUeXhjOTfOSSg11rxaSIbwdqslok6llOCb9wtA7NID8a 80djSx8dg8Hkw7+SHqMckMbuXrby2mSNczNVOKssmjOVzAuzmLMFI/UiGYskFtA1 yq7PUourudESWrPV5upkYgyik7uQYE4pvYBr+6SBvd30ktR7j96+IWirEJ/WtTIT j5rjNn4oX7PnKNovzZKrxdguVz+YeQeEi6slJdAc04qjULo6zZAklYt0kOzEoGfU LtIr1yi5qUaEBGJFOXWesPiOVAW9sbJuH4sLLtQ/kJ0IBY5kuCM2SylePdEqh7y0 8u/laA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=AQv/6alZ4TaOGuczTOBMCSrskGP4uHzR8YyCFpoKV AQ=; b=rXnZXwAy8S3laolEnR0TMLb2J3zOKAq9R9iPch7rLCZaUDFPTBEhZ3BH/ LxW3qteCKkmD4jc1/BQR7AstQ7qv4PSXuX4u0Y0/RS6M+LLAiZ3NR/9cr3kiZVcG ADChbCCulzZzIR/T79dtDFad9obYYmN1ZdkwB6quPsYKRRYJOg1IS0p5yhTAOV4J fJzilsqLKsYHEy+uQ3sruLy0P0XpLO8NJMRs12iItrCfTxlkhaffxydQ/t8wtJkB yPnqLKZXASdg6F2dM1T1L90Wrb6ubyW0euPbc3xUP2b14aZxUysjDWXbH7Fz57pv wwCWHnbxcFVaNd5BXqDw/+arsyLlw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejvddgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6FE5F3060FE7; Wed, 17 Jun 2020 05:40:19 -0400 (EDT) From: Thomas Monjalon To: Ciara Power Cc: john.mcnamara@intel.com, marko.kovacevic@intel.com, ferruh.yigit@intel.com, dev@dpdk.org Date: Wed, 17 Jun 2020 11:40:16 +0200 Message-ID: <13848042.yhPDGZm4c5@thomas> In-Reply-To: <20200602135319.21457-2-ciara.power@intel.com> References: <20200128150256.14339-1-ciara.power@intel.com> <20200602135319.21457-1-ciara.power@intel.com> <20200602135319.21457-2-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 1/3] devtools: standardize script arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/06/2020 15:53, Ciara Power: > This patch modifies the arguments expected by the check-git-log script, > to match the format of arguments for the checkpatches script. Both > scripts now take certain argument options in the same format, making > them easier to use. > e.g. Both now take a commit ID range by "-r " >=20 > The checkpatches help print is also updated to include the "-h" option. >=20 > Signed-off-by: Ciara Power > Acked-by: Ferruh Yigit >=20 > --- > v3: > - Reworded check-git-log help text example. > - Added comment to indicate new and old format argument parsing. > v2: Added exit 0 after print usage. > --- > --- a/devtools/check-git-log.sh > +++ b/devtools/check-git-log.sh > + The git commits to be checked can be specified as a "git log" option, > + by latest git commits limited with -n option, or commits in the git > + range specified with -r option. > + e.g. To check only the last commit, =E2=80=98-n1=E2=80=99 or =E2=80=98-= r@~..=E2=80=99 is used. > + When no parameter is provided, script will use range starting from > + origin/master to HEAD. I suggest this shorter sentence: If no range provided, default is origin/master..HEAD. > +# The script caters for two formats, the new preferred format, and the o= ld > +# format to ensure backward compatibility. > +# The new format is aligned with the format of the checkpatches script, > +# and allows for specifying the patches to check by passing -nX or -r ra= nge. > +# e.g. To check only the last commit, =E2=80=98-n1=E2=80=99 or =E2=80=98= =2Dr@~..=E2=80=99 is used. This example line is useless here. > +# The old format allows for specifying patches by passing -X or range > +# as the first argument. > +# e.g. To check only the last commit, '-1' or '@~..' is used as first a= rgument. This example line is useless here.