From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Jin Yu <jin.yu@intel.com>,
dev@dpdk.org, Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost_blk: fix the TOCTOU
Date: Thu, 13 Feb 2020 17:28:31 +0100 [thread overview]
Message-ID: <1385636c-30ef-5f1e-c4b2-d663afb2dcd6@redhat.com> (raw)
In-Reply-To: <20200211093336.32792-1-jin.yu@intel.com>
On 2/11/20 10:33 AM, Jin Yu wrote:
> Fix the time of check time of use warning in example code.
> Ignore the errno of unlink failure. There are two situations.
> The first one is that file doesn't exist the unlink fails and
> it's ok to ignore. The second one is that unlink fails to remove
> file but the next bind() would fail too.
>
> Coverity issue: 350589 158663
> Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> V2 - complement the commit message.
> ---
> examples/vhost_blk/vhost_blk.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
Applied to dpdk-next-virtio/master
Thanks,
Maxime
prev parent reply other threads:[~2020-02-13 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 15:32 [dpdk-dev] [PATCH] " Jin Yu
2019-11-26 10:25 ` Bruce Richardson
2019-11-27 2:36 ` Yu, Jin
2019-11-27 9:35 ` Bruce Richardson
2020-01-14 9:32 ` Maxime Coquelin
2020-02-11 9:33 ` [dpdk-dev] [PATCH v2] " Jin Yu
2020-02-12 12:54 ` Jin Yu
2020-02-13 16:28 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385636c-30ef-5f1e-c4b2-d663afb2dcd6@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jin.yu@intel.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).