From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [PATCH v2] net/enic: decrement Tx mbuf reference count before recycling
Date: Fri, 15 Jul 2016 23:27:10 +0200 [thread overview]
Message-ID: <13861332.RpjNex3OnZ@xps13> (raw)
In-Reply-To: <1468266301-2762-1-git-send-email-johndale@cisco.com>
2016-07-11 12:45, John Daley:
> In the burst Tx cleanup function, the reference count in mbufs
> returned to the pool should to be decremented before they are
> returned. Decrementing is not done by rte_mempool_put_bulk()
> so it must be done separately using __rte_pktmbuf_prefree_seg().
>
> Also when returning unsent buffers when the device is stopped
> use rte_mbuf_free_seg() instead of rte_mempool_put() so that
> reference counts are properly decremented.
>
> Fixes: 36935afbc53c ("net/enic: refactor Tx mbuf recycling")
>
> Reviewed-by: Nelson Escobar <neescoba@cisco.com>
> Signed-off-by: John Daley <johndale@cisco.com>
Applied, thanks
prev parent reply other threads:[~2016-07-15 21:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 22:22 [dpdk-dev] [PATCH] " John Daley
2016-07-08 22:22 ` [dpdk-dev] [PATCH] net/enic: increment filter failure counter John Daley
2016-07-15 21:26 ` Thomas Monjalon
2016-07-11 10:04 ` [dpdk-dev] [PATCH] net/enic: decrement Tx mbuf reference count before recycling Olivier Matz
2016-07-11 19:41 ` John Daley (johndale)
2016-07-11 19:45 ` [dpdk-dev] [PATCH v2] " John Daley
2016-07-15 21:27 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13861332.RpjNex3OnZ@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).