From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 369135587 for ; Fri, 15 Jul 2016 23:27:12 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id o80so45621906wme.1 for ; Fri, 15 Jul 2016 14:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=hVVxihpov7ScCWBRSiU1gr6NXqRQ5mTElTxcJIe/uuw=; b=iHbu5csb16bvj6rELu/7qe+5ubqs2rstHDL+Bat/lhFDsYLaQnQlwXmZyrAwaQRZCw 1REgNcrXzepNCCZlr3SUDIJMl72nIW+AT/OBxBvoezOo2Sdt8DezU57SfgnH4rpeEDZl ErYjOC5m/CLKwmHjG7J+9ClGiLrVydHLsBT+bEg3a7MoS2fVVBdQha6Qp3ZH39qx0Od9 xdWbRPGgXzTGtjSa7d5/kKe6732BbsfhS1gdN+N30KqzPDxTfjaO83aMYPTXP6ryKsaq o5NUfULpHPVNMT0D5E2h7/XowsCmxTTFaShTpGqcbObtTEaHgVfWxBFez0Z30rIVN+ji xTCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=hVVxihpov7ScCWBRSiU1gr6NXqRQ5mTElTxcJIe/uuw=; b=MmO4GnRCtE1j1zbfP3xDyav1CAM4L6yVUFpSnV5AOzvEF/DRzpxesc2vQybTTB0/Xw UwuQKzF/xGvEE49C7Y/eivOtCd6zlkW3dHE3vYde0f+DL0+1++MWLtY+J5O8dloPspCc 8Rq7k4iy8fqFV+FfRIAcyXkZMue0zBi/F+ZHdQfn6N6fau9MUKRHjNXFPn4K0dcebhi4 4xD04/LO0ZffKvjZOLP8T/kbtLlK3bZANGg3ueoM7eAnCChTQZhUhPhjQ4CBQ58SGzZY nZwgz2qeDWcCGmBrMVV4lBZ70efzmBDHR+HchO26Fc5mMLGK+ycw37hQPFKDwPVCjfS0 SvVw== X-Gm-Message-State: ALyK8tLfGrOMkwYHOg5TcSBEuLjqchcbeDtG5qbP8RRB4XZGNho8AB81W8qmRNSJM6fikRkx X-Received: by 10.194.252.196 with SMTP id zu4mr2454805wjc.131.1468618032056; Fri, 15 Jul 2016 14:27:12 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id u9sm2576946wjy.45.2016.07.15.14.27.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jul 2016 14:27:11 -0700 (PDT) From: Thomas Monjalon To: John Daley Cc: dev@dpdk.org, bruce.richardson@intel.com, olivier.matz@6wind.com Date: Fri, 15 Jul 2016 23:27:10 +0200 Message-ID: <13861332.RpjNex3OnZ@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1468266301-2762-1-git-send-email-johndale@cisco.com> References: <1ca338a4-a8fe-8149-2373-d02fee3199cb@6wind.com> <1468266301-2762-1-git-send-email-johndale@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] net/enic: decrement Tx mbuf reference count before recycling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 21:27:12 -0000 2016-07-11 12:45, John Daley: > In the burst Tx cleanup function, the reference count in mbufs > returned to the pool should to be decremented before they are > returned. Decrementing is not done by rte_mempool_put_bulk() > so it must be done separately using __rte_pktmbuf_prefree_seg(). > > Also when returning unsent buffers when the device is stopped > use rte_mbuf_free_seg() instead of rte_mempool_put() so that > reference counts are properly decremented. > > Fixes: 36935afbc53c ("net/enic: refactor Tx mbuf recycling") > > Reviewed-by: Nelson Escobar > Signed-off-by: John Daley Applied, thanks