From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dan@nyansa.com>
Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com
[209.85.160.54]) by dpdk.org (Postfix) with ESMTP id 8BCEB6893
for <dev@dpdk.org>; Mon, 13 Jan 2014 20:16:13 +0100 (CET)
Received: by mail-pb0-f54.google.com with SMTP id un15so7757547pbc.27
for <dev@dpdk.org>; Mon, 13 Jan 2014 11:17:26 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references;
bh=tcs7WXisZ6KTvNRQZKQ/TUyTEhNlf6KgwRDXApHLqBE=;
b=L7LngonD6MgGA7+1IaAIiIHuQpLbD19bFk1sgfkN1WIFg+sZ/v4JZP49k+vkUK2Tmj
umoCdeGWCu55FTQ6DoTfiFlX/S/vU3q9EDf97AHy7wIXaqrI3iIFiS7MBFn6yG2VpvCO
X7iqZpnEr2bK+CNUd503aPx+FlSGc57inLOvPhJOtt+YitxPcRh9sDRuUSTTe8JK2bQE
DEq/+ECxDwir8FMBs37emK2I34a4bA9HcZBqr/Eq8D1lLn1DO7hc14TkjiTrWL0bgATT
SMRpyH647i/6d5GINV8N9VkJ7yYzBvBkYNpwkWANn+aN0JcdJjy8gY1ubOfJ/mg/W8cv
pQxw==
X-Gm-Message-State: ALoCoQnYfWq9bDJoRJYSmoThZ8npK6rkUUqQ4M3upx1Ttc7YwcbMgBitq3DkWbihkmQuuRwUgAyY
X-Received: by 10.68.4.194 with SMTP id m2mr31681668pbm.19.1389640646516;
Mon, 13 Jan 2014 11:17:26 -0800 (PST)
Received: from localhost.localdomain
(50-76-35-254-ip-static.hfc.comcastbusiness.net. [50.76.35.254])
by mx.google.com with ESMTPSA id xs1sm51171027pac.7.2014.01.13.11.17.22
for <multiple recipients>
(version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
Mon, 13 Jan 2014 11:17:24 -0800 (PST)
From: Daniel Kan <dan@nyansa.com>
To: dev@dpdk.org
Date: Mon, 13 Jan 2014 11:17:10 -0800
Message-Id: <1389640630-21003-1-git-send-email-dan@nyansa.com>
X-Mailer: git-send-email 1.7.9.5
In-Reply-To: <201401131131.06203.thomas.monjalon@6wind.com>
References: <201401131131.06203.thomas.monjalon@6wind.com>
Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix RSS by setting mq_mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jan 2014 19:16:14 -0000
The mq_mode was not set when rxq is > 1; it's defaulted to ETH_MQ_RX_NONE.
As a result, RSS remains inactive. The fix is to set mq_mode to ETH_MQ_RX_RSS
when rxq is > 1 and hf is non-zero.
This bug was introduced by commit 243db2ddee3094a2cb39fdd4b17e26df4e7735e1
igb/ixgbe: ETH_MQ_RX_NONE should disable RSS
Signed-off-by: Daniel Kan <dan@nyansa.com>
---
Updated commit log in accordance with dpdk guidelines
app/test-pmd/testpmd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index b11eb2e..355db0f 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1546,6 +1546,9 @@ init_port_config(void)
if (nb_rxq > 0) {
port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
port->dev_conf.rx_adv_conf.rss_conf.rss_hf = rss_hf;
+ if (nb_rxq > 1 && rss_hf != 0) {
+ port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_RSS;
+ }
} else {
port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
port->dev_conf.rx_adv_conf.rss_conf.rss_hf = 0;
--
1.7.9.5