From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dan@nyansa.com>
Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com
[209.85.192.178]) by dpdk.org (Postfix) with ESMTP id BDB52DE0
for <dev@dpdk.org>; Thu, 16 Jan 2014 01:26:29 +0100 (CET)
Received: by mail-pd0-f178.google.com with SMTP id y13so1837070pdi.9
for <dev@dpdk.org>; Wed, 15 Jan 2014 16:27:43 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references;
bh=ItBeAs/8pPR22Z2Isgf9+Wi1RW+sig1dbQvQLpTFCFs=;
b=b0lTou9IwYT/yNfQKQl8e2ATlwNVoRgoh4IPoMM6I263uk7lVYB4DRcBxeJCY9tSL2
wchv515+OMpY3oDxNyEQb1pE3/G233O8rPV5nOE5KKBfIp8FOt+ymQ1YYdobZnFU4zrm
82VQJA7WD5mzHoLUJKMOBAhQ7YrBCEc2tiMACAMNHlyeDYP+HbW1cnyPO66r8QOL4ywt
uxrGkaksbmHgwLc/H7pCSLDodqIcLRPL7K5G+JP9C4QILftZ4rfROUC5hvyziScj2gkR
0tj8DrmCCh6z5qz79eIPVQ6reRBEDkVU/0EpNZfhdt2U2l9uwWNfk5ujR/GAXHRytIX7
j1UQ==
X-Gm-Message-State: ALoCoQlO2hbmlwf4p4SdXzJdPcbuRyaZJRaZzbXPBgu7og7C7lKyf2kXprG0nm56actc4rLaWJs9
X-Received: by 10.68.14.38 with SMTP id m6mr6245662pbc.60.1389832063409;
Wed, 15 Jan 2014 16:27:43 -0800 (PST)
Received: from localhost.localdomain
(50-76-35-254-ip-static.hfc.comcastbusiness.net. [50.76.35.254])
by mx.google.com with ESMTPSA id sy10sm14005727pac.15.2014.01.15.16.27.41
for <multiple recipients>
(version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
Wed, 15 Jan 2014 16:27:42 -0800 (PST)
From: Daniel Kan <dan@nyansa.com>
To: dev@dpdk.org
Date: Wed, 15 Jan 2014 16:27:28 -0800
Message-Id: <1389832048-29991-1-git-send-email-dan@nyansa.com>
X-Mailer: git-send-email 1.7.9.5
In-Reply-To: <CAEykdvr+9JD0MKwwGqf-4+jSnVaPFGPnMYnr_VFfgCn2+hPcEg@mail.gmail.com>
References: <CAEykdvr+9JD0MKwwGqf-4+jSnVaPFGPnMYnr_VFfgCn2+hPcEg@mail.gmail.com>
Subject: [dpdk-dev] [PATCH v3]
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jan 2014 00:26:30 -0000
The mq_mode was not set when rxq is > 0; it's defaulted to ETH_MQ_RX_NONE.
As a result, RSS remains inactive. The fix is to set mq_mode to ETH_MQ_RX_RSS
when hf is non-zero.
This bug was introduced by commit 243db2ddee3094a2cb39fdd4b17e26df4e7735e1
igb/ixgbe: ETH_MQ_RX_NONE should disable RSS
Signed-off-by: Daniel Kan <dan@nyansa.com>
---
Enable RSS even if rxq=1 based on comment from Maxime Leroy.
app/test-pmd/testpmd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index b11eb2e..42e1fdb 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1546,6 +1546,9 @@ init_port_config(void)
if (nb_rxq > 0) {
port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
port->dev_conf.rx_adv_conf.rss_conf.rss_hf = rss_hf;
+ if (rss_hf != 0) {
+ port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_RSS;
+ }
} else {
port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
port->dev_conf.rx_adv_conf.rss_conf.rss_hf = 0;
--
1.7.9.5