From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Anoob.Joseph@cavium.com> Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0086.outbound.protection.outlook.com [104.47.41.86]) by dpdk.org (Postfix) with ESMTP id 05D501BE59 for <dev@dpdk.org>; Tue, 3 Jul 2018 15:15:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U3pX1G12CkaT2jhlIOG1eMkl2QazkHSM9L1iNy/lw6k=; b=FJHKsdDlwQimRP1JUtqmQL3ZI8vMnWTzgBxzefBIE0AKpzA1wwO6CbKazBSZKEDNufGc5FgqSonzWbegrEGJmGR9aUmrcb7hea4Va9EieqcmIVP75OFNDkFI5WwLYfgTf3R9cL5QBGPSpIyJ+YnWs6I2t83Aw/Qr+PQKcDkeiA0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from [10.88.100.222] (115.113.156.2) by BN7PR07MB4897.namprd07.prod.outlook.com (2603:10b6:406:ef::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.26; Tue, 3 Jul 2018 13:15:29 +0000 From: "Joseph, Anoob" <Anoob.Joseph@caviumnetworks.com> To: Bruce Richardson <bruce.richardson@intel.com> Cc: Pablo de Lara <pablo.de.lara.guarch@intel.com>, "Jacob, Jerin" <Jerin.JacobKollanukkaran@cavium.com>, "Athreya, Narayana Prasad" <NarayanaPrasad.Athreya@cavium.com>, "dev@dpdk.org" <dev@dpdk.org>, Hemant Agrawal <hemant.agrawal@nxp.com>, Nikhil Rao <nikhil.rao@intel.com>, Sunil Kumar Kori <sunil.kori@nxp.com>, gage.eads@intel.com, harry.van.haaren@intel.com, narender.vangati@intel.com, "Bhagavatula, Pavan" <Pavan.Bhagavatula@cavium.com>, Thomas Monjalon <thomas@monjalon.net>, Akhil Goyal <akhil.goyal@nxp.com> References: <1528477766-15788-1-git-send-email-anoob.joseph@caviumnetworks.com> <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> <f7811a31-b1b4-6634-dd9b-18008a1d6315@caviumnetworks.com> <20180619100939.GA23348@bricha3-MOBL.ger.corp.intel.com> <827adfdd-602f-a70c-fe9f-2c821ceaafb3@caviumnetworks.com> Message-ID: <1390dd35-cd67-a67f-35b5-1d328f82a13a@caviumnetworks.com> Date: Tue, 3 Jul 2018 18:46:39 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <827adfdd-602f-a70c-fe9f-2c821ceaafb3@caviumnetworks.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BM1PR0101CA0066.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::28) To BN7PR07MB4897.namprd07.prod.outlook.com (2603:10b6:406:ef::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8e85d39f-f815-4285-760c-08d5e0e70f0d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4897; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4897; 3:fEs57YKsrynK6tAyDkX/9UC+vQoIYQ1ZoSdWPM6yOUTPiG27mppdWjWU5ETGRAGwoQbKTqVB9qlfY2Z0TaklL+FJ5xGt8guLGO+Mv0nU9faMmh87Z1si5mDMaaLrLNeQIP4prgOR1eX3v97rH7K8U4Uen64jD6LKxAgQopd0TfYQH9DY0ORksJkrufKjBGlG80y2swHbluwFL0z9n0BnMHRCnjuXM8dz0+QLUf6RjsNH7/qVgEjrRW3y8h+esh/b; 25:K/EPxsPmATG2X0x9ZqDI6KbLGHcmSXJ5Z+prJ+ZZ1P5Wp2l/D5juEZhX2AkdNZz2EyjSKGk5NR8dL/LpFDEjmSrnp5bVASgVTZLocZWz4Wx7aa3pN1vrcVfdy0bKmEAma8WJA9dwTaLpt0O/3Cg4jAP4tNd8LqfIiHYBF8M6efNP1vvbftl0Qn9fK2/TqcU87k20r9dkhhSH+1T1IuBoL3P/pmo3vm7F80FaxpAkGlQQ0VaG8Cg1disuyMxj8LpY1yxie4fvYjxxKDNkxSwj01+4EWp2f7z9G82DGXIUsbC3Tz6ByljhhC0X0iFviwXqOMX+eOvquhaIddLdS6ckig==; 31:zU2BrUHhBCX/Q5Np1SZWtwp7KisznokyZeNB2m9M9MpR+TqdL3J2ocP2Q8FY4HzvvGvbITH8Z7fyIlNbmqUJB3F3ylJdIK8NVxLID66sNy8q5qdDCo6VT/sN+8bkkt0yg28gLoBgBz++b9TqoWh/ElfSI1FUqG/CdPsY4V6IXTSw5E2XPKkitmBlQbd1IIl/GYOzMky8+8Ioys/BQdemxJJ9GQh2j+Q7boqyBobEna4= X-MS-TrafficTypeDiagnostic: BN7PR07MB4897: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4897; 20:ycrCui+MrULRStEdLxqTSDWzHpX2nzwq3AZh6v6uWvns4KrjgCDsAjSDONyxl88/8cZbcJGxEAqimO4wbT/jHOgWn6vm1qE9QvQo0IZACy8XtVhtHWa9WaG+wQQ1X5Fnh6e3YMQZ9DZPhgdfANfxP+F8My1zQE9synrtVVMyZQKhpabGdeRYgInUImJshP7S+djenUINNNuEtOqh5t3HfeCj+ZBQJUqnKcUfNcSwW0sYrHofnDLp3aODP5qaH92Hb6FeZqvdc2r4+duMYX4122gu8M9snZKu40P1ogf3YEKUFm868RWYXxh70WkalV4I/waGFo/GqMBDbGJ60Zp77mUwFZNLimrkQySe23ZNgu/w6PijnN4kJULVHkyqUUccLZd3QAvLGcWSyZJCeOcx9Vf+f+atoPaOI4GRw4OM0KdTJd2ex6UlYOmHD1M0ofOIuEVdrAegd1/EfjN387bisHQAH6OJtHqFaR/8lqpA0B/z3ykwcwNsGlq/RZRdYzEFNYvboFJSBpfu8Z2DBn9UPhMSW2agonsIZipuAPI7SA+YkWrUBXtqBKqdVW7Hsd0uqDnE+ZdfKymFJvOjJbdOGZsGCydwQQswA4FgX8Gi3zY= X-Microsoft-Antispam-PRVS: <BN7PR07MB489775EE365B910247161B03F8420@BN7PR07MB4897.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231254)(944501410)(52105095)(93006095)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BN7PR07MB4897; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4897; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4897; 4:AZxGJNu4EJ4WqBA9rKhojhTEscAubNZ3oiWLYEJIUHP9NhVpkZFsdjdUUgEUMchIvPlB7nyLMz0coU9pqBMuPowzqgXGhVMKUqHE1OQNEFck3rKBrhU3sgRfbtK0t7CG2UhEYL3qHYAasSrB646LO3jpXVT8YxywclkUwyYUHZvsVAl3xGWvOxmlx9xkAHVOcB/PslnN6PAQuSsf9X+Hn1Iq5onTal28wWHJ4gr//s8fM0sT7wqEcgOl3pc/aKc2DnvHknafs7FK3iaONVF2o7bbUpvARXCT8D2iI5PumaYq612uGGOxMnYF5g5n5ap+vYPCja3Peww1XrwpbRC5BXj0AyZdaBpDZqijIhqVzeA= X-Forefront-PRVS: 0722981D2A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39860400002)(366004)(136003)(376002)(396003)(346002)(199004)(52164004)(189003)(51914003)(8936002)(42882007)(64126003)(52116002)(55236004)(6246003)(6916009)(6306002)(77096007)(97736004)(229853002)(67846002)(81156014)(6666003)(386003)(8676002)(14444005)(65826007)(305945005)(81166006)(36756003)(76176011)(50466002)(6486002)(68736007)(5660300001)(7736002)(53936002)(16576012)(956004)(3846002)(6116002)(4326008)(2616005)(486006)(47776003)(58126008)(72206003)(186003)(53546011)(316002)(230700001)(54906003)(7416002)(16526019)(11346002)(478600001)(23746002)(476003)(31696002)(966005)(106356001)(2906002)(66066001)(65806001)(3260700006)(65956001)(26005)(93886005)(105586002)(446003)(31686004)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4897; H:[10.88.100.222]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN7PR07MB4897; 23:A43oMB0IkSUsKvOKMfQMIYviTQcQzYHgy0JmY?= =?Windows-1252?Q?2VKTl+MmKK4aGNSpGaaZw9CAfa5Dc8p0hTDQV8/xb+nsEgdayoZXGy9a?= =?Windows-1252?Q?v0d+k8WPAta/a6zBQGQBtIvR17q6GjPGAbqeio/ChnSN/8BH+vhkYwL8?= =?Windows-1252?Q?GxkGiCZ2sFuY0hFugavTK2N5VRKzRpiau/xocAVSenFTZO9wLo1UmJJq?= =?Windows-1252?Q?DtY+Xs0CehDcDCmsR1Co2p9d7V0huwaYlDimFVqBj/zIF3xHDaFmg+HU?= =?Windows-1252?Q?INqJDVbh7P1QTNefbmM72RmGFGyD6ZSTj2NakmVHpTIMfIOGuM1fXivP?= =?Windows-1252?Q?g03ao2LQH4g653gW641heJbfBk1ypW+BI5gYNokjLnrTCxNWNuIcMobU?= =?Windows-1252?Q?QnDSrWzl2ZeSAiha2GgOe5ZK3lDaGkumlKNi2/YesYQC3VK5WGPrAOZz?= =?Windows-1252?Q?VZ2e9Ix6J39SZ59C2di6nHN+U14LmIjAsCJH6CehXPJ44Dp+IgEo6xnP?= =?Windows-1252?Q?zFrGu/JIIi65oyz0plQeNx8/PuXM3kbFjiknPdkjISZzka7MBxpr54KN?= =?Windows-1252?Q?RHAZ1ZnTc6jRpbwQeUVSK7T83yj7lNGFER3kF6M3AVITpNPIGLCgaEf5?= =?Windows-1252?Q?iCCAB9O3QVLS2rZ9WK3/SDoGD3zH4V8XvurypxcVKQOgZj9kIwFTsSnC?= =?Windows-1252?Q?4NdUjus1kdGO8dXhmWUca6bROpXGSbWLVR57STc0Mgk6xpu7TiZg9/cD?= =?Windows-1252?Q?8JKnk0lp4dPzSODFtJV2p/sX5KHUsGba4+h+LUI18IW5zRJHAfakcE5m?= =?Windows-1252?Q?sexPLb3RPfwNagtBJ7B5klKiK3+9aYPnWdkX9CFWgE8pSmnYv5xTdmMZ?= =?Windows-1252?Q?PeNjCCstM83M3flsOHRzWyThmMU0hORPCdGq7K0UmoGT6OcNT/m+ijEy?= =?Windows-1252?Q?bs6ceiac1PLI6s9Off5D0YQ0kraK/o2SLaiMfeiuVJAhn3UAAk9uHrHr?= =?Windows-1252?Q?onkVEFvEtSCDPmFEykNVB7LFC85hw6mKlfId0s2QF8UVhe68WpiuEYUN?= =?Windows-1252?Q?/2WVjCoKm1rBWnmcy4Wxk3qiXKey56MBdJo8lwb/L9QIzJC2SkbqKbma?= =?Windows-1252?Q?O5D6wZDI4RwSPWF71eZ2Y2FEu64gWjHn+gd9Qequ0wyPxqek6R+Go+R2?= =?Windows-1252?Q?Vqt86llqrCCH2e6ZWeQRPHM3tIBm7zHSLaSZy35RwCtxTAcEVsZqt7lV?= =?Windows-1252?Q?7WX3/TqiTqFDr0LBMGfU0On9pABdD4B+Gg6BLqCxroLePqr1tfK5kbnF?= =?Windows-1252?Q?bhYhaqt8jI3L6KMmJHSF1QCfGjAjBnKK1fCmXQCx1t7nkuRRGV+G5TAW?= =?Windows-1252?Q?PxKnfJWDoXsGA33/4gAG0ebjLKMLxtrxRUx/b6muS2PQVfWyjqtbZsFg?= =?Windows-1252?Q?s2nKtf2/psAW9nJMg8tDvUTkAW8wJ4I/NSJP0+QI9/8SjyAXr+stkUS8?= =?Windows-1252?Q?bTyrdW42BFFmq/q8+y/zVgDs5twJracDXqSQIaYx+iPDdsKzgguYwuzD?= =?Windows-1252?Q?nvOxeWsag2yGbcHGcORaC5VqC9QLlHfjJzR/0bKNV5QEY2fnRcIxFNTP?= =?Windows-1252?Q?eV440vS5ZIB1b/6YPOWmO/FTxT90FYX2hY/YSzFqhRHFL4ihN/GZmTkx?= =?Windows-1252?Q?KKgVFslNC8aUOoPg3r0V9xNMwxdWJ4XZpuxRUIQI/Rt1VB1kPwmI9Dnz?= =?Windows-1252?Q?tMZPE0mPzbsYXBJxg=3D=3D?= X-Microsoft-Antispam-Message-Info: YjKi7FAf40ND8COTsrKtyLc/TSL5r7BQ3XSODpXVgSqn+ooiExcJgz5z/CgBOA9O9COfHxcDTGemRbMal3YeDN2FSIL26Z8raoLj+EZ4MpD5Uyn/Cimjtdth0DAPpbs4kMx8r4AL2fJuZIbXfr2u2DRra96zOm5DbuvEmnuIWRWxm9Fx++dfb7nI1sLMuBKTvNl5Wi5RRZIMK0Q8FM1BZft4Uzi1Y6ZlDxqC85cvLilebvZB/XgGdyUH90I8MGPwnP+BnIAI5ggjBFRZwJ0R+wbzuYVY/gB5TUYgc26hkker9qMXV42oyaQK485TYoagz6BGtAeARdSSPmkGk0PlgvOgx8RMVTuekJw3pfybLk8= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4897; 6:Oibep27ZRSETsHTL/wOFyJNKuizwL3f+Fivu5b8WN2bDo7YX+M544ZfrFYPzZREKZQeRijiYToCwZTJrm+m87xupCL3m+2lz6GOMVsclVxWegE/diNE838OVuCFOYGVK1CZr85UCW/nqUKYO/xMUrUvgisXSL+oi6h5LXD5gjaH7q/thAGZad2tRFo3I+vRXxm6RFQKBBH5w7p5QcbCZi/Hut+9fQPEN0TS9WWxkL8da4GdMgpOm8VbrsI5sZSZcKjcxJC/lHNuHe0pefUyiuC8fItgpA0EritgLNQG3Z8meQeD4oCivxYH/YZBxrGr1NeWkulgiqujAbykBEQSlPOVm56IoYeC9bu4kXVD225hx785jrS1p731N2yFRkd1yuYHbWReB5mjQQw94QBAi1pG/VC4UOfC+3A3MZ3QP9G+23Jj5U3WIhp/B61sqUdrbFICgzRxjbFWLIExYcKJXwQ==; 5:yw05l/d5SeoiMWiYYDkgye0aRXArdBUzcw7GbwATw5ZGo0hgLiBwQ/eatwsW1ZbMP9RcGtfUEmnTzOXgONydgabX3Tl7bOom8XNnc4RtFceZEQv0gyJqpbgYFZa7s57zqS4Mah9Gx5ymLFiPKuZm4v5gOHvRo29cC3dWYJ7Xcps=; 24:uwxVK5NlFvOhmXIY44SzNuHjwcc4pXhBDv9c2BHNE+LhJz8j0P0BHPegKpTCiHjBTeVym1OBLMtZFHMDx69dXdv7eiXuiOaQNMl2Y+LP1jM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4897; 7:BD2x9UXIQC3WWGN1s7Lk66/lgCSjSfSFfaLpMpmBHVZ36V1qu3KIqTH2o/Y8YkaUsdkrBBU1eUWv7dnCxNpHzpaVr/0Nag5yKKN42qr05gkA04Lx7lGug969y8Yk1iH8zfnL7EtUb+x0f+xyGcpu05HN9cycu54XmLUAsoKmf4GIJUzDWVZzM0aeHqsZd8FHfs2M1/tIHUHmM2XMHB4g1iWnDRinTj7LZJ23AfJvVY29vfcyg1uoe0LCdmdgU1VO X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2018 13:15:29.5621 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e85d39f-f815-4285-760c-08d5e0e70f0d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4897 Subject: Re: [dpdk-dev] [PATCH v1 00/15] preparing l2fwd for eventmode additions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 03 Jul 2018 13:15:36 -0000 Hi, Gentle reminder! Thanks, Anoob On 19-06-2018 19:37, Anoob Joseph wrote: > External Email > > Hi Bruce, > > > Thanks for the feedback. Please see inline. > > > + Hemant, Nikhil, Sunil, Gage, Harry, Narender, Pavan, Thomas, Akhil > > > On 19/06/18 15:39, Bruce Richardson wrote: >> On Tue, Jun 19, 2018 at 03:34:29PM +0530, Anoob Joseph wrote: >>> Hi Bruce, Pablo, >>> >>> Any comments on this series? >>> >>> Thanks, >>> Anoob >>> >>> On 14/06/18 17:18, Anoob Joseph wrote: >>>> This patchset modularizes l2fwd application to prepare it for >>>> eventmode >>>> additions. This patchset doesn't change the code flow or logic, except >>>> for few minor improvements. Some of the newly added functions are used >>>> in just one place, but is added for efficient usage with eventmode. >>>> >>>> v1: >>>> * Fix all checkpatch reported issues >>>> >> My main concern here is how much this eventmode addition is going to >> complicate the l2fwd example. l2fwd has always been a pretty basic >> example >> app to get users started on the basics of DPDK use, and I'm not sure how >> much we want to move away from that. Is this eventmode-l2fwd better >> being a >> separate app, to allow l2fwd to be kept as simple as it can be? >> >> Looking for more thoughts from others here, since it's a community >> decision >> as to the scope of the examples. >> >> /Bruce > The eventmode helper abstracts most of the changes required by the > application to run in eventmode. This was taken up following the > comments on a patch submitted by Sunil(sunil.kori@nxp.com). > http://patches.dpdk.org/patch/37955/ > > With eventmode helper, an application can be moved to eventmode with > minimal changes. For l2fwd, the key patch which enables eventmode is, > > http://patches.dpdk.org/patch/40920/ > [The aforementioned patch is dependent on this patch series] > > The bulk of the code in this patch(40920) is adding multiple event mode > worker functions.The existing init code and poll mode worker is barely > touched. Multiple workers were introduced because a single event mode > worker would not have made the best use of the varying capabilities of > event devices. > > Single event mode worker could've demonstrated how minimal the changes > can be. But the ability to register multiple workers, fine tuned for > varying capabilities, is a good feature to have since it will enable > applications to utilize the full potential of the hardware. > > Eventmode helper patch series: > http://patches.dpdk.org/project/dpdk/list/?series=61 > > The rules that were followed while drafting eventmode helper were very > simple, > 1. Move any code common to multiple applications to eventmode helper > 2. Expose all capabilities of the devices involved (event & eth devs) > 3. Minimize changes to the existing code > > For l2fwd we can opt for a new eventmode-l2fwd app, but this might not > work for more complicated apps like l3fwd & ipsec-secgw. L2fwd app will > stay the same even with the eventmode additions. It will still be a > quick-start, easy-to-use app. In addition to demonstrating DPDK, it will > also be able to demonstrate how easily an app can be made to run in > eventmode, using the helper functions. > > With more event adapters getting added (tx adapter, crypto adapter, > timer adapter etc), the helper will prove useful in abstracting the > complex configuration options exposed by adapters. Similar changes would > be required in other example apps, and the additions in l2fwd is to > finalize on the approach. > > The current patch series just re-factors the code with couple of patches > fixing preexisting checkpatch issues. The rest of the changes are split > into individual patches for ease of review and testing. Hence the large > number of patches. > > Thanks, > Anoob