From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 8FFC72E81 for <dev@dpdk.org>; Fri, 30 Mar 2018 10:32:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0E27021839; Fri, 30 Mar 2018 04:32:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 30 Mar 2018 04:32:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=G5V3AHJjEsT9htwszH35ldGW3H OEPFmJZTyUTodQ5Qk=; b=fbiJrGCXbkXMJ8+JM+v+AC/2ODJrCz7Jjr1msfY2R/ TyvpQkIl/vJODi0i75Ol+Dx8sEDPnov+pRDkyQ6wP/0xa4aZjuQQKrb8kgqRs2Rt tc0zQzs6XBar04613fL4rvUK9CyAzwf9peZDC0kNq2jNUHQ86BbBkzDMj0yabVSJ E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=G5V3AH JjEsT9htwszH35ldGW3HOEPFmJZTyUTodQ5Qk=; b=PYvmBv91ScucythbAOr1Gr xYD34Bscpo9Zb0PuHBwK2YOB/vsx8ecI13BZvzlPvsrobCOEfapq6XQazxnFDX6V AfW+qo8ks9oRGnhh6ifPyJN/nW4BseEZ+v9QdXmPLuZoXbcl0ZWo2kqCZzivvsSL OMymjHLSR7NUITYZeE2gTcIG/Rt4DRasUPhURJ6s2bHgqxYE0GPWZ4AcffiqD7+n WgJw9ldwrT9Xse5Cl38HuOov2daXDQLQoc+0+eSxsr2OQt8JhGvHK430a0lOilLy 92NPBegyi9aqeqTnTjGziMCzp+d/yqGlIX2hAYB9yZF4voH7xkqcG4ak9HSlYgmA == X-ME-Sender: <xms:Nfa9Wjb-xSLtxDa8FAeW1rDfkrh6XUz_MBNvRUtg6qxOT3SN0YNoyw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 791D8E443C; Fri, 30 Mar 2018 04:32:53 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: hemant.agrawal@nxp.com, dev@dpdk.org Date: Fri, 30 Mar 2018 10:32:30 +0200 Message-ID: <13988753.3FnxEl37g3@xps> In-Reply-To: <fa4cb048-ad72-ec66-e5a6-7bb773e109e5@intel.com> References: <20180329153931.26351-1-thomas@monjalon.net> <79a33084-a6fc-d04a-a503-3c8cc15a58b2@intel.com> <fa4cb048-ad72-ec66-e5a6-7bb773e109e5@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: fix kernel modules build dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 30 Mar 2018 08:32:54 -0000 29/03/2018 20:43, Ferruh Yigit: > On 3/29/2018 7:21 PM, Ferruh Yigit wrote: > > On 3/29/2018 6:01 PM, Thomas Monjalon wrote: > >> 29/03/2018 18:50, Ferruh Yigit: > >>> On 3/29/2018 5:43 PM, Thomas Monjalon wrote: > >>>> 29/03/2018 18:38, Ferruh Yigit: > >>>>> On 3/29/2018 5:32 PM, Thomas Monjalon wrote: > >>>>>> 29/03/2018 17:48, Ferruh Yigit: > >>>>>>> On 3/29/2018 4:39 PM, Thomas Monjalon wrote: > >>>>>>>> Some kernel modules may need some header files to be "installed" > >>>>>>>> in the build directory. > >>>>>>>> > >>>>>>>> When running multiple threads of make, kernel modules can try to > >>>>>>>> be compiled before the lib headers are ready: > >>>>>>>> make -j3 > >>>>>>>> kernel/linux/kni/kni_misc.c:19:37: fatal error: > >>>>>>>> exec-env/rte_kni_common.h: No such file or directory > >>>>>>> > >>>>>>> Is there a reason to keep header in eal when module itself moved into kernel? > >>>>>> > >>>>>> It seems you missed my comment below: > >>>>>> > >>>>>> On a related note, this header file > >>>>>> lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h > >>>>>> could be moved to lib/librte_kni/ > >>>>>> Opinion? > >>>>> > >>>>> Ahh, yes we are saying same thing. > >>>>> But not sure if it should go under lib/librte_kni/ or kernel/linux/kni/? > >>>>> I lean to kernel/linux/kni/. > >>>> > >>>> Why in kernel/? > >>>> > >>>> Logically, kernel/ depends on lib/ but not the reverse. > >>>> > >>>> And regarding the licensing, we avoid BSD files in Linux modules. > >>> > >>> From functionality point of view, module provides the functionality and it > >>> should provide the header, this can be all subjective tough :) > >>> > >>> Or in other words, if you have the kernel module, you can write another piece of > >>> userspace application (without using librte_kni) and it will be functional. > >>> But if you have the librte_kni only, it won't be functional on its own. > >>> > >>> Providing header with kernel enables other userspace app to user KNI. > >> > >> So you are saying we should reverse the dependency? > >> It would mean moving all headers used by kernel modules in kernel/ directory: > > > > No, not talking about moving headers to kernel/ folder. But we can "liberate" J > > the kernel modules. > > > > For KNI, rte_kni_common.h is shared between kernel and userspace, can't escape > > from it. But why this common header needs to depend other dpdk headers at all? > > Indeed commenting out rte_common and rte_config worked fine, it seem there is > > already no dependency. > > Hemant is right, putting rte_kni_common makes build dependent to module build, > and module is more fragile. > > I agree to move header to userspace library. Does it mean you ack this patch? Do you want to make a patch to move the header from EAL to librte_kni?