From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] kni: fix compilation issue on kernel 3.19
Date: Sun, 22 Mar 2015 23:23:04 +0100 [thread overview]
Message-ID: <13995381.n056FK0HbU@xps13> (raw)
In-Reply-To: <1427047336-7271-1-git-send-email-pablo.de.lara.guarch@intel.com>
> From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>
> Due to API changes in functions ndo_dflt_bridge_getlink
> (commit 2c3c031c) and ndo_fdb_add (commit f6f6424b)
> in kernel 3.19, DPDK would not build.
>
> This patch solves the problem, by checking the kernel version
> and adding the necessary new parameters.
>
> Mind that function igb_ndo_fdb_add does not need the extra parameter
> if USE_CONST_DEV_UC_CHAR is not set, since that macro is only defined
> when kernel is greater or equal than 3.7
>
> changes in v2:
>
> - Added commits id of the API changes done in the kernel
> - Added missing blank line
> - Added extra details in the commit message
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied, thanks
prev parent reply other threads:[~2015-03-22 22:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 18:02 Pablo de Lara
2015-03-22 22:23 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13995381.n056FK0HbU@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).