From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7BE8A0032; Fri, 29 Oct 2021 22:33:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2376340688; Fri, 29 Oct 2021 22:33:22 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id B1FAA40395 for ; Fri, 29 Oct 2021 22:33:20 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10152"; a="228204098" X-IronPort-AV: E=Sophos;i="5.87,193,1631602800"; d="scan'208";a="228204098" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2021 13:33:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,193,1631602800"; d="scan'208";a="448238531" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 29 Oct 2021 13:33:19 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 29 Oct 2021 13:33:19 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 29 Oct 2021 13:33:18 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 29 Oct 2021 13:33:18 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 29 Oct 2021 13:33:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V4yLAlGqBtn1jR/Db8mpXPhoCqKUUIdZdNCX1/zCR0JSZZI/kJvbjDHEy1ZPMHMyMbLHVZEuaCovME6cg2iGyJfJtnCPX5b0att2bq10PFKUEtaPhPbCbD2GNjq/tnxmVQs/MfkWXN42Zt35FkZd+pVqbBccGJRG/c1xe7fS5efIpClq9kdbYIlvUAA4BNvi3CSG8YwtOvtx/GelVyBMqF7PutiyVJaxWoDZEqCP+3p8Zw32uYS/kVPdvtyF5tGmmYA8qkCVpsR8bNlI3aZbCsyAcv4/keRhUTWpW0HMxxKNQjxnvFCebTvaxw5Gc6iu9FiU81p1k9WlZskjVgD2Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hAggaX3f6Y4Hvk+WMAuLwWPD9A36KIt3/f43TD67Gac=; b=XwdX8Q0uLJEKIP3auhAkFf2S5UB8/s1N5C9FvYuugm7m/1Jd2sMmqUSHphy+2V4wy81sWL/+pssotKx5PQZ+cn1RgfpeGMxRQsf5yKhSYLUm8tBZ30UiDCWU+IsXxHieP4M1vGn+C4Jxkbgo88BVIP7TZ8/VnCIDqRia0WQPQgzwZftAdGwNIXTvJartfZt3YcOx3be/6bVR1hZDsmA0CWlUaCUOPADmOm/RU1Zj9dBEpVQ4B+goG2S19wjUpJe5jD46X1Laamm6kcUknUgL1x/IgGEOnHOKpieFgZncPH+jxqvW0QhcdXdyGyTzPYNfoQPbjGviEgbgBZ7QSWNFVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hAggaX3f6Y4Hvk+WMAuLwWPD9A36KIt3/f43TD67Gac=; b=bS4GQ0R4TExiAx76jB3CJjaIKQu0geGKNKzZZ0zUVIBh5AfmyE+TvadUX0qTsYAYcLb+T8HBNwkT4ICuUvq/nX8FXBckSWOBn4DWFO5cUrxTNwV27WKPHgAK44Hr4KVghUkFg2PKjMExwl91oN3bNVzxKZDu9ruJXIQ7ceoyRIs= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5032.namprd11.prod.outlook.com (2603:10b6:510:3a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Fri, 29 Oct 2021 20:33:15 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.015; Fri, 29 Oct 2021 20:33:15 +0000 Message-ID: <13a6647b-53a4-54e3-5353-e68daff581bb@intel.com> Date: Fri, 29 Oct 2021 21:33:07 +0100 Content-Language: en-US To: Radu Nicolau , Jingjing Wu , Beilei Xing CC: , , , , , , David Marchand References: <20210909142428.750634-1-radu.nicolau@intel.com> <20211028160500.2775783-1-radu.nicolau@intel.com> <20211028160500.2775783-4-radu.nicolau@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211028160500.2775783-4-radu.nicolau@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0349.eurprd04.prod.outlook.com (2603:10a6:10:2b4::6) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0349.eurprd04.prod.outlook.com (2603:10a6:10:2b4::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.13 via Frontend Transport; Fri, 29 Oct 2021 20:33:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6f7c80fc-5f7c-47ac-927f-08d99b1b5527 X-MS-TrafficTypeDiagnostic: PH0PR11MB5032: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YlssUdkFm3evTLbgqmQSntPrn+blJMHT7/V0MU0Ax+51xiuvCW9PiMhi9MAj/tPGyQ23Lknh9MjgU2eTlKysrP7cdhFFxW6bx5y1paUwiaVCFcUAUJg2x/d9ceZdISab22YAAbzxN83ys4qguS9noqxPIxPMWUqqa089i3Ycmks2TXQLolNCft+O03IFFi8y3Mso+oBSTMpu7l17SPTKMmdXY+6nd9NxVb6XSJjE9yIfKmfJPpq+mMaYt6fzMt6v56/v0eDWiBtuMBjOE3UMRlre4RWxATczIgOftt/srPDUuMfO9PrwFGDDKjyJosSPqGzXxvKcgta0zaQcmQ4DTa70J3GDhpaHQ24DlQv4xovOoo4CDkW9EnGBdngrB+XCTaMGdcXKiocpH80ClJwzLmkK4HbqnFdLpWCA7dJ+ChbVd63Kkjxz9IhAD5iG5GetZe3k8nKEuRa1e02KkJUKG0KPtbyHGuzXzr4QEH/eGbZrRbCL7o4afC6oPyry24EpqHkADeGlmdcmGtVCS1B28fQ+9URaCL8nGkXF1Cg/9b9orVJNTjhWVh78oJCwC0yrgcob/HeEXGsB9e/N3Cc3VqUZnEvQLgVBFzksTpKBsa9JVvAEE3yfE7seC33YN29SDxwIoxZd4v9qxArVmvFe5xg/wRHVlzDYI3ddbsMY0LxXg0f/vnEFPo5gz3t7TJVBhhvhqL+7qLI0D8xrN6/SWw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(6666004)(36756003)(508600001)(8676002)(31696002)(26005)(186003)(4326008)(2616005)(6636002)(8936002)(6486002)(16576012)(110136005)(83380400001)(86362001)(53546011)(956004)(5660300002)(82960400001)(66556008)(44832011)(31686004)(316002)(66476007)(38100700002)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzZFRVo4dkZadFhzMmYyVHoyUUY3YkVRU1FxSmowbjNtT3FTdUJpOXpnR2hN?= =?utf-8?B?S2tBTWR1QURIVHZsTFRaTjZVbjQ1U21oN0l6SjVwdUt0YUltOTRaRklFT0d1?= =?utf-8?B?Tmx3OXo5OGcwMWZqKy94RVRHRzd5ajFFWU1DZWFrSStvcnhLanowWjVTZ0Y1?= =?utf-8?B?dnRkYm1idUZ6ZGZ3YVYzWHlSb3h1RXFQcU83TDlBZXpmM2RFdXZIb1E4dlFG?= =?utf-8?B?RS9OSjJCbWJBZDRVWklobjBLTmhMM1kzM1dKWFlyTGpmeDJzd3JNVTFMbmYv?= =?utf-8?B?QlZlV243QkFRdDNCUXRBY0pSQTRwa1E1Q1M1anBoaXFneGZuZ0gwRjUyYWJi?= =?utf-8?B?TFhMRjJaaXNQZWdacWdWUjNxTkVSTXcxTVJuaXNsMUcvSHY3cUFwb3B3WFBv?= =?utf-8?B?aXlDcEV3SlF6V0FyL1c4aURWSkVIMVl3cUpLRjdKNGRXQnhZaG5PRTVPMWtE?= =?utf-8?B?MW80YktiVmQzRXhJNmc3Q0dwQTdXWUVtTE5Jcm9Sem9ZMmNMK3ViYXpNOGxL?= =?utf-8?B?UXQrMTladTN3VnhOVElEbGNaekJ1VkNtZWR3R0ErN3ovL3hnQjdHN3FRb3lO?= =?utf-8?B?blNBZWMyNUJ3SzN3MFhVM3NMZGh5anlqbnE0ZHI2bUczVE9sOStjbGcwMS9W?= =?utf-8?B?SVJqVkh2MzNhRlVjdkQ2bi9YSFpRUGFXNWJWdE45NjdlTUFpT1krKzVDS2JS?= =?utf-8?B?bXg1UkptTEFsVVVhSytGNVg3WnlubWZzNEI4RVdQK0tPUmh6Rkxjd3lBcE9T?= =?utf-8?B?YW5odGNLMk9zN1loYWd0K3NjSzRUb3J4VGJwbnpnVm9DeU4xY3BSeXJBYWg3?= =?utf-8?B?eWQwcEluOFV2SXhsNE9oT1Z3Qyt2eGdEaFQyL3I1Q3Bid1c4dEVVdjBsSjhk?= =?utf-8?B?S1pwdFBLRHVLSkt6NmV2ck9NMDdnVlJsUyt6MUs1Y2JJcENKak5kTVZZYnhm?= =?utf-8?B?aENpZkVFUTZUbFFNVFUxS2dNbmxGZFFjYzV6Z252bm4xVEkxTG53M0s1eHoz?= =?utf-8?B?Yk5Vbk1zek1wR3l1aGZtZURPTnlTNTVEcVNFQWxpd3VaeTFXZVFJNEc5MUxw?= =?utf-8?B?ZEt6TWlEVDJoVGdCQ25GRTRtWVBoZ0YrNU1OZ2FLbDZNRnNZcTBPbU9XOTNN?= =?utf-8?B?b2Y2QVRoQkt0ZkN5YkJvM3F2SUtEaDhLMnk3ZDYzYzJseGRoQ0Q1WEFUQ01y?= =?utf-8?B?UXkwUHd6Qyt2YWh0WjE2c3VqZnRXVDdLSFBZZG16WUxwaTBOOU92SzN6U1RR?= =?utf-8?B?WGlWUm9QMGhKcm5vNmhvZ01WUzN2dy9TcTZ1bXVJMmNDN1ZqR24vZ0lIUFhP?= =?utf-8?B?dE1odGk3SkZVWkZxamxQZHU0R25qK1hrVHdnK2FaWDdQbEYydU1jNEFGc0tw?= =?utf-8?B?Yytaam8rTlVrNHNxRWxOT2VULysxS0ZDWkwwbDVkY1Z2TmxUOHlNd1Y3dUZD?= =?utf-8?B?UGp6UGo4c284UGc4alVmMnNNdlBSblBISXo0WXdxU2hTSFdKSFFBQkMyTExn?= =?utf-8?B?L3V1UEsrM3paUW1FT3RvTFM2eW91V21qQVQ2aElIOFFZWUVKclRlSHoyLzZT?= =?utf-8?B?U1NUM0pSL25IMHI5dHUvRFo2MVZLQjNUYnNULzlVMmlYMm55RkFseVU1WHY4?= =?utf-8?B?MjZtdjVCNGxPdXlHNEFoWmYyZHFqczIzV3dvTVNocFdpTVk5YVdyMFBXVnZS?= =?utf-8?B?VXJZbHhpWTNNSnpEZVJyTEUxYW52dXcrSEhlK0o3OEtNN2k1NDY4V2tyMGx6?= =?utf-8?B?Mml5Yms4U2lvVFoxTTg5WVF1Qld1TWNWM0tnbEpPbXRkcmFvU0YvSU5nY3pF?= =?utf-8?B?NUpNdys2MEthOWlkcmpLQlJudENweGhqVG44N2NCajVrTHdIMjAzVHBnQjBV?= =?utf-8?B?TWJLRUs3RzZOa1FnQ2NLREFlcjVTOU9sQ044MkRZcVh1ZThyektBb1c4UWRw?= =?utf-8?B?MVd0R254ZFk3RUpza3R2WW5sZ1NuZzVOTnhWalVqZUFwT2Qydmw3V1lHNng4?= =?utf-8?B?REE1K29HYUxzejRpaGJtaEVBK1BmczY3SFF5YUNxMnQ3amRxNjE1bkNrdHl2?= =?utf-8?B?aHNzTklKejU2MVJPc05WWUY2OGYwVmVUNXB1YjF3UHVqdkFrRS9aY3p4V0lD?= =?utf-8?B?eGk3VG1OcGJmN2E5dFJMY0NaZnhLUXJDdTdPaTlsclFWMi8wb3VZcE9zN3dk?= =?utf-8?Q?uVkrr8DNvrNFsjAuFF3xBwY=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6f7c80fc-5f7c-47ac-927f-08d99b1b5527 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 20:33:14.8836 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /9fzs+seE42G/iffTwDaosh5s1F5On77TzAOsd+3Rz5ZkhrfsowyMydfi6f3md2csQgWKmMBHPjz7R8U4UZUUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5032 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v13 3/7] net/iavf: add support for asynchronous virt channel messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/28/2021 5:04 PM, Radu Nicolau wrote: > @@ -339,15 +340,35 @@ _clear_cmd(struct iavf_info *vf) > static inline int > _atomic_set_cmd(struct iavf_info *vf, enum virtchnl_ops ops) > { > - int ret = rte_atomic32_cmpset((volatile uint32_t *)&vf->pend_cmd, > - VIRTCHNL_OP_UNKNOWN, ops); > + enum virtchnl_ops op_unk = VIRTCHNL_OP_UNKNOWN; > + int ret = __atomic_compare_exchange((volatile uint32_t *)&vf->pend_cmd, > + &op_unk, &ops, > + 0, __ATOMIC_ACQUIRE, __ATOMIC_ACQUIRE); > > if (!ret) > PMD_DRV_LOG(ERR, "There is incomplete cmd %d", vf->pend_cmd); > > + __atomic_store_n(&vf->pend_cmd_count, 1, __ATOMIC_RELAXED); > + > return !ret; > } > > +/* Check there is pending cmd in execution. If none, set new command. */ > +static inline int > +_atomic_set_async_response_cmd(struct iavf_info *vf, enum virtchnl_ops ops) > +{ > + enum virtchnl_ops op_unk = VIRTCHNL_OP_UNKNOWN; > + int ret = __atomic_compare_exchange((volatile uint32_t *)&vf->pend_cmd, > + &op_unk, &ops, > + 0, __ATOMIC_ACQUIRE, __ATOMIC_ACQUIRE); > + > + if (!ret) > + PMD_DRV_LOG(ERR, "There is incomplete cmd %d", vf->pend_cmd); > + > + __atomic_store_n(&vf->pend_cmd_count, 2, __ATOMIC_RELAXED); > + > + return !ret; > +} David reported build error on Windows [1], fixing in next-net [2]. @Radu can you please confirm the latest code in the next-net? [1] ../drivers/net/iavf/iavf_rxtx_vec_avx512.c In file included from ../drivers/net/iavf/iavf_rxtx_vec_avx512.c:5: In file included from ..\drivers\net\iavf/iavf_rxtx_vec_common.h:11: ..\drivers\net\iavf/iavf.h:376:4: error: passing 'enum virtchnl_ops *' to parameter of type 'uint32_t *' (aka 'unsigned int *') converts between pointers to integer types with different sign [-Werror,-Wpointer-sign] &op_unk, &ops, ^~~~~~~ ..\drivers\net\iavf/iavf.h:376:13: error: passing 'enum virtchnl_ops *' to parameter of type 'volatile uint32_t *' (aka 'volatile unsigned int *') converts between pointers to integer types with different sign [-Werror,-Wpointer-sign] &op_unk, &ops, ^~~~ ..\drivers\net\iavf/iavf.h:393:4: error: passing 'enum virtchnl_ops *' to parameter of type 'uint32_t *' (aka 'unsigned int *') converts between pointers to integer types with different sign [-Werror,-Wpointer-sign] &op_unk, &ops, ^~~~~~~ ..\drivers\net\iavf/iavf.h:393:13: error: passing 'enum virtchnl_ops *' to parameter of type 'volatile uint32_t *' (aka 'volatile unsigned int *') converts between pointers to integer types with different sign [-Werror,-Wpointer-sign] &op_unk, &ops, ^~~~ 4 errors generated. [2] diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h index 42fb66d71193..f413dbed833a 100644 --- a/drivers/net/iavf/iavf.h +++ b/drivers/net/iavf/iavf.h @@ -372,8 +372,7 @@ static inline int _atomic_set_cmd(struct iavf_info *vf, enum virtchnl_ops ops) { enum virtchnl_ops op_unk = VIRTCHNL_OP_UNKNOWN; - int ret = __atomic_compare_exchange((volatile uint32_t *)&vf->pend_cmd, - &op_unk, &ops, + int ret = __atomic_compare_exchange(&vf->pend_cmd, &op_unk, &ops, 0, __ATOMIC_ACQUIRE, __ATOMIC_ACQUIRE); if (!ret) @@ -389,8 +388,7 @@ static inline int _atomic_set_async_response_cmd(struct iavf_info *vf, enum virtchnl_ops ops) { enum virtchnl_ops op_unk = VIRTCHNL_OP_UNKNOWN; - int ret = __atomic_compare_exchange((volatile uint32_t *)&vf->pend_cmd, - &op_unk, &ops, + int ret = __atomic_compare_exchange(&vf->pend_cmd, &op_unk, &ops, 0, __ATOMIC_ACQUIRE, __ATOMIC_ACQUIRE); if (!ret)