From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id ABCC9271 for ; Mon, 11 Dec 2017 11:46:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 02:46:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,391,1508828400"; d="scan'208";a="1833524" Received: from dhunt5-mobl1.ger.corp.intel.com (HELO [10.237.220.36]) ([10.237.220.36]) by orsmga008.jf.intel.com with ESMTP; 11 Dec 2017 02:45:59 -0800 To: Marko Kovacevic , dev@dpdk.org References: <20171128132203.43181-1-marko.kovacevic@intel.com> <20171128132203.43181-3-marko.kovacevic@intel.com> From: "Hunt, David" Message-ID: <13b4f489-99d6-aafe-e078-a26c8e2bc440@intel.com> Date: Mon, 11 Dec 2017 10:45:58 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171128132203.43181-3-marko.kovacevic@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 3/4] power: clean up of kvm files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 10:46:02 -0000 Hi Marko, On 28/11/2017 1:22 PM, Marko Kovacevic wrote: > Signed-off-by: Marko Kovacevic > --- > lib/librte_power/Makefile | 2 +- > .../{rte_power_kvm_vm.c => power_kvm_vm.c} | 28 +++++++++++----------- > .../{rte_power_kvm_vm.h => power_kvm_vm.h} | 28 +++++++++++----------- > lib/librte_power/rte_power.c | 28 +++++++++++----------- > 4 files changed, 43 insertions(+), 43 deletions(-) > rename lib/librte_power/{rte_power_kvm_vm.c => power_kvm_vm.c} (83%) > rename lib/librte_power/{rte_power_kvm_vm.h => power_kvm_vm.h} (85%) > > diff --git a/lib/librte_power/Makefile b/lib/librte_power/Makefile > index bf5a55e..a35c50a 100644 > --- a/lib/librte_power/Makefile > +++ b/lib/librte_power/Makefile > @@ -43,7 +43,7 @@ LIBABIVER := 1 > > # all source are stored in SRCS-y > SRCS-$(CONFIG_RTE_LIBRTE_POWER) := rte_power.c power_acpi_cpufreq.c > -SRCS-$(CONFIG_RTE_LIBRTE_POWER) += rte_power_kvm_vm.c guest_channel.c > +SRCS-$(CONFIG_RTE_LIBRTE_POWER) += power_kvm_vm.c guest_channel.c > > # install this header file > SYMLINK-$(CONFIG_RTE_LIBRTE_POWER)-include := rte_power.h > diff --git a/lib/librte_power/rte_power_kvm_vm.c b/lib/librte_power/power_kvm_vm.c > similarity index 83% > rename from lib/librte_power/rte_power_kvm_vm.c > rename to lib/librte_power/power_kvm_vm.c > --snip-- Could I suggest you add the following into the commit message? "rename private header file rte_power_kvm_vm.c to power_kvm_vm.c. This prevents the private functions from leaking into the documentation. Change any private functions from rte_ to just . Reserve the rte_ for public functions. " Regards, Dave.