From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F34AA0597; Thu, 9 Apr 2020 16:11:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 289D51C297; Thu, 9 Apr 2020 16:11:00 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 09B1B1C296 for ; Thu, 9 Apr 2020 16:10:58 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200409141057euoutp02ac151b91407d5ebcbf88c9728318f95c~ELBm8_lLS0704707047euoutp02B for ; Thu, 9 Apr 2020 14:10:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200409141057euoutp02ac151b91407d5ebcbf88c9728318f95c~ELBm8_lLS0704707047euoutp02B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1586441457; bh=Y28RyfvkH6ydusuVJf5Wug8nA4KbE6pe6OlJLCLaBt4=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=VOHDnGrDpG+vfxiP0LCRIUQ1bpOE46ii7ULTT+ybJdZdaEPcMbJQt9K98DJw5RUcL 5uNbgOpIvtm5eAw3NIjC2laWxpXyxx5ByK2Y9OTUvVNh4+anS2/9bydvN/hifCGXPq kZoPo76dyMDvStRgXVRYG1Tut8/5csjzCb2Amxa0= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200409141057eucas1p2f255649ce879475a36ce1fd211cf2f0a~ELBmzHS5x2033020330eucas1p2Q; Thu, 9 Apr 2020 14:10:57 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 59.CC.60679.1FC2F8E5; Thu, 9 Apr 2020 15:10:57 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200409141057eucas1p141d82f32fc8d394634034145ac90373b~ELBmgqI9e2937629376eucas1p1m; Thu, 9 Apr 2020 14:10:57 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200409141057eusmtrp24a92a783739dc4dafc895bcd769d6282~ELBmgFNpR1576115761eusmtrp2G; Thu, 9 Apr 2020 14:10:57 +0000 (GMT) X-AuditID: cbfec7f4-0cbff7000001ed07-2f-5e8f2cf19eb1 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 6A.18.08375.1FC2F8E5; Thu, 9 Apr 2020 15:10:57 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200409141056eusmtip1f40b91a6545c703f706e9f7142f88266~ELBl5l2Jb1242812428eusmtip19; Thu, 9 Apr 2020 14:10:56 +0000 (GMT) To: Thomas Monjalon Cc: Pavan Nikhilesh , Jerin Jacob , dev@dpdk.org, stable@dpdk.org From: Lukasz Wojciechowski Message-ID: <13ea5f0f-782f-ac86-2014-3b0fe6120678@partner.samsung.com> Date: Thu, 9 Apr 2020 16:10:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1777512.atdPhlSkOF@thomas> Content-Transfer-Encoding: 8bit Content-Language: pl X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKKsWRmVeSWpSXmKPExsWy7djPc7ofdfrjDNqXq1i8+7SdyWLiJBOL i+ssLP51/GG3+PTgBIsDq8eGE/2sHr8WLGX1OHZzGnsAcxSXTUpqTmZZapG+XQJXxomN61kK rghUTL15hLWBcR1vFyMnh4SAicTu9Y9ZQGwhgRWMEi0zyrsYuYDsL4wSD090s0A4nxkljk95 w9TFyAHWceuaKER8OaNEa+tvqO63jBKHDwqD2MICNhKbt3QxgtgiApoSt7/PYgRpYBZoARr0 qJcVJMEmYCtxZOZXMJtXwE1i4psZ7CA2i4CKxLW1nWDNogKxEuce3YCqEZQ4OfMJ2DJOAQ2J yxMeMoHYzALyEs1bZzND2CISNx61gC2TEJjOLtH8cCcbxJ8uEtOnfWSHsIUlXh3fAmXLSPzf OZ8JomEbo8TV3z+huvczSlzvXQFVZS1x+N9vNpD/mYH+Wb9LHyLsKPH22yY2SLDwSdx4Kwhx BJ/EpG3TmSHCvBIdbUIQ1XoST3umMsKs/bP2CcsERqVZSF6bheSdWUjemYWwdwEjyypG8dTS 4tz01GKjvNRyveLE3OLSvHS95PzcTYzAxHL63/EvOxh3/Uk6xCjAwajEw2vA0B8nxJpYVlyZ e4hRgoNZSYTXu6k3Tog3JbGyKrUoP76oNCe1+BCjNAeLkjiv8aKXsUIC6YklqdmpqQWpRTBZ Jg5OqQbGrQn/s3+2ap78ab4hhF9yzjNlLYvJhnXzrXONaw6mdi8WP6uesmshx6Pp3np2l/1T zt1p4rur1Md5+88iZUEDS7kcb94LAgsP8fhft9vuvYbjk/D2JafUJBv3S9SmXN62ao9V5Vpn Rbmmz6u8tTOKeIzjv02aeSZze8fl1ymfi/0jXfb6Za5TYinOSDTUYi4qTgQAUFx1lygDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRmVeSWpSXmKPExsVy+t/xu7ofdfrjDHrv8lm8+7SdyWLiJBOL i+ssLP51/GG3+PTgBIsDq8eGE/2sHr8WLGX1OHZzGnsAc5SeTVF+aUmqQkZ+cYmtUrShhZGe oaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJexomN61kKrghUTL15hLWBcR1vFyMHh4SA icSta6JdjFwcQgJLGSWat15mhojLSHy4JNDFyAlkCkv8udbFBlHzmlHi6vcGZpCEsICNxOYt XYwgtoiApsTt77MYQYqYBVoYJW5vmM4I0TGRSWLDqU1gVWwCthJHZn5lBbF5BdwkJr6ZwQ5i swioSFxb2wlWIyoQK9HfvJsRokZQ4uTMJywgNqeAhsTlCQ+ZQGxmATOJeZsfMkPY8kBXz4ay RSRuPGphnMAoNAtJ+ywkLbOQtMxC0rKAkWUVo0hqaXFuem6xoV5xYm5xaV66XnJ+7iZGYCxt O/Zz8w7GSxuDDzEKcDAq8fAaMPTHCbEmlhVX5h5ilOBgVhLh9W7qjRPiTUmsrEotyo8vKs1J LT7EaAr03ERmKdHkfGCc55XEG5oamltYGpobmxubWSiJ83YIHIwREkhPLEnNTk0tSC2C6WPi 4JRqYJR0ua39S+Q3p8OM7DvduVcCrDYdrVWpF59e+sj5wcb3uUfUZY48X3qqsSxirg1f6aQi +2frPN5OfGT2mvWY7i19yRuP5sjY5axczpn/4VFqavGdWue7Wm+uPlp5bXnQZOmDXXP1jxg8 POwSWansszpI8ayLqebUSYa9Nv8L+TxSJSI2fNJ87q7EUpyRaKjFXFScCACDxGWAuwIAAA== X-CMS-MailID: 20200409141057eucas1p141d82f32fc8d394634034145ac90373b X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200408174810eucas1p26c4e88e28a1056d40e27356fc23b78b6 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200408174810eucas1p26c4e88e28a1056d40e27356fc23b78b6 References: <20200312151654.7218-1-l.wojciechow@partner.samsung.com> <9733532.nUPlyArG6x@thomas> <1777512.atdPhlSkOF@thomas> Subject: Re: [dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 08.04.2020 o 19:47, Thomas Monjalon pisze: > 08/04/2020 18:15, Lukasz Wojciechowski: >> Hi Thomas, >> >> Before my patch there was just a definition: >> #define RTE_TEST_TRACE_FAILURE TEST_TRACE_FAILURE >> without #ifndef condition. >> >> It caused a build problem to me when working on security test, which >> uses both rte_test.h and test.h >> As libraries should go first on the include list before local files I used: >> >> #include >> #include "test.h" >> >> sequence, which cause obvious build error as RTE_TEST_TRACE_FAILURE was >> first defined as an empty macro inside rte_test.h, and redefinition in >> test.h caused a problem. >> >> >> So I had two ways to solve the issue: >> 1) to wrap it with #ifndef condition and leave the definition there >> 2) to remove the redefinition from test.h >> >> I've chosen the 1) solution because: >> * Author of the former patch had placed the definition there for some >> purpose > Because rte_test.h is more recent and its addition was not complete enough. > rte_test.h should be included in test.h, and overlaps removed. > >> * In my opinion it is better to have the definition present and pointing >> to the same macro for both RTE_TEST_TRACE_FAILURE and TEST_TRACE_FAILURE >> as it would make logs look more consistent when printing information the >> same way. > I think solution 2 is better. Ok I'll change this patch and remove the macro definition at all from app/test/test.h I'll publish it with version 3, but I'll wait a bit more for getting more comments on version 2 > > > PS: please avoid top-posting Sorry > > >> W dniu 08.04.2020 o 14:53, Thomas Monjalon pisze: >>> 08/04/2020 05:13, Lukasz Wojciechowski: >>>> Wrap RTE_TEST_TRACE_FAILURE macro definition into #ifndef clause >>>> as it might be already defined. >>> I think it should not be defined at all. >>> Why not including rte_test.h? >>> >>> >>> > > > > > -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com