From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 8CC443576 for ; Fri, 5 Oct 2018 14:35:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2018 05:35:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,344,1534834800"; d="scan'208";a="78728543" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga007.jf.intel.com with ESMTP; 05 Oct 2018 05:35:07 -0700 To: Neil Horman Cc: Bruce Richardson , Thomas Monjalon , dev@dpdk.org, Luca Boccassi , Christian Ehrhardt References: <20181004154306.65867-1-ferruh.yigit@intel.com> <1785611.eL8Z1dKoq2@xps> <56a42359-9ead-7c33-72a3-1d89d56f383c@intel.com> <33456122.koQSlajCb5@xps> <20181005091351.GA20880@bricha3-MOBL.ger.corp.intel.com> <475dc69c-ed2f-dcf3-4af0-a7050051c270@intel.com> <20181005113057.GA15009@hmswarspite.think-freely.org> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <13ede968-aeff-0282-92e6-c2c0db12ab7e@intel.com> Date: Fri, 5 Oct 2018 13:35:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181005113057.GA15009@hmswarspite.think-freely.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] config: disable RTE_NEXT_ABI by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 12:35:10 -0000 On 10/5/2018 12:30 PM, Neil Horman wrote: > On Fri, Oct 05, 2018 at 11:17:30AM +0100, Ferruh Yigit wrote: >> On 10/5/2018 10:13 AM, Bruce Richardson wrote: >>> On Thu, Oct 04, 2018 at 05:55:34PM +0200, Thomas Monjalon wrote: >>>> 04/10/2018 17:28, Ferruh Yigit: >>>>> On 10/4/2018 4:10 PM, Thomas Monjalon wrote: >>>>>> 04/10/2018 17:48, Ferruh Yigit: >>>>>>> Enabling RTE_NEXT_ABI means to enable APIs that break the ABI for >>>>>>> the current release and these APIs are targeted for further release. >>>>>> >>>>>> It seems nobody is using it in last releases. >>>>>> >>>>>>> RTE_NEXT_ABI shouldn't be enabled by default. >>>>>> >>>>>> The reason for having it enabled by default is that when you build DPDK >>>>>> yourself, you probably want the latest features. >>>>>> If packaged properly for stability, it is easy to disable it in >>>>>> the package recipe. >>>>> >>>>> My concern was (if this has been used), user may get unstable APIs and without >>>>> explicitly being aware of it. >>>> >>>> I am OK with both defaults (enabled or disabled). >>>> >>> I'd keep it as is. As said, I'm not sure it's being used right now anyway. >> >> No, not used right now. >> But I think we can use it, did you able to find chance to check: >> >> https://mails.dpdk.org/archives/dev/2018-October/114372.html >> >> Option D. >> > > Just to propose something else, We also have the ALLOW_EXPERIMENTAL_API flag > that we IIRC default to on. Would it be worth consolidating these two > mechanisms into one? Currently ALLOW_EXPERIMENTAL_API lets us flag symbols that > are not yet stable, and it seems to work well. It does not however let us > simply define out structures/variables that might adversely affect the ABI. > Would it be worth considering adding a macro (something like > __rte_experimental_symbol()), that allows a variable/struct to be defined if > ALLOW_EXPERIMENTAL_API is set, and squashed otherwise? RTE_NEXT_ABI is not just for symbols. If there a new API foo(), __rte_experimental works fine to mark it experimental. But if there is an _existing API_ "bar(char)", and we plan to change it to "bar(int, int)", to publish the change early in this release we need RTE_NEXT_ABI ifdef since both can't exist together, so it will be used as: Release N: #ifdef RTE_NEXT_ABI bar(int, int); #else bar(char); #endif Release N + 1: bar(int, int);