[dpdk-dev] [PATCH] eal/x86: remove unused memcpy file

[dpdk-dev] [PATCH] eal/x86: remove unused memcpy file

[Thomas Monjalon]

The use of rte_memcpy_ptr was removed in revert below,
but it was missing removing the file arch/x86/rte_memcpy.c.

Fixes: d35cc1fe6a7a ("eal/x86: revert select optimized memcpy at run-time")
Cc: stable@dpdk.org
Cc: xiaoyun.li@intel.com

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_eal/common/arch/x86/rte_memcpy.c | 29 ---------------------
 1 file changed, 29 deletions(-)
 delete mode 100644 lib/librte_eal/common/arch/x86/rte_memcpy.c

diff --git a/lib/librte_eal/common/arch/x86/rte_memcpy.c b/lib/librte_eal/common/arch/x86/rte_memcpy.c
deleted file mode 100644
index 648c8f680..000000000
--- a/lib/librte_eal/common/arch/x86/rte_memcpy.c
+++ /dev/null
@@ -1,29 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2017 Intel Corporation
- */
-
-#include <rte_memcpy.h>
-#include <rte_cpuflags.h>
-#include <rte_log.h>
-
-void *(*rte_memcpy_ptr)(void *dst, const void *src, size_t n) = NULL;
-
-RTE_INIT(rte_memcpy_init)
-{
-#ifdef CC_SUPPORT_AVX512F
-	if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F)) {
-		rte_memcpy_ptr = rte_memcpy_avx512f;
-		RTE_LOG(DEBUG, EAL, "AVX512 memcpy is using!\n");
-		return;
-	}
-#endif
-#ifdef CC_SUPPORT_AVX2
-	if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2)) {
-		rte_memcpy_ptr = rte_memcpy_avx2;
-		RTE_LOG(DEBUG, EAL, "AVX2 memcpy is using!\n");
-		return;
-	}
-#endif
-	rte_memcpy_ptr = rte_memcpy_sse;
-	RTE_LOG(DEBUG, EAL, "Default SSE/AVX memcpy is using!\n");
-}
-- 
2.19.0

Re: [dpdk-dev] [PATCH] eal/x86: remove unused memcpy file

[Ferruh Yigit]

On 11/9/2018 1:46 PM, Thomas Monjalon wrote:
> The use of rte_memcpy_ptr was removed in revert below,
> but it was missing removing the file arch/x86/rte_memcpy.c.
> 
> Fixes: d35cc1fe6a7a ("eal/x86: revert select optimized memcpy at run-time")
> Cc: stable@dpdk.org
> Cc: xiaoyun.li@intel.com
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/x86: remove unused memcpy file

[Thomas Monjalon]

09/11/2018 18:35, Ferruh Yigit:
> On 11/9/2018 1:46 PM, Thomas Monjalon wrote:
> > The use of rte_memcpy_ptr was removed in revert below,
> > but it was missing removing the file arch/x86/rte_memcpy.c.
> > 
> > Fixes: d35cc1fe6a7a ("eal/x86: revert select optimized memcpy at run-time")
> > Cc: stable@dpdk.org
> > Cc: xiaoyun.li@intel.com
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied