From: Thomas Monjalon <thomas@monjalon.net>
To: "yskoh@mellanox.com" <yskoh@mellanox.com>
Cc: dev@dpdk.org, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"pbhagavatula@marvell.com" <pbhagavatula@marvell.com>,
"shahafs@mellanox.com" <shahafs@mellanox.com>,
"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Dharmik Thakkar <Dharmik.Thakkar@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v3] build: disable armv8 crypto extension
Date: Tue, 04 Jun 2019 01:11:26 +0200 [thread overview]
Message-ID: <14058418.BnuyAWlf4k@xps> (raw)
In-Reply-To: <VE1PR08MB5149BA92DD6CCA07CA8842CD980F0@VE1PR08MB5149.eurprd08.prod.outlook.com>
13/05/2019 21:26, Honnappa Nagarahalli:
> >
> > Per armv8 crypto extension support, make build always enable it by default as
> > long as compiler supports the feature while meson build only enables it for
> > 'default' machine of generic armv8 architecture.
> >
> > It is known that not all the armv8 platforms have the crypto extension. For
> > example, Mellanox BlueField has a variant which doesn't have it. If crypto
> > enabled binary runs on such a platform, rte_eal_init() fails.
> >
> > '+crypto' flag currently implies only '+aes' and '+sha2' and enabling it will
> > generate the crypto instructions only when crypto intrinsics are used.
> > For the devices supporting 8.2 crypto or newer, compiler could generate such
> > instructions beyond intrinsics or asm code. For example, compiler can generate
> > 3-way exclusive OR instructions if sha3 is supported. However, it has to be
> > enabled by adding '+sha3' as of today.
> >
> > In DPDK, armv8 cryptodev is the only one which requires the crypto support.
> > As it even uses external library of Marvell which is compiled out of DPDK with
> > crypto support and there's run-time check for required cpuflags, crypto
> > support can be disabled in DPDK.
> >
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> > Tested-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Applied, thanks
prev parent reply other threads:[~2019-06-03 23:11 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 1:58 [dpdk-dev] [PATCH 1/2] build: add option for " Yongseok Koh
2019-05-02 1:58 ` Yongseok Koh
2019-05-02 1:58 ` [dpdk-dev] [PATCH 2/2] mk: disable armv8 crypto extension for Mellanox BlueField Yongseok Koh
2019-05-02 1:58 ` Yongseok Koh
2019-05-02 4:12 ` Honnappa Nagarahalli
2019-05-02 4:12 ` Honnappa Nagarahalli
2019-05-02 5:40 ` Yongseok Koh
2019-05-02 5:40 ` Yongseok Koh
2019-05-03 4:01 ` Honnappa Nagarahalli
2019-05-03 4:01 ` Honnappa Nagarahalli
2019-05-02 4:13 ` [dpdk-dev] [PATCH 1/2] build: add option for armv8 crypto extension Honnappa Nagarahalli
2019-05-02 4:13 ` Honnappa Nagarahalli
2019-05-02 5:46 ` Yongseok Koh
2019-05-02 5:46 ` Yongseok Koh
2019-05-02 10:00 ` Jerin Jacob Kollanukkaran
2019-05-02 10:00 ` Jerin Jacob Kollanukkaran
2019-05-03 3:57 ` Honnappa Nagarahalli
2019-05-03 3:57 ` Honnappa Nagarahalli
2019-05-03 9:57 ` Yongseok Koh
2019-05-03 9:57 ` Yongseok Koh
2019-05-03 12:28 ` [dpdk-dev] [PATCH v2] build: disable " Yongseok Koh
2019-05-03 12:28 ` Yongseok Koh
2019-05-03 15:02 ` Honnappa Nagarahalli
2019-05-03 15:02 ` Honnappa Nagarahalli
2019-05-03 16:10 ` Honnappa Nagarahalli
2019-05-03 16:10 ` Honnappa Nagarahalli
2019-05-03 17:50 ` Yongseok Koh
2019-05-03 17:50 ` Yongseok Koh
2019-05-06 21:46 ` [dpdk-dev] [dpdk-stable] " Yongseok Koh
2019-05-06 21:46 ` Yongseok Koh
2019-05-07 7:59 ` Jerin Jacob Kollanukkaran
2019-05-07 7:59 ` Jerin Jacob Kollanukkaran
2019-05-07 11:03 ` Honnappa Nagarahalli
2019-05-07 11:03 ` Honnappa Nagarahalli
2019-05-07 12:02 ` Jerin Jacob Kollanukkaran
2019-05-07 12:02 ` Jerin Jacob Kollanukkaran
2019-05-03 22:13 ` [dpdk-dev] " Dharmik Thakkar
2019-05-03 22:13 ` Dharmik Thakkar
2019-05-06 21:41 ` Yongseok Koh
2019-05-06 21:41 ` Yongseok Koh
2019-05-07 21:11 ` [dpdk-dev] [PATCH v3] " Yongseok Koh
2019-05-07 21:11 ` Yongseok Koh
2019-05-13 19:26 ` Honnappa Nagarahalli
2019-05-13 19:26 ` Honnappa Nagarahalli
2019-06-03 23:11 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14058418.BnuyAWlf4k@xps \
--to=thomas@monjalon.net \
--cc=Dharmik.Thakkar@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=pbhagavatula@marvell.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).