From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 3C0BB678C for ; Fri, 26 Sep 2014 14:40:08 +0200 (CEST) Received: by mail-wg0-f52.google.com with SMTP id n12so7746440wgh.11 for ; Fri, 26 Sep 2014 05:46:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=lJJwb1xnv7JpltXOoWkrDqYo1GWG6VmSWMWCuVyX2ec=; b=W5JhZV/JiSbry0GV105Z2CSUr9E/GFPL3ql3C4ytH5dUjcFc8rZ7+HF0+QjfEMEA8j c8+X1FFPcvP3u4un9W3ivPbIAFiicLRtYecOt9tLHfpV8HPGIHWQ4G0ZkPh3ulYDkaxh eiGSFc5v75phO1br9FpaNU7Q+OekZNk0i1uBrFVblDNGS+7M3wjARQn3aE8olNNHSF0x 93v0RhVsiu9+IoKbymT3uSoqU8t04ztxSHo8fu2e+ZXuEZzsPnKKhzGdIx5xSIq+q+E5 H+dc/HZ2PD7hqKG2Hazcz4rJXQSnYAAy1yVq8/6Ry2PPCueyd8zlC9svbN5rdCKL6K4Q X1dA== X-Gm-Message-State: ALoCoQlQGa5xA94+f8hdZlR6SfdIqU3Yjz9dYvUnd7Gyo8xozhdXDh3hdaOz77b6yGRQU+0WG//d X-Received: by 10.194.24.169 with SMTP id v9mr3937654wjf.114.1411735590411; Fri, 26 Sep 2014 05:46:30 -0700 (PDT) Received: from localhost.localdomain (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ic7sm2090078wid.11.2014.09.26.05.46.29 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 26 Sep 2014 05:46:29 -0700 (PDT) From: Thomas Monjalon To: dev@dpdk.org Date: Fri, 26 Sep 2014 14:46:14 +0200 Message-Id: <1411735574-3703-1-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.0.4 Subject: [dpdk-dev] [PATCH] ixgbe: allow unsupported SFP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Sep 2014 12:40:08 -0000 No need to restrict usage of non Intel SFP. If (hw->phy.type == ixgbe_phy_sfp_intel) is false, a warning will be logged. It was disabled for ixgbe and enabled but unused for i40e. Signed-off-by: Thomas Monjalon --- config/common_bsdapp | 2 -- config/common_linuxapp | 2 -- lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 2 -- 3 files changed, 6 deletions(-) diff --git a/config/common_bsdapp b/config/common_bsdapp index 645949f..eebd05b 100644 --- a/config/common_bsdapp +++ b/config/common_bsdapp @@ -167,7 +167,6 @@ CONFIG_RTE_LIBRTE_IXGBE_DEBUG_TX_FREE=n CONFIG_RTE_LIBRTE_IXGBE_DEBUG_DRIVER=n CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n CONFIG_RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC=y -CONFIG_RTE_LIBRTE_IXGBE_ALLOW_UNSUPPORTED_SFP=n CONFIG_RTE_IXGBE_INC_VECTOR=n CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE=n @@ -182,7 +181,6 @@ CONFIG_RTE_LIBRTE_I40E_DEBUG_TX_FREE=n CONFIG_RTE_LIBRTE_I40E_DEBUG_DRIVER=n CONFIG_RTE_LIBRTE_I40E_PF_DISABLE_STRIP_CRC=y CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=n -CONFIG_RTE_LIBRTE_I40E_ALLOW_UNSUPPORTED_SFP=y CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4 # interval up to 8160 us, aligned to 2 (or default value) diff --git a/config/common_linuxapp b/config/common_linuxapp index 5bee910..4713eb4 100644 --- a/config/common_linuxapp +++ b/config/common_linuxapp @@ -190,7 +190,6 @@ CONFIG_RTE_LIBRTE_IXGBE_DEBUG_TX_FREE=n CONFIG_RTE_LIBRTE_IXGBE_DEBUG_DRIVER=n CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n CONFIG_RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC=y -CONFIG_RTE_LIBRTE_IXGBE_ALLOW_UNSUPPORTED_SFP=n CONFIG_RTE_IXGBE_INC_VECTOR=y CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=y @@ -205,7 +204,6 @@ CONFIG_RTE_LIBRTE_I40E_DEBUG_TX_FREE=n CONFIG_RTE_LIBRTE_I40E_DEBUG_DRIVER=n CONFIG_RTE_LIBRTE_I40E_PF_DISABLE_STRIP_CRC=n CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y -CONFIG_RTE_LIBRTE_I40E_ALLOW_UNSUPPORTED_SFP=n CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=n CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4 # interval up to 8160 us, aligned to 2 (or default value) diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c index f4b590b..a147d46 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c @@ -727,9 +727,7 @@ eth_ixgbe_dev_init(__attribute__((unused)) struct eth_driver *eth_drv, hw->device_id = pci_dev->id.device_id; hw->vendor_id = pci_dev->id.vendor_id; hw->hw_addr = (void *)pci_dev->mem_resource[0].addr; -#ifdef RTE_LIBRTE_IXGBE_ALLOW_UNSUPPORTED_SFP hw->allow_unsupported_sfp = 1; -#endif /* Initialize the shared code (base driver) */ #ifdef RTE_NIC_BYPASS -- 2.0.4