From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.digiweb.ie (smtp2.digiweb.ie [83.147.160.14]) by dpdk.org (Postfix) with ESMTP id F048B959 for ; Sat, 4 Oct 2014 21:12:56 +0200 (CEST) Received: from statler.emutex.com (unknown [92.51.199.138]) by smtp.digiweb.ie (Postfix) with ESMTP id 1094A290079 for ; Sat, 4 Oct 2014 20:19:57 +0100 (IST) Received: from 188-141-82-118.dynamic.upc.ie ([188.141.82.118] helo=localhost.localdomain) by statler.emutex.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XaUs0-0006TH-UA for dev@dpdk.org; Sat, 04 Oct 2014 20:19:56 +0100 From: =?UTF-8?q?Nicola=CC=81s=20Pernas=20Maradei?= To: dev@dpdk.org Date: Sat, 4 Oct 2014 20:19:51 +0100 Message-Id: <1412450391-32377-1-git-send-email-nico@emutex.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] testpmd: print message if starting/stopping queue is not supported X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Oct 2014 19:12:57 -0000 Print an error message to the user when trying to start/stop a rx/tx queue and this function is not supported by the PMD driver. The patch does not check if the return value is -EINVAL because testpmd is already validating the port and queue id. Signed-off-by: Nicolás Pernas Maradei --- app/test-pmd/cmdline.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 225f669..0b972f9 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1451,6 +1451,7 @@ cmd_config_rxtx_queue_parsed(void *parsed_result, struct cmd_config_rxtx_queue *res = parsed_result; uint8_t isrx; uint8_t isstart; + int ret = 0; if (test_done == 0) { printf("Please stop forwarding first\n"); @@ -1489,13 +1490,16 @@ cmd_config_rxtx_queue_parsed(void *parsed_result, } if (isstart && isrx) - rte_eth_dev_rx_queue_start(res->portid, res->qid); + ret = rte_eth_dev_rx_queue_start(res->portid, res->qid); else if (!isstart && isrx) - rte_eth_dev_rx_queue_stop(res->portid, res->qid); + ret = rte_eth_dev_rx_queue_stop(res->portid, res->qid); else if (isstart && !isrx) - rte_eth_dev_tx_queue_start(res->portid, res->qid); + ret = rte_eth_dev_tx_queue_start(res->portid, res->qid); else - rte_eth_dev_tx_queue_stop(res->portid, res->qid); + ret = rte_eth_dev_tx_queue_stop(res->portid, res->qid); + + if (ret == -ENOTSUP) + printf("Function not supported in PMD driver\n"); } cmdline_parse_token_string_t cmd_config_rxtx_queue_port = -- 1.9.1