From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 349842BA7 for ; Tue, 5 Mar 2019 11:00:54 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A369E22C8E; Tue, 5 Mar 2019 05:00:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 05 Mar 2019 05:00:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=z1xVTw8pl5w9zO/G0TUXlEdGRHWDxplRfPLhWlTLtGM=; b=XxPZaVbVYLOO nBBYpVBA+bpV7q5a+Kv6F7jOouzebBCIQ+WYoN/bwL/IGD/CP4oZPoYgv4eK8IAH oF/EFqYry0RycnTglGC+PsmzF35t8JD7J1EjqY8akRro1Pm7fdOaC2lO+E4YjgMp pW89iH++aYSuz0UOWiJn9V3IGMCESWQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=z1xVTw8pl5w9zO/G0TUXlEdGRHWDxplRfPLhWlTLt GM=; b=VWkDZqtmj0qM8u6FIBuCuMMfY5l9ZKe1f+DrbWr8liPpksgZhLkSX27uO DOY45yD07oK2lOk2opB6p8PReaWYWOAa06TAc+JYBJPQSV3PQvdXMkArWvG+qu18 c/eje89B7h7bMeUcuYMsKsxa6zaN39rYjIbKPdQmOmJDM1C3foQCCk0ySSE5AIy0 E26LG5MGB1iNWQI1TvmTcYwwUurv14RnqhjlWBsZTRHyV3CiPnnci5dg4FBI4EWF 2jwyXRUw4ibzXab6ve7SjLXS8IUQnYHS4OnzUBJyafbp5JOE7lmUtAmqb6lPhoBH PbL8xMTQFVvSvAg4o1wvDBuWUDqZA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfeefgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgepud X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 25560E4307; Tue, 5 Mar 2019 05:00:52 -0500 (EST) From: Thomas Monjalon To: Raslan Darawsheh Cc: Stephen Hemminger , "gaetan.rivet@6wind.com" , "dev@dpdk.org" Date: Tue, 05 Mar 2019 11:00:50 +0100 Message-ID: <14127814.HFQHTULaMT@xps> In-Reply-To: References: <1551368952-1871-1-git-send-email-rasland@mellanox.com> <20190228092434.20685ac8@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 10:00:54 -0000 05/03/2019 10:33, Raslan Darawsheh: > Hi Stephen, > > From: Stephen Hemminger > > On Thu, 28 Feb 2019 15:49:28 +0000 > > Raslan Darawsheh wrote: > > > > > + eth_dev->rx_pkt_burst = > > (eth_rx_burst_t)&failsafe_rx_burst; > > > + eth_dev->tx_pkt_burst = > > (eth_tx_burst_t)&failsafe_tx_burst; > > > > Why is cast necessary here. The function signature should match. > > I don't think it's necessary, but this is the same as the primary process implementation If it's not necessary, better to not add them. Don't worry about consistency for pointer casting :)