From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 97A3BC5CC for ; Fri, 29 Jan 2016 10:55:00 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id l66so46842966wml.0 for ; Fri, 29 Jan 2016 01:55:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=1zHiFbk1WEz4U92k+jIDQFqiEH9JhfMagsW5ygEoluk=; b=oW6OBEZB/pmXHZV0GFEWbwvHYxSgIRw6snSjxnSjAfbmZZxSPwNAc2PfFsw2DbattK Ol14HFPTkp/0tMvFK4ySw6ToWc1ql3iBH/9x7ROQXP+Uk4fI7RC8NZJBRldoHR2kauHX jtMLWWKdoyNx/gGuqWfEqXoN1Bzl2ajvHVXg6XsQdMLducaAXIkTw9/9l/WlkDzObRO0 aJpJf/lQkIinaupjB2yOvVFwFB/d7U5wBERYIM5nOLwbudBWjhDFMxg+05hIM3OC4D/O BhfGrT9BngsPl6UXG4fME31zTapHcIVbAui+YH5xWb5UJkzjENqP4773ta4W3pRsQH2P neAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=1zHiFbk1WEz4U92k+jIDQFqiEH9JhfMagsW5ygEoluk=; b=V9DAZT8ycK8OZYAmfhYqGZJ4SJ6IQJK/Bw2K6uIAcE6z4FRY1o1mKELaivE3owx1Dt 1wMpiRPXtAUL7Cdrxtp2gHxUd8doaPCfVACUm9TAcfagZFXwif+mDzBFOwGDw4PMYS8s u9IMgBDl4KQDgHJkP2fj9BpXi3F6WW4P6W9HEydnCBzRSxa/tJHueWMjamoHW7F15LLV aUnE46ucaotpFWkJ9LJrgWnXXDbceTRfOjlqKkq+5c9jqxV+YlJlmGNYd3pVYUnaArdT 1a60HkX7CJjEEFRtJ0emjrIRsnWTqGIcm92lduU0jH3Gov2sOsueSaH610yCuCIvp2gl wnMw== X-Gm-Message-State: AG10YOS/NZs2K/FUjd7lWXFNuXZqwzJrIrEDuQo6Os3HH7ijgNKKchly84yyAzMRuQyrFobH X-Received: by 10.194.116.71 with SMTP id ju7mr8777678wjb.2.1454061300460; Fri, 29 Jan 2016 01:55:00 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id q73sm4539774wmb.1.2016.01.29.01.54.59 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 29 Jan 2016 01:54:59 -0800 (PST) From: Thomas Monjalon To: "Ananyev, Konstantin" Date: Fri, 29 Jan 2016 10:53:47 +0100 Message-ID: <14139435.dXsMv1AF6J@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB97725836B000EC@irsmsx105.ger.corp.intel.com> References: <1445810400-8978-1-git-send-email-marcdevel@gmail.com> <1745156.01DTmyzyO8@xps13> <2601191342CEEE43887BDE71AB97725836B000EC@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v7 3/5] ethdev: redesign link speed config API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2016 09:55:00 -0000 2016-01-29 09:47, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-01-29 09:24, Ananyev, Konstantin: > > > Can you avoid modifications in the e1000/base code? > > > We do not modify (and maintain) that part on our own. > > > Instead we take it straight from Intel ND. > > > So if you feel like these changes are really necessary - please submit a patch > > > to ND first, and if your changes will be applied, will pick it up from them. > > > > I was not aware we can submit a change to ND for Intel base drivers. > > What is the procedure please? > > I meant not to the ND directly, but probably to the freebsd e1000 kernel driver. > As I remember, that is the closest one to what we have. > From my understanding (I might be wrong here): > If they will be accepted, we should see these changes In next code drops from ND. These base drivers are used in several places. We are allowed to submit a patch in Linux or FreeBSD but not in DPDK where the base driver is verbatim? We have an agreement to not touch them in DPDK but I still think the ND team could consider some patches from dpdk.org.