From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 33CC468BF for ; Thu, 18 Dec 2014 12:32:08 +0100 (CET) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1Y1ZJM-0003iO-64; Thu, 18 Dec 2014 06:32:06 -0500 From: Neil Horman To: dev@dpdk.org Date: Thu, 18 Dec 2014 06:31:56 -0500 Message-Id: <1418902316-30266-1-git-send-email-nhorman@tuxdriver.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1418835808-18803-1-git-send-email-nhorman@tuxdriver.com> References: <1418835808-18803-1-git-send-email-nhorman@tuxdriver.com> X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: [dpdk-dev] [PATCH v2] xenvirt: Fix build break on cmdline_parse_etheraddr call X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2014 11:32:08 -0000 Back in: commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db Author: Alan Carew Date: Fri Dec 5 15:19:07 2014 +0100 cmdline: fix overflow on bsd The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. This patch makes the needed correction to avoid a build break Signed-off-by: Neil Horman CC: Thomas Monjalon CC: Olivier Matz --- Change notes v2: Changed sizeof(struct ether_addr) to sizeof(dict->addr) --- lib/librte_pmd_xenvirt/rte_eth_xenvirt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c index 6555ec5..04e30c9 100644 --- a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c +++ b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c @@ -586,8 +586,9 @@ rte_eth_xenvirt_parse_args(struct xenvirt_dict *dict, if (!strncmp(pair[0], RTE_ETH_XENVIRT_MAC_PARAM, sizeof(RTE_ETH_XENVIRT_MAC_PARAM))) { if (cmdline_parse_etheraddr(NULL, - pair[1], - &dict->addr) < 0) { + pair[1], + &dict->addr, + sizeof(dict->addr)) < 0) { RTE_LOG(ERR, PMD, "Invalid %s device ether address\n", name); -- 1.9.3