From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id AE09F5A15 for ; Thu, 22 Jan 2015 00:36:46 +0100 (CET) Received: by mail-wi0-f176.google.com with SMTP id em10so20514553wid.3 for ; Wed, 21 Jan 2015 15:36:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/2h0OTTRmnhOsAeCH0/EFXXWCL4OrCAioj4p1CQDwH4=; b=h0/n1xILMe2ufwVEqY3G+8JOvKL2zy9d9qFpMYJKKGhPq2hflvn2dUjSnOVPPQdgSx j57owlW+07XTo2YqknXGB0zVlItZqqJV44fVapSv3D+CAq5IH1se0YqsNpNivB/mXand 6Ki++Wl0/ytyDjwOJmf8rUgivewVgyX8U6JnbaE/qk9vne5JrjyRbr61Br1N2tZ/qVIr Wz3IHyo2lEwFkgGcL4041w/E47ZLZTlU6w/iYShnqnQBXF1UP92Z7mKwKhhpTInGGZmT kxB4X1spbMtM1RlL3u56eQOm/w8jFUrPjBvwgBajuuTHLHEAmCh7unGYTB1FXyY/364j Pnzw== X-Gm-Message-State: ALoCoQl6YMtAkWznKUXLt8mcVN2WTamcth8aKcPbauuLbXExJ57RxX9KAtKtTlzE8lF1cLMA7nSI X-Received: by 10.180.75.102 with SMTP id b6mr16123140wiw.34.1421883406502; Wed, 21 Jan 2015 15:36:46 -0800 (PST) Received: from glumotte.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id wa5sm1710761wjc.8.2015.01.21.15.36.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Jan 2015 15:36:45 -0800 (PST) From: Olivier Matz To: dev@dpdk.org Date: Thu, 22 Jan 2015 00:36:19 +0100 Message-Id: <1421883395-27235-1-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.1.3 Subject: [dpdk-dev] [RFC 00/16] enhance checksum offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2015 23:36:46 -0000 The goal of this series is to clarify and simplify the mbuf offload API. Several issues are solved: - simplify the definitions of PKT_TX_IP_CKSUM and PKT_TX_IPV4, each flag has now only one meaning. No impact on the code. - add a feature flag for OUTER_IP_CHECKSUM (from Jijiang's patches) - remove the PKT_TX_UDP_TUNNEL_PKT flag: it is useless from an API point of view. It was added because i40e need this info for some reason. We have 3 solutions: - remove the flag and adapt the driver to the API (the choice I made for this series). - remove the flag and stop advertising OUTER_IP_CHECKSUM in i40e - keep this flag, penalizing performance of drivers that do not require the flag. It would also mean that drivers won't support outer IP checksum for all tunnel types, but only for the tunnel types having a flag. - a side effect of this API clarification is that there is only one way for doing one operation. If the hardware has several ways to do the same operation, a choice has to be made in the driver. The patch adds new tunnel types to testpmd csum forward engine. Note: the i40e patches should be carefully checked by i40e experts. [1] http://dpdk.org/ml/archives/dev/2015-January/011127.html Jijiang Liu (2): ethdev: add outer IP offload capability flag i40e: advertise outer IPv4 checksum capability Olivier Matz (14): mbuf: remove PKT_TX_IPV4_CSUM mbuf: enhance the API documentation of offload flags i40e: call i40e_txd_enable_checksum only for offloaded packets i40e: remove the use of PKT_TX_UDP_TUNNEL_PKT flag mbuf: remove PKT_TX_UDP_TUNNEL_PKT flag testpmd: replace tx_checksum command by csum testpmd: move csum_show in a function testpmd: add csum parse_tunnel command testpmd: rename vxlan in outer_ip in csum commands testpmd: introduce parse_ipv* in csum fwd engine testpmd: use a structure to store offload info in csum fwd engine testpmd: introduce parse_vxlan in csum fwd engine testpmd: support gre tunnels in csum fwd engine testpmd: support ipip tunnel in csum forward engine app/test-pmd/cmdline.c | 228 ++++++++++++++------- app/test-pmd/csumonly.c | 416 +++++++++++++++++++++++++------------- app/test-pmd/testpmd.h | 9 +- lib/librte_ether/rte_ethdev.h | 1 + lib/librte_mbuf/rte_mbuf.c | 1 - lib/librte_mbuf/rte_mbuf.h | 49 +++-- lib/librte_pmd_i40e/i40e_ethdev.c | 3 +- lib/librte_pmd_i40e/i40e_rxtx.c | 23 ++- 8 files changed, 490 insertions(+), 240 deletions(-) -- 2.1.3