From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f169.google.com (mail-we0-f169.google.com [74.125.82.169]) by dpdk.org (Postfix) with ESMTP id C48BA5A97 for ; Thu, 22 Jan 2015 00:36:49 +0100 (CET) Received: by mail-we0-f169.google.com with SMTP id p10so22492179wes.0 for ; Wed, 21 Jan 2015 15:36:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qurygHjZVeF3I5km7qyyWlCjBPV249rMC4DgH9lJYlg=; b=hMV0Uetv/JUuSUBH1B1PCFBGrqbIRGAZkcNWiPZZVeNeHhQdqETvy45eHI0YDrg2dy /3G4vVIi4zuTS8bWOQpFcyVpd+zaJ/jKbnEfLsh2aCnENe+DG9P/1J6k+tEzJixNBti1 F3+PG35Xvr+M1gukrc1r3i2xBymmDRKvETbOE2eQMWWJJSE4dp3hQPwPJ98zFoUL7zNm ZOqy46r3tQ1iDkdOkoGxfJWw8E+KGE4157tIy3+uYNQpb9G0sUHxrL7QsmNiG+bueqy3 +x8x6LdpMV8gdqjrBD3nW8FUoCHTWHHfnU0dHTWA+VUfGRKNzwonQtEh0ul3fWfBI/tL d97g== X-Gm-Message-State: ALoCoQl8GQng4vdN57KR3wJjy5fHChYv177vB9qj/ncrFkGcslMRPA3iGdiBMWdJQY+2Sjvsw/0k X-Received: by 10.181.28.168 with SMTP id jp8mr50149700wid.40.1421883409672; Wed, 21 Jan 2015 15:36:49 -0800 (PST) Received: from glumotte.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id wa5sm1710761wjc.8.2015.01.21.15.36.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Jan 2015 15:36:49 -0800 (PST) From: Olivier Matz To: dev@dpdk.org Date: Thu, 22 Jan 2015 00:36:22 +0100 Message-Id: <1421883395-27235-4-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1421883395-27235-1-git-send-email-olivier.matz@6wind.com> References: <1421883395-27235-1-git-send-email-olivier.matz@6wind.com> Subject: [dpdk-dev] [RFC 03/16] i40e: call i40e_txd_enable_checksum only for offloaded packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2015 23:36:50 -0000 >>From i40e datasheet: The IP header type and its offload. In case of tunneling, the IIPT relates to the inner IP header. See also EIPT field for the outer (External) IP header offload. 00 - non IP packet or packet type is not defined by software 01 - IPv6 packet 10 - IPv4 packet with no IP checksum offload 11 - IPv4 packet with IP checksum offload Therefore it is not needed to fill the IIPT field if no offload is requested (we can keep the value to 00). For instance, the linux driver code does not set it when (skb->ip_summed != CHECKSUM_PARTIAL). We can do the same in the dpdk driver. The function i40e_txd_enable_checksum() that fills the offload registers can only be called for packets requiring an offload. Signed-off-by: Olivier Matz --- lib/librte_pmd_i40e/i40e_rxtx.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c index 8e9df96..9acdeee 100644 --- a/lib/librte_pmd_i40e/i40e_rxtx.c +++ b/lib/librte_pmd_i40e/i40e_rxtx.c @@ -74,6 +74,11 @@ #define I40E_TXD_CMD (I40E_TX_DESC_CMD_EOP | I40E_TX_DESC_CMD_RS) +#define I40E_TX_CKSUM_OFFLOAD_MASK ( \ + PKT_TX_IP_CKSUM | \ + PKT_TX_L4_MASK | \ + PKT_TX_OUTER_IP_CKSUM) + #define RTE_MBUF_DATA_DMA_ADDR_DEFAULT(mb) \ (uint64_t) ((mb)->buf_physaddr + RTE_PKTMBUF_HEADROOM) @@ -1272,10 +1277,12 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) /* Enable checksum offloading */ cd_tunneling_params = 0; - i40e_txd_enable_checksum(ol_flags, &td_cmd, &td_offset, - l2_len, l3_len, outer_l2_len, - outer_l3_len, - &cd_tunneling_params); + if (ol_flags & I40E_TX_CKSUM_OFFLOAD_MASK) { + i40e_txd_enable_checksum(ol_flags, &td_cmd, &td_offset, + l2_len, l3_len, outer_l2_len, + outer_l3_len, + &cd_tunneling_params); + } if (unlikely(nb_ctx)) { /* Setup TX context descriptor if required */ -- 2.1.3