From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 65134B3D4 for ; Wed, 4 Feb 2015 23:24:06 +0100 (CET) Received: by mail-wg0-f51.google.com with SMTP id k14so4343248wgh.10 for ; Wed, 04 Feb 2015 14:24:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=ViAdtcVp79bTO+4C4FI+uI6xHyxYjw+y4SE6cm3g7NQ=; b=biwkDNyw3oKU/699/UNQum9G51QOjmrP81yPz9OQLe2V0MdkY8j5YpxJE41J8HUaEe Z09+CCKra8C2mO8ohZn4qlOCTXVYISxTAnLdyEnxF+8ymVeJU4izycf+ZkWKA97RRIM0 WPD6vgJ8DZL3spit/wGxv7/MyREOHgwyUStIOuOJrr+ObXCeI6TSjgaWamUrAznZm9ty c5EHJXRktWL6dqJjlra9lV3oK0Jx+lN5EhnEgQq1jm7p4GS7jEkxlFqlPWZJlweo+VlT bGGY5tUsqQU923+A76V46R0gy0Cxop1gC9wfmIW9COCgH0CpqVqyCdtpEBXgV1r7OtHB h4zA== X-Gm-Message-State: ALoCoQm2TBYbOAYLZhzX29S21mn0LfVeHeSvXOvmCQ3yxj9Jo8P9E4AhExtTSWpPSrLP0icE6/0+ X-Received: by 10.194.239.72 with SMTP id vq8mr1181174wjc.110.1423088646304; Wed, 04 Feb 2015 14:24:06 -0800 (PST) Received: from XPS13.localdomain (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by mx.google.com with ESMTPSA id q4sm5102476wiz.4.2015.02.04.14.24.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 04 Feb 2015 14:24:05 -0800 (PST) From: Thomas Monjalon To: dev@dpdk.org Date: Wed, 4 Feb 2015 23:23:24 +0100 Message-Id: <1423088604-29274-4-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.2.2 In-Reply-To: <1423088604-29274-1-git-send-email-thomas.monjalon@6wind.com> References: <1423088604-29274-1-git-send-email-thomas.monjalon@6wind.com> Subject: [dpdk-dev] [PATCH 3/3] scripts: check wrong patterns in maintainers file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Feb 2015 22:24:06 -0000 Each F or X pattern is checked and printed if there is no match with a file in the repository. The wildcard must be temporarily replaced to prevent from shell expansion. Signed-off-by: Thomas Monjalon --- scripts/check-maintainers.sh | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/scripts/check-maintainers.sh b/scripts/check-maintainers.sh index 2687cad..e62217e 100755 --- a/scripts/check-maintainers.sh +++ b/scripts/check-maintainers.sh @@ -88,6 +88,20 @@ parse_fx () # done } +# Check patterns in F: and X: +check_fx () # +{ + IFS=' +' + for line in $(sed -n 's,^[FX]: ,,p' $1 | tr '*' '#') ; do + line=$(printf "$line" | tr '#' '*') + match=$(files "$line") + if [ -z "$match" ] ; then + echo "$line" + fi + done +} + # Add a line to a set of lines if it begins with right pattern add_line_to_if () # { @@ -112,6 +126,10 @@ echo '# files not listed' echo '##########' aminusb "$all" "$listed" -# TODO: check patterns that match nothing +echo '##########' +echo '# wrong patterns' +echo '##########' +check_fx MAINTAINERS + # TODO: check overlaps # TODO: check orphan areas -- 2.2.2