From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from paradis.irqsave.net (LPuteaux-656-1-25-125.w80-12.abo.wanadoo.fr [80.12.84.125]) by dpdk.org (Postfix) with ESMTP id E6180376E for ; Fri, 27 Feb 2015 11:22:48 +0100 (CET) Received: from localhost.localdomain (laure.irqsave.net [192.168.77.2]) by paradis.irqsave.net (Postfix) with ESMTP id BD04511E625; Fri, 27 Feb 2015 11:22:48 +0100 (CET) From: =?UTF-8?q?Beno=C3=AEt=20Canet?= To: dev@dpdk.org Date: Fri, 27 Feb 2015 11:22:45 +0100 Message-Id: <1425032565-497-1-git-send-email-benoit.canet@nodalink.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: =?UTF-8?q?Beno=C3=AEt=20Canet?= Subject: [dpdk-dev] [PATCH] vhost: Add a hint on how to add or remove the device to a data core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2015 10:22:49 -0000 Let's make sure people will not forget to set and unset VIRTIO_DEV_RUNNING. Signed-off-by: Benoît Canet --- doc/guides/prog_guide/vhost_lib.rst | 3 ++- lib/librte_vhost/rte_virtio_net.h | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst index 0b6eda7..ba6065d 100644 --- a/doc/guides/prog_guide/vhost_lib.rst +++ b/doc/guides/prog_guide/vhost_lib.rst @@ -58,7 +58,8 @@ Vhost API Overview register two callbacks, new_destory and destroy_device. When virtio device is activated or deactivated by guest virtual machine, the callback will be called, then vSwitch could put the device onto data - core or remove the device from data core. + core or remove the device from data core by setting or unsetting + VIRTIO_DEV_RUNNING on the device flags. * Read/write packets from/to guest virtual machine diff --git a/lib/librte_vhost/rte_virtio_net.h b/lib/librte_vhost/rte_virtio_net.h index 611a3d4..b9d34c7 100644 --- a/lib/librte_vhost/rte_virtio_net.h +++ b/lib/librte_vhost/rte_virtio_net.h @@ -130,6 +130,10 @@ struct virtio_memory { /** * Device operations to add/remove device. + * + * Make sure to set VIRTIO_DEV_RUNNING to the device flags in new_device and + * remove it in destroy_device. + * */ struct virtio_net_device_ops { int (*new_device)(struct virtio_net *); /**< Add device. */ -- 2.1.4