From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 3CE9D9AAC for ; Tue, 10 Mar 2015 17:13:51 +0100 (CET) Received: by pabrd3 with SMTP id rd3so3440553pab.5 for ; Tue, 10 Mar 2015 09:13:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Jg9A+RjzdydX0CMdg4LJRHsMG9CePGnr/rlbzO05uCA=; b=SCOeP3m529ET3ZmfM5F+cSp+xh1jbn04P480DZ+1P8+LTzqT4Tca449aWEXoERfhA4 i/W1rUHv3qVAzGvs3UD8ID2cIVZXLuLAzx0CXAtJAREAFxt1YKkYTX2atzK2/FYzwWcn +yWY7KDXbRT6tXYPGa/Oyk0elFzt/guD3cNtHR+ed0J5bWLmSv1egVUPRMEp3QQWGaRm 5L5zfxkFPQH6tz8riT7V63PZ3YHX6NCP6gNnUiLF7ChApb1cLVnEW8eokATJ8mlcII0m yiFEdvVXVSJuhqJMH87c4pwE0vtlvfrGUEIH2+qWRR3OYR7T9KIFNvLLvaRdIW8Xw7K5 v2tg== X-Gm-Message-State: ALoCoQkqv43HOynsYfcYZwIcTbVRIRnor1XHbqO1jtRGhyHRtNCYhcWVnjYgIK2W13CQwvDYq9xM X-Received: by 10.70.33.3 with SMTP id n3mr33680765pdi.132.1426004030469; Tue, 10 Mar 2015 09:13:50 -0700 (PDT) Received: from urahara.brocade.com (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id c8sm1836209pds.5.2015.03.10.09.13.49 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 10 Mar 2015 09:13:49 -0700 (PDT) From: Stephen Hemminger To: cristian.dumitrescu@intel.com Date: Tue, 10 Mar 2015 09:13:37 -0700 Message-Id: <1426004018-25948-6-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1426004018-25948-1-git-send-email-stephen@networkplumber.org> References: <1426004018-25948-1-git-send-email-stephen@networkplumber.org> Cc: dev@dpdk.org, Stephen Hemminger Subject: [dpdk-dev] [PATCH v2 5/6] rte_sched: allow reading statistics without clearing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2015 16:13:51 -0000 From: Stephen Hemminger The rte_sched statistics API should allow reading statistics without clearing. Make auto-clear optional. Signed-off-by: Stephen Hemminger --- v2 -- change to flag for clear from separate read/clear app/test/test_sched.c | 4 ++-- examples/qos_sched/stats.c | 16 +++++++++++----- lib/librte_sched/rte_sched.c | 44 ++++++++++++++++++++++---------------------- lib/librte_sched/rte_sched.h | 18 ++++++++++-------- 4 files changed, 45 insertions(+), 37 deletions(-) diff --git a/app/test/test_sched.c b/app/test/test_sched.c index 60c62de..3c9c9e3 100644 --- a/app/test/test_sched.c +++ b/app/test/test_sched.c @@ -208,13 +208,13 @@ test_sched(void) struct rte_sched_subport_stats subport_stats; uint32_t tc_ov; - rte_sched_subport_read_stats(port, SUBPORT, &subport_stats, &tc_ov); + rte_sched_subport_read_stats(port, SUBPORT, &subport_stats, &tc_ov, 1); #if 0 TEST_ASSERT_EQUAL(subport_stats.n_pkts_tc[TC-1], 10, "Wrong subport stats\n"); #endif struct rte_sched_queue_stats queue_stats; uint16_t qlen; - rte_sched_queue_read_stats(port, QUEUE, &queue_stats, &qlen); + rte_sched_queue_read_stats(port, QUEUE, &queue_stats, &qlen, 1); #if 0 TEST_ASSERT_EQUAL(queue_stats.n_pkts, 10, "Wrong queue stats\n"); #endif diff --git a/examples/qos_sched/stats.c b/examples/qos_sched/stats.c index b4db7b5..88caa54 100644 --- a/examples/qos_sched/stats.c +++ b/examples/qos_sched/stats.c @@ -61,7 +61,7 @@ qavg_q(uint8_t port_id, uint32_t subport_id, uint32_t pipe_id, uint8_t tc, uint8 average = 0; for (count = 0; count < qavg_ntimes; count++) { - rte_sched_queue_read_stats(port, queue_id, &stats, &qlen); + rte_sched_queue_read_stats(port, queue_id, &stats, &qlen, 1); average += qlen; usleep(qavg_period); } @@ -99,7 +99,9 @@ qavg_tcpipe(uint8_t port_id, uint32_t subport_id, uint32_t pipe_id, uint8_t tc) for (count = 0; count < qavg_ntimes; count++) { part_average = 0; for (i = 0; i < RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS; i++) { - rte_sched_queue_read_stats(port, queue_id + (tc * RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS + i), &stats, &qlen); + rte_sched_queue_read_stats(port, + queue_id + (tc * RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS + i), + &stats, &qlen, 1); part_average += qlen; } average += part_average / RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS; @@ -138,7 +140,8 @@ qavg_pipe(uint8_t port_id, uint32_t subport_id, uint32_t pipe_id) for (count = 0; count < qavg_ntimes; count++) { part_average = 0; for (i = 0; i < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE * RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS; i++) { - rte_sched_queue_read_stats(port, queue_id + i, &stats, &qlen); + rte_sched_queue_read_stats(port, queue_id + i, + &stats, &qlen, 1); part_average += qlen; } average += part_average / (RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE * RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS); @@ -178,7 +181,9 @@ qavg_tcsubport(uint8_t port_id, uint32_t subport_id, uint8_t tc) queue_id = RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE * RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS * (subport_id * port_params.n_pipes_per_subport + i); for (j = 0; j < RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS; j++) { - rte_sched_queue_read_stats(port, queue_id + (tc * RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS + j), &stats, &qlen); + rte_sched_queue_read_stats(port, + queue_id + (tc * RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS + j), + &stats, &qlen, 1); part_average += qlen; } } @@ -220,7 +225,8 @@ qavg_subport(uint8_t port_id, uint32_t subport_id) queue_id = RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE * RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS * (subport_id * port_params.n_pipes_per_subport + i); for (j = 0; j < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE * RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS; j++) { - rte_sched_queue_read_stats(port, queue_id + j, &stats, &qlen); + rte_sched_queue_read_stats(port, queue_id + j, + &stats, &qlen, 1); part_average += qlen; } } diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index 2071414..74d0e0a 100644 --- a/lib/librte_sched/rte_sched.c +++ b/lib/librte_sched/rte_sched.c @@ -909,56 +909,56 @@ rte_sched_pipe_config(struct rte_sched_port *port, int rte_sched_subport_read_stats(struct rte_sched_port *port, - uint32_t subport_id, - struct rte_sched_subport_stats *stats, - uint32_t *tc_ov) + uint32_t subport_id, + struct rte_sched_subport_stats *stats, + uint32_t *tc_ov, int clear) { struct rte_sched_subport *s; /* Check user parameters */ - if ((port == NULL) || - (subport_id >= port->n_subports_per_port) || - (stats == NULL) || - (tc_ov == NULL)) { + if (port == NULL || subport_id >= port->n_subports_per_port) return -1; - } + s = port->subport + subport_id; /* Copy subport stats and clear */ - memcpy(stats, &s->stats, sizeof(struct rte_sched_subport_stats)); - memset(&s->stats, 0, sizeof(struct rte_sched_subport_stats)); + if (stats) + *stats = s->stats; + if (clear) + memset(&s->stats, 0, sizeof(struct rte_sched_subport_stats)); /* Subport TC ovesubscription status */ - *tc_ov = s->tc_ov; + if (tc_ov) + *tc_ov = s->tc_ov; return 0; } int rte_sched_queue_read_stats(struct rte_sched_port *port, - uint32_t queue_id, - struct rte_sched_queue_stats *stats, - uint16_t *qlen) + uint32_t queue_id, + struct rte_sched_queue_stats *stats, + uint16_t *qlen, int clear) { struct rte_sched_queue *q; struct rte_sched_queue_extra *qe; /* Check user parameters */ - if ((port == NULL) || - (queue_id >= rte_sched_port_queues_per_port(port)) || - (stats == NULL) || - (qlen == NULL)) { + if (port == NULL || queue_id >= rte_sched_port_queues_per_port(port)) return -1; - } + q = port->queue + queue_id; qe = port->queue_extra + queue_id; /* Copy queue stats and clear */ - memcpy(stats, &qe->stats, sizeof(struct rte_sched_queue_stats)); - memset(&qe->stats, 0, sizeof(struct rte_sched_queue_stats)); + if (stats) + *stats = qe->stats; + if (clear) + memset(&qe->stats, 0, sizeof(struct rte_sched_queue_stats)); /* Queue length */ - *qlen = q->qw - q->qr; + if (qlen) + *qlen = q->qw - q->qr; return 0; } diff --git a/lib/librte_sched/rte_sched.h b/lib/librte_sched/rte_sched.h index e9bf18a..f0bf088 100644 --- a/lib/librte_sched/rte_sched.h +++ b/lib/librte_sched/rte_sched.h @@ -308,14 +308,15 @@ rte_sched_port_get_memory_footprint(struct rte_sched_port_params *params); * @param tc_ov * Pointer to pre-allocated 4-entry array where the oversubscription status for * each of the 4 subport traffic classes should be stored. + * @parm clear + * Reset statistics after read * @return * 0 upon success, error code otherwise */ int -rte_sched_subport_read_stats(struct rte_sched_port *port, - uint32_t subport_id, - struct rte_sched_subport_stats *stats, - uint32_t *tc_ov); +rte_sched_subport_read_stats(struct rte_sched_port *port, uint32_t subport_id, + struct rte_sched_subport_stats *stats, + uint32_t *tc_ov, int clear); /** * Hierarchical scheduler queue statistics read @@ -329,14 +330,15 @@ rte_sched_subport_read_stats(struct rte_sched_port *port, * counters should be stored * @param qlen * Pointer to pre-allocated variable where the current queue length should be stored. + * @parm clear + * Reset statistics after read * @return * 0 upon success, error code otherwise */ int -rte_sched_queue_read_stats(struct rte_sched_port *port, - uint32_t queue_id, - struct rte_sched_queue_stats *stats, - uint16_t *qlen); +rte_sched_queue_read_stats(struct rte_sched_port *port, uint32_t queue_id, + struct rte_sched_queue_stats *stats, + uint16_t *qlen, int clear); /* * Run-time -- 2.1.4