From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51E8BA0A0A; Sat, 23 Jan 2021 12:38:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE2CE140CCD; Sat, 23 Jan 2021 12:38:52 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id B453B140CCA for ; Sat, 23 Jan 2021 12:38:51 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 410EB5C0183; Sat, 23 Jan 2021 06:38:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 23 Jan 2021 06:38:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 2xBproTorlQSCthtxhIQ8m6X32nlEFH6pTiE9s4Qdwg=; b=PbiIhg64fbUqZQpr VHVKkBmikakmoBvZCdXFsm1rtSvIEgAWIJfzCZGDxOyurq9WJRuJHrDoj3ETVNQe i55hMacYQlgG5xbePPGpfh5gtqWteD0y6P3xcZnxYFjA/w+FVCHL9RH4qZmLP6ID uPLnchXGHaBp5cgFhMyJXHLp1A3yp85etJsfB9BZiIbK4Ap4sSqhPbqONr1abBY4 bFmC0cDkDPun6WPKI+qq9/E7Ud+ZdYEdKyKmXCxFgiNvv9rMZBXlGv38RO9O2Mdp j6iaR20PxN0rwB26SZQFXrRNfi2Dcv3+LXjctpkCMa2rIM8kzjWri7HmLQoWk7nY WoP8+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=2xBproTorlQSCthtxhIQ8m6X32nlEFH6pTiE9s4Qd wg=; b=I2NsQfNwoQomem0PWugWl52moTqHxqFQBfUu6/l8YbM0LsN+g8HBbPa7Z z8Vkz7MYJz+/Wd1y++v16sOhz++CH439jcs9jlYRQKzRhrxd4udI9RMdx6dMrLEf sMoLoPa0byqWU1/7dH5Vgs+4u8MHsbs2vHPjYyFL6frSp8HeE5xgGgtF8Cg301PH kMu3uguRH0+FY4qAXlznWHmqcD8+7JTDHghqTtqE/3tbPxkqupwBG19iq1cSt86O 80CgWVOfSr0SaytD8vDZ//EkpCuwY4kHcq+fQcqFuIVUFgSayk1eoH63OJ3EBJyH DHZM5WhXTNbssl8ZI6HGEQxywdTqg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekgdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeduuefhiedtvddvueelfffhieeffedufeetgfejiefggfduteevkeev jeejfeeileenucffohhmrghinheprggsihhgnhhorhgvrdihohhunecukfhppeejjedrud efgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 749181080057; Sat, 23 Jan 2021 06:38:47 -0500 (EST) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Stephen Hemminger , David Marchand , Maxime Coquelin , Aaron Conole , Bruce Richardson , ferruh.yigit@intel.com, ray.kinsella@intel.com, mdr@ashroe.eu Date: Sat, 23 Jan 2021 12:38:45 +0100 Message-ID: <14261305.cmbqrkYmuW@thomas> In-Reply-To: <20210123012403.1bdb35d0@sovereign> References: <20201014183136.22239-1-dmitry.kozliuk@gmail.com> <5444857.Q0qPc8oPp2@thomas> <20210123012403.1bdb35d0@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/01/2021 23:24, Dmitry Kozlyuk: > On Fri, 22 Jan 2021 21:57:15 +0100, Thomas Monjalon wrote: > > 22/01/2021 21:31, Dmitry Kozlyuk: > > > On Wed, 20 Jan 2021 11:24:21 +0100, Thomas Monjalon wrote: > > > > 20/01/2021 08:23, Dmitry Kozlyuk: > > > > > On Wed, 20 Jan 2021 01:05:59 +0100, Thomas Monjalon wrote: > > > > > > This is now the right timeframe to introduce this change > > > > > > with the new Python module dependency. > > > > > > Unfortunately, the ABI check is returning an issue: > > > > > > > > > > > > 'const char mlx5_common_pci_pmd_info[62]' was changed > > > > > > to 'const char mlx5_common_pci_pmd_info[60]' at rte_common_mlx5.pmd.c > > > > > > > > > > Will investigate and fix ASAP. > > > > > > Now that I think of it: strings like this change every time new PCI IDs are > > > added to a PMD, but AFAIK adding PCI IDs is not considered an ABI breakage, > > > is it? One example is 28c9a7d7b48e ("net/mlx5: add ConnectX-6 Lx device ID") > > > added 2020-07-08, i.e. clearly outside of ABI change window. > > > > You're right. > > > > > "xxx_pmd_info" changes are due to JSON formatting (new is more canonical), > > > which can be worked around easily, if the above is wrong. > > > > If the new format is better, please keep it. > > What we need is an exception for the pmdinfo symbols > > in the file devtools/libabigail.abignore. > > You can probably use a regex for these symbols. > > This would allow real breakages to pass ABI check, abidiff doesn't analyze > variable content and it's not easy to compare. Maybe later a script can be > added that checks lines with RTE_DEVICE_IN in patches. There are at most 32 of > 5494 relevant commits between 19.11 and 20.11, though. > > To verify there are no meaningful changes I ensured empty diff between > results of the following command for "main" and the branch: > > find build/drivers -name '*.so' -exec usertools/dpdk-pmdinfo.py For now we cannot do such check as part of the ABI checker. And we cannot merge this patch if the ABI check fails. I think the only solution is to allow any change in the pmdinfo variables.