From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id F36F24C57
 for <dev@dpdk.org>; Tue, 24 Apr 2018 19:48:58 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 6BF9B20BC1;
 Tue, 24 Apr 2018 13:48:58 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 24 Apr 2018 13:48:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=MIm7IkBTyJLesPT0MvQOEAPJzL
 tcVkNfUwR6t4ntTX8=; b=WW0UHxOP24HvWOZdkYLXLIvsXJZO5YNcj6o2aSyDt/
 PeqQcKHpvfJgnoFfxIWPcFUuE/pNOTIhjaazXoffoPNb1/hdiQMhAAZ1+I7S1MZd
 I1El9zdCrMyl1ShRxyXNgzzd0p6SpjWCu40wtI37z85Ys91fk2eEpNff6g/4O7bF
 4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=MIm7Ik
 BTyJLesPT0MvQOEAPJzLtcVkNfUwR6t4ntTX8=; b=G4tRtAvhh+Yr6Is58whbhP
 kDCha436VbScfp6sx6bt6Nq3uAlweVvzcAJ1NsJ9xuJiPeTFKgO03V886KMIZHRA
 /H4pwG7vbptRDMTwwZl9bARgmub5d/97NOmHqJbYHLkQLfHYJpHgOjZm1xPSHECp
 8w2xvfKD1Kw/9WzgCIVpRnZAAwR3yukWBKT+KdxOv+7BqgAyi6DD4UUWmKBa98U5
 pXbc0q+ZpWIfWFaejNZ621hzVeH9rE25yyrMQVpX2lmb4yfR1EX+xBgc3V5mQYFh
 LyFhcdtxB/n9u9fUbLfQ+IZ/FothCUjmuMIjG2Va0E1FWOxF5icmmP6RjN7I6IoQ
 ==
X-ME-Sender: <xms:Cm7fWg32hqOJveUKHCn-H7uwIhsswJK9bWX7HphNCDBZHkmfTWhSyQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id ADB5FE4488;
 Tue, 24 Apr 2018 13:48:57 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Declan Doherty <declan.doherty@intel.com>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, Shahaf Shuler <shahafs@mellanox.com>
Date: Tue, 24 Apr 2018 19:48:56 +0200
Message-ID: <14274796.SAs9mKmsmb@xps>
In-Reply-To: <20180416130605.6509-4-declan.doherty@intel.com>
References: <20180328135433.20203-1-declan.doherty@intel.com>
 <20180416130605.6509-1-declan.doherty@intel.com>
 <20180416130605.6509-4-declan.doherty@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v7 3/9] ethdev: add generic create/destroy
	ethdev APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Apr 2018 17:48:59 -0000

16/04/2018 15:05, Declan Doherty:
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -348,7 +348,8 @@ rte_eth_dev_release_port(struct rte_eth_dev *eth_dev)
>  	rte_eth_dev_shared_data_prepare();
>  
>  	rte_spinlock_lock(&rte_eth_dev_shared_data->ownership_lock);
> -
> +	eth_dev->device = NULL;
> +	eth_dev->intr_handle = NULL;
>  	eth_dev->state = RTE_ETH_DEV_UNUSED;

Shouldn't it be in a separate patch with a proper explanation?


> + * @param device
> + *  rte_device handle.
> + * @param	name

There is a tab between param and name.


> --- a/lib/librte_ether/rte_ethdev_version.map
> +++ b/lib/librte_ether/rte_ethdev_version.map
> @@ -229,3 +229,11 @@ EXPERIMENTAL {
>  	rte_mtr_stats_update;
>  
>  } DPDK_17.11;
> +
> +EXPERIMENTAL {
> +	global:
> +
> +	rte_eth_dev_create;
> +	rte_eth_dev_destroy;
> +
> +} DPDK_18.05;

There is already an EXPERIMENTAL block.
Maybe you need to rebase.