From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id 3D1C55ABA for ; Thu, 9 Apr 2015 23:29:40 +0200 (CEST) Received: by paboj16 with SMTP id oj16so266261pab.0 for ; Thu, 09 Apr 2015 14:29:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=b2g2TiR7NSIFvBzxFTgLmaLfaV8vCnFA7p1fg4Kai4s=; b=AZqZRC0p6eFYBt3JYuScKnBMiLpMwcGV9aHFW5u9fB2XXS8YEgMGqqgrCqkPdJ0rm/ ApprS17dTVY5JC5stYIwOmfHtdEZ6KYrm2fYdJpIIIfcJ4wUaOacq0+wZuvUY1Kh24Rk p7MT5JEZpXFoM8Avdmeu0foj5+ybr0ZrhRjpFDPuOPwpjvuBqRViIv/FtaptXDCpT9wN ocr9sxxUr/COxzUP27FSmiSklC8L60kTZnDbD/gNdg29N0DqguEwNtzt+6P9kcKnUlRB ewq9Fc21vcXpJGWtHgyu1dXYWomgcZC96cLFHB3sW3BX/afnZdW/tBDxOC0pb/zuJHaQ /hBQ== X-Gm-Message-State: ALoCoQn54HwZXTJFZwtgSHPy4oYk1l7fRsNGiNuNoKNfLkJuO0Vt9iv8niCUZx3ACtIqiZ1/Hwt8 X-Received: by 10.66.120.69 with SMTP id la5mr60447116pab.66.1428614979566; Thu, 09 Apr 2015 14:29:39 -0700 (PDT) Received: from urahara.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id hz13sm15702717pab.6.2015.04.09.14.29.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Apr 2015 14:29:38 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Date: Thu, 9 Apr 2015 14:29:39 -0700 Message-Id: <1428614982-14135-2-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1428614982-14135-1-git-send-email-stephen@networkplumber.org> References: <1428614982-14135-1-git-send-email-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 1/4] rte_ethdev: remove extra inline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2015 21:29:40 -0000 There is no reason to inline functions that are not in the critical path. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index e20cca5..3120c3a 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -179,7 +179,7 @@ enum { DEV_ATTACHED }; -static inline void +static void rte_eth_dev_data_alloc(void) { const unsigned flags = 0; @@ -255,7 +255,7 @@ rte_eth_dev_allocate(const char *name, enum rte_eth_dev_type type) return eth_dev; } -static inline int +static int rte_eth_dev_create_unique_device_name(char *name, size_t size, struct rte_pci_device *pci_dev) { @@ -2415,7 +2415,7 @@ rte_eth_dev_priority_flow_ctrl_set(uint8_t port_id, struct rte_eth_pfc_conf *pfc return (-ENOTSUP); } -static inline int +static int rte_eth_check_reta_mask(struct rte_eth_rss_reta_entry64 *reta_conf, uint16_t reta_size) { @@ -2439,7 +2439,7 @@ rte_eth_check_reta_mask(struct rte_eth_rss_reta_entry64 *reta_conf, return -EINVAL; } -static inline int +static int rte_eth_check_reta_entry(struct rte_eth_rss_reta_entry64 *reta_conf, uint16_t reta_size, uint8_t max_rxq) @@ -2648,7 +2648,7 @@ rte_eth_led_off(uint8_t port_id) * Returns index into MAC address array of addr. Use 00:00:00:00:00:00 to find * an empty spot. */ -static inline int +static int get_mac_addr_index(uint8_t port_id, struct ether_addr *addr) { struct rte_eth_dev_info dev_info; @@ -2789,7 +2789,7 @@ rte_eth_dev_set_vf_rxmode(uint8_t port_id, uint16_t vf, * Returns index into MAC address array of addr. Use 00:00:00:00:00:00 to find * an empty spot. */ -static inline int +static int get_hash_mac_addr_index(uint8_t port_id, struct ether_addr *addr) { struct rte_eth_dev_info dev_info; -- 2.1.4