From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 7922F800A for ; Fri, 10 Oct 2014 13:06:54 +0200 (CEST) Received: by mail-wg0-f42.google.com with SMTP id z12so3565424wgg.13 for ; Fri, 10 Oct 2014 04:14:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=VwG8g2tlxUkZyxLHnWYsc0u8B59wzGpXfM7RIKEKBi4=; b=i9mTgMYZTGvs6zdueBhgTDyQ+IeeoN1pz+D0Q98wS6s+k7AlavSMpbgN/GYJNNLcyr QldP5sgghLqJBeyAX9/l/GPpJOCRxsBDE8KbAaZjNgXm/wzr0sNRLnNajYWxuCQdtvW3 XzICeOmRmMRbrwQ/WEZJZe4SRMHO5Q3v3Q1KV8L736yKzTtjtgXOwXvvI5+h6mhjyYRi hChEvw/tW1sehh9/SMbfqPcU2XYkOH2S7m67YMmuvWGXL0Mi/HxcYxFXkIg24AuPca+I bDLYJhooo60Y8dWlT1C57PNJMFSYDQwAMSN9HFUUREXRzzgosGbbCgcu33xJYeGjB52F ZNxQ== X-Gm-Message-State: ALoCoQkDs13KHK6kMNxp8MocNKL6m2aqUmOPV5cKmiIpd14v9Zy0lD4pO8f8L3P0IOgwBxwUtj07 X-Received: by 10.180.96.226 with SMTP id dv2mr4127142wib.48.1412939660538; Fri, 10 Oct 2014 04:14:20 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id di1sm2256130wib.21.2014.10.10.04.14.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Oct 2014 04:14:19 -0700 (PDT) From: Thomas Monjalon To: Pablo de Lara Date: Fri, 10 Oct 2014 13:14:02 +0200 Message-ID: <1430683.lO0q5i9e6O@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1412156945-6549-3-git-send-email-pablo.de.lara.guarch@intel.com> References: <1412150458-26213-1-git-send-email-pablo.de.lara.guarch@intel.com> <1412156945-6549-1-git-send-email-pablo.de.lara.guarch@intel.com> <1412156945-6549-3-git-send-email-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 2/3] pmd: Modified dev_info structure to include default RX/TX configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Oct 2014 11:06:54 -0000 Pablo, I have some minor nits on this patchset. If you agree, I can fix them before applying the patchset. 2014-10-01 10:49, Pablo de Lara: > +/** > + * Default values for port configuration > + */ > +#define IGB_DEFAULT_RX_FREE_THRESH 32 > +#define IGB_DEFAULT_RX_PTHRESH 8 > +#define IGB_DEFAULT_RX_HTHRESH 8 > +#define IGB_DEFAULT_RX_WTHRESH 0 > + > +#define IGB_DEFAULT_TX_PTHRESH 32 > +#define IGB_DEFAULT_TX_HTHRESH 0 > +#define IGB_DEFAULT_TX_WTHRESH 0 Comments in .c files are not for doxygen. So /** should be replaced by /* > static int eth_igb_get_5tuple_filter(struct rte_eth_dev *dev, > uint16_t index, > struct rte_5tuple_filter *filter, uint16_t *rx_queue); > - > /* > * Define VF Stats MACRO for Non "cleared on read" register > */ This blank line shouldn't be removed. Probably a typo? -- Thomas