From: Thomas Monjalon <thomas@monjalon.net>
To: guyk@marvell.com
Cc: orika@mellanox.com, jerinj@marvell.com, ndabilpuram@marvell.com,
mdr@ashroe.eu, nhorman@tuxdriver.com, bruce.richardson@intel.com,
anatoly.burakov@intel.com, john.mcnamara@intel.com,
marko.kovacevic@intel.com, dev@dpdk.org, smadarf@marvell.com,
dovrat@marvell.com, lironh@marvell.com
Subject: Re: [dpdk-dev] [PATCH v2 2/4] regex/octeontx2: add build infra and device support
Date: Mon, 12 Oct 2020 16:33:20 +0200 [thread overview]
Message-ID: <14309339.Y1dYQgYOla@thomas> (raw)
In-Reply-To: <20201012113135.19476-3-guyk@marvell.com>
12/10/2020 13:31, guyk@marvell.com:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1118,6 +1118,9 @@ F: drivers/regex/mlx5/
> F: doc/guides/regexdevs/mlx5.rst
> F: doc/guides/regexdevs/features/mlx5.ini
>
> +Marvell OCTEON TX2 regex
> +M: Guy Kaneti <guyk@marvell.com>
> +F: drivers/regex/octeontx2/
>
A blank line is missing.
Please sort in alphabetical order.
> --- /dev/null
> +++ b/drivers/regex/octeontx2/rte_pmd_octeontx2_regex_version.map
> @@ -0,0 +1,3 @@
> +DPDK_20.08 {
> + local: *;
> +};
Should be DPDK_21
> --- a/meson_options.txt
> +++ b/meson_options.txt
> +option('ree_compiler_sdk', type: 'string', value: '',
> + description: 'path to REE compiler SDK optional library for regex device')
Is this SDK specific to Marvell or octeontx2?
If yes, it should appear here.
Why this SDK requires setting the path manually?
Well designed libs should use pkg-config.
next prev parent reply other threads:[~2020-10-12 14:33 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 12:24 [dpdk-dev] [PATCH 0/4] Add Marvell OCTEON TX2 regex driver guyk
2020-09-01 12:24 ` [dpdk-dev] [PATCH 1/4] common/octeontx2: add REE definitions and logging support guyk
2020-10-11 7:35 ` Liron Himi
2020-09-01 12:24 ` [dpdk-dev] [PATCH 2/4] regex/octeontx2: add build infra and device support guyk
2020-10-11 7:36 ` Liron Himi
2020-09-01 12:24 ` [dpdk-dev] [PATCH 3/4] usertools: add octeontx2 REE device binding guyk
2020-10-11 7:36 ` Liron Himi
2020-09-01 12:24 ` [dpdk-dev] [PATCH 4/4] doc: add Marvell OCTEON TX2 regex guide guyk
2020-10-11 7:36 ` Liron Himi
2020-10-08 6:31 ` [dpdk-dev] [PATCH 0/4] Add Marvell OCTEON TX2 regex driver Guy Kaneti
2020-10-11 21:23 ` Thomas Monjalon
2020-10-12 11:34 ` [dpdk-dev] [EXT] " Guy Kaneti
2020-10-12 11:31 ` [dpdk-dev] [PATCH v2 " guyk
2020-10-12 11:31 ` [dpdk-dev] [PATCH v2 1/4] common/octeontx2: add REE definitions and logging support guyk
2020-10-12 11:31 ` [dpdk-dev] [PATCH v2 2/4] regex/octeontx2: add build infra and device support guyk
2020-10-12 14:33 ` Thomas Monjalon [this message]
2020-10-12 17:06 ` [dpdk-dev] [EXT] " Guy Kaneti
2020-10-12 17:10 ` Thomas Monjalon
2020-10-12 17:13 ` Guy Kaneti
2020-10-12 17:19 ` Thomas Monjalon
2020-10-12 11:31 ` [dpdk-dev] [PATCH v2 3/4] usertools: add octeontx2 REE device binding guyk
2020-10-12 14:35 ` Thomas Monjalon
2020-10-12 11:31 ` [dpdk-dev] [PATCH v2 4/4] doc: add Marvell OCTEON TX2 regex guide guyk
2020-10-12 14:38 ` Thomas Monjalon
2020-10-12 17:09 ` [dpdk-dev] [EXT] " Guy Kaneti
2020-10-12 17:12 ` Thomas Monjalon
2020-10-13 10:10 ` [dpdk-dev] [PATCH v3 0/3] Add Marvell OCTEON TX2 regex driver guyk
2020-10-13 10:10 ` [dpdk-dev] [PATCH v3 1/3] common/octeontx2: add REE definitions and logging support guyk
2020-10-14 8:18 ` Thomas Monjalon
2020-10-13 10:10 ` [dpdk-dev] [PATCH v3 2/3] regex/octeontx2: add build infra and device support guyk
2020-10-14 8:26 ` Thomas Monjalon
2020-10-13 10:10 ` [dpdk-dev] [PATCH v3 3/3] usertools: add octeontx2 REE device binding guyk
2020-10-14 8:42 ` [dpdk-dev] [PATCH v3 0/3] Add Marvell OCTEON TX2 regex driver Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14309339.Y1dYQgYOla@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dovrat@marvell.com \
--cc=guyk@marvell.com \
--cc=jerinj@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=lironh@marvell.com \
--cc=marko.kovacevic@intel.com \
--cc=mdr@ashroe.eu \
--cc=ndabilpuram@marvell.com \
--cc=nhorman@tuxdriver.com \
--cc=orika@mellanox.com \
--cc=smadarf@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).